From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9A3C43219 for ; Fri, 18 Nov 2022 03:52:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 515106B0075; Thu, 17 Nov 2022 22:52:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C46B6B0078; Thu, 17 Nov 2022 22:52:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38C516B007B; Thu, 17 Nov 2022 22:52:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 203A56B0075 for ; Thu, 17 Nov 2022 22:52:04 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E29FBA126F for ; Fri, 18 Nov 2022 03:52:03 +0000 (UTC) X-FDA: 80145189726.15.FA84E51 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf22.hostedemail.com (Postfix) with ESMTP id 81BBFC0010 for ; Fri, 18 Nov 2022 03:52:03 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id q1so3921422pgl.11 for ; Thu, 17 Nov 2022 19:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bpPiECtcuuwxxZW6I2l04Yvk+0H4NlRCXaVbSAhBEDs=; b=Y4k+ITVdnWabWfy2tpUEza7/ctINKSkaBCZ3/PX3qAfvyf89lki00V0Xwn2eethcgE uklfgJsqroV1nl1rka+esAOWp1TVQZrLJB8wd4WQlZocW/JszizcYUWarJxjffrgQ6R0 ru/MdhgJmf+22TnqXyIM1tBM2WrHzqbDsi/U4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bpPiECtcuuwxxZW6I2l04Yvk+0H4NlRCXaVbSAhBEDs=; b=W705a+wgJXD4eH1TigMLX1+Gv1qL+kc5j4dvuso7i/UApNFnlrT4Y75Q68b3hMMhll HrWv7GaZgyXwrZL9p+UCoPvywUQ+R+BwZ0FhxWsjKVDESAbwiyyLi67EFYkK365wbVyb hrsjs1MrRBIZhsMRbf1JujP+tOBZdFouVRo5CpGDT9QTiyZrKbXOMUN9uskYLeXCxsnr dKEKxgEIwIRc23+Z5iuc4YxhXIfG6qh6UzuImsfe+3aQv9Cr4u7ZX4JTH59PzAjebV2F PB123IGYam3lxz2J1qbnljuin7sGKdBs2rzGXKtmVb69PU4su/Cp0Pkj7zDUkUa/+uCZ vErQ== X-Gm-Message-State: ANoB5pkUlmYOx9M7kH+xTjC4ixUaNCfJu+N/Eoc3kwxdsOUPNWafpiEn ik30+IgQhtYN31k2PfcWsDbX+w== X-Google-Smtp-Source: AA0mqf5LIOGY++xcoY7JcVjGfKd3ueopnrI6Mq6ww0CuYAUNPQKL6pVl34gT7LPuQraWiXJ/HTNFkA== X-Received: by 2002:a62:d441:0:b0:53e:6210:96de with SMTP id u1-20020a62d441000000b0053e621096demr5945073pfl.58.1668743522435; Thu, 17 Nov 2022 19:52:02 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r11-20020a63ec4b000000b0043ae1797e2bsm1794260pgj.63.2022.11.17.19.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 19:52:01 -0800 (PST) From: Kees Cook To: Vlastimil Babka Cc: Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: [PATCH v2 0/2] slab: Provide full coverage for __alloc_size attribute Date: Thu, 17 Nov 2022 19:51:57 -0800 Message-Id: <20221118034713.gonna.754-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1019; h=from:subject:message-id; bh=PjCBiF2sN+bzrV7VCSddGmjoguZq6Cl6RI+yFLufVf4=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBjdwFfNcru+k/Q+zCg8JWAMeqDxHq8sLjKOG5JeKE3 0h6oVzaJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCY3cBXwAKCRCJcvTf3G3AJj5/D/ 42TO5oeunaOTHbu1yBGFAh47GzImY9MtSgcNOrMok8hnHPtevpfbnlSegxe0HbUP7jbID1ihtqFruR b8XwYzWQxIBMoIc21M5aD70wqlFyfKI0jwWu6i7jVgCOakCY2VPKMOXU7SXtCwcXcvdx+7jyT/axy+ FLnWHtyr+DeWh639lj+oqqG6Bb1O9iVV/ghsBoHdYybtRNVdG67KqyXBHRz0shvKapS2sLhe5jUUrv 0lCjDp4s4oww7gnWYrYYzFlE1s7WBWLMS8QG93zUHMG3jzdWueNlaWbOrylPuYhHimLpG2bANJxQYs 8Odnd1Se+AJd4aXvCfxOxIsfI4pT2yjepl04B8gtXjYD/0I3zO+qXORjitTA1VmYijAWVU+WQ/Qno/ tELZotiNyAwbA0PjhtqMuXZ/VC4PXHZ7uy3rJioJEB8eo60gh3FX1U+vs51KxSHPaxZt+LLnmDz1ts 2PhSrilHbcTMd9nawq8EgdDJ0odurxcwsZFvHXAVaWsW8L8Z0LecdXWGfKI1BH3ndVyBgC7/QoowC5 +Qv6EtEdFp5kz+3miOfrxz/EHw/2rWb0tf1X3T3sUBoUr8TAUFcc34oG+BicxWUXltcl3CAptWVBK/ izeVl073EbSAffqbEN+BuSxGy7gJTPTYNrU7DwWVkCVbUgihdfgC9c+Xrn9g== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668743523; a=rsa-sha256; cv=none; b=4ndsb5t85e+NskWEpe9fCDfo3MbIOScB6qtPKPCB6OX87ExHQoECYgik3k+VcJp38tFxeT 3BoFggRpnKAylaTqjlvrfx6rAjFkV8pIEUojmTTgMGK9TQ4yK5O5yEmlngk/nPphVtOD5s pW2iiME2hyfRxmBvJAt45zfb2tPKoCo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Y4k+ITVd; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668743523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=bpPiECtcuuwxxZW6I2l04Yvk+0H4NlRCXaVbSAhBEDs=; b=0+rooSPD7vjMwD2edAyJbPfcr/j0C7OS5Ml6q+G7/GMxVOvo+NPw6KkWcTE3ZHm1/wUu/C r4KjziQz9R13s28h9IaqfsWEXN0m933b26kKlll5h5pne/eWGk1GtB63u46GakaDr7f18X KxVtfojOPGQK73SNbqIJZR5yoQudvvA= X-Stat-Signature: xcgbmqbp6s6sey38683d6kqyu6trrq4y X-Rspamd-Queue-Id: 81BBFC0010 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Y4k+ITVd; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668743523-85738 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, These patches work around a deficiency in GCC (>=11) and Clang (<16) where the __alloc_size attribute does not apply to inlines. :( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96503 This manifests as reduced overflow detection coverage for many allocation sites under CONFIG_FORTIFY_SOURCE=y, where the allocation size was not actually being propagated to __builtin_dynamic_object_size(). The problem was in two halves: the trace wrapper (now fixed in -next), and const-0 special-casing (covered here). Thanks, -Kees v2: - drop trace wrapper refactoring -- handled differently now (vbabka) - drop kunit/fortify test patch since it depends on other changes - rebase v1: https://lore.kernel.org/all/20221101222520.never.109-kees@kernel.org Kees Cook (2): slab: Clean up SLOB vs kmalloc() definition slab: Remove special-casing of const 0 size allocations include/linux/slab.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) -- 2.34.1