From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C51C433FE for ; Thu, 17 Nov 2022 22:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A51588E0001; Thu, 17 Nov 2022 17:21:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A00AE6B0073; Thu, 17 Nov 2022 17:21:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C82F8E0001; Thu, 17 Nov 2022 17:21:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B9466B0072 for ; Thu, 17 Nov 2022 17:21:48 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 443B3811E4 for ; Thu, 17 Nov 2022 22:21:48 +0000 (UTC) X-FDA: 80144357496.27.33F3C1A Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf25.hostedemail.com (Postfix) with ESMTP id D4796A000E for ; Thu, 17 Nov 2022 22:21:47 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id v3so3367529pgh.4 for ; Thu, 17 Nov 2022 14:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=lSwJV2KYxBElCKXN+JgGSpLARwCfSn0ae92xplQAFic=; b=TwEHZg8sV4C4VuUBGudICbSbcvrp8OQsn0eQKHKdMKujOovO5I+rxSVCirl/IR5r7S 7uWpBOwAOUgJRYgGlPkl+JBNzE7LvNJgU9wNg7Lal5ktuI8OAKWTl7I3yfRXNdIl4NvF EZVjOTol9GfLD5u3GgNM46VUoBtQfFWCWkJDE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lSwJV2KYxBElCKXN+JgGSpLARwCfSn0ae92xplQAFic=; b=eSXNagi7H87ZFy0fkjH5OZPSyA/P6ElZacsP4JPgcxYLllhggln+Az5YisMSYvuIsz wzw2QpB40p79rtkiRVuVkOosJ822bIeuP2lYBeOJNd+GK9tkRRp+mIzPsz78kBH6DQfB Y+W1WGxfOhDVtibaJA4CAj2vMvAB91dEgQ3KaQYQuZoObGKvj5L1Qi56DiXqfcCi9jx2 DsgIH+Gd9eBGYkdxrhMrAk29vjkMZv4vSzq35zY80U2wC03YjKDzTBbB/Cc1vWdr+rHM r/BU+itFEu2Rr8sIA8DFl3lhrBlfUMvOkh8Y5qi+XaxEfGQtQoNyzAMBLpIVq8vhlUph wGSA== X-Gm-Message-State: ANoB5plIOssq+fVJzXNhqa0oKK+GX//aOCvGGpLArtogCwHHIYVdR9cE lSgnR35XoO+V9NCuk+QULE+gZA== X-Google-Smtp-Source: AA0mqf6nbW+rxyP+i6B7Axg0KIP23raSHJTeKi8rSP5n/ZD0poWcqUnhn4XDJpFixIo7gBZXc1VuZg== X-Received: by 2002:a63:887:0:b0:460:633b:5702 with SMTP id 129-20020a630887000000b00460633b5702mr4093864pgi.9.1668723706884; Thu, 17 Nov 2022 14:21:46 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s12-20020a63f04c000000b0047681fa88d1sm1554188pgj.53.2022.11.17.14.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 14:21:46 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Thu, 17 Nov 2022 14:21:46 -0800 To: Ananda Cc: Jonathan Corbet , linux-kernel@vger.kernel.org, Minchan Kim , Ananda Badmaev , Andrew Morton , Sergey Senozhatsky , linux-mm@kvack.org, linux-doc@vger.kernel.org, Vitaly Wool , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: zblock_reclaim_block(): Control flow issues Message-ID: <202211171421.914F0F3719@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668723707; a=rsa-sha256; cv=none; b=j2Dfx7wbv3E9zeaQb1aKeJ3qCDF5ZRUl2qUU3VyE7aYvgisFrYXic9Xbp9a3OAZxRNhxuy I5GfpzE9b0syCL2+1d0HFZQMedfmuPtenIq4tzswp7yLnDEnbJA585WTJmHib/M/Fk5T7K vA7EDFBdYuEVylgfp5godjQ5UoQSohA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TwEHZg8s; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668723707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=lSwJV2KYxBElCKXN+JgGSpLARwCfSn0ae92xplQAFic=; b=eKiTxex4uX5glZAAJCmmX7vRL88CndMf5QxZ1yanLxgWl7BywvUvFVrpA4AWjQ+kqOEN+s iShOdagPCmm7BpRPpQBY6jd0SVKp2VBncNk1skSoUvfxa8jU/uhk/GJC6UesYy/nVkJqIN STDinzmprR3kVJq7cKpwjAvBWYwzlHM= X-Stat-Signature: xya1cqrzrerd6h75hsz89d7kan1zsumf X-Rspamd-Queue-Id: D4796A000E Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TwEHZg8s; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1668723707-152592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221117 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Wed Nov 16 16:19:12 2022 -0800 9097e28c25c8 ("mm: add zblock - new allocator for use via zpool API") Coverity reported the following: *** CID 1527349: Control flow issues (NO_EFFECT) mm/zblock.c:412 in zblock_reclaim_block() 406 unsigned long handle, block_type, slot; 407 int ret, i, reclaimed; 408 409 /* start with list storing blocks with the worst compression and try 410 * to evict the first added (oldest) block in this list 411 */ vvv CID 1527349: Control flow issues (NO_EFFECT) vvv This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "block_type >= 0UL". 412 for (block_type = ARRAY_SIZE(block_desc) - 1; block_type >= 0; --block_type) { 413 list = &(pool->block_lists[block_type]); 414 spin_lock(&list->lock); 415 416 /* find the oldest block in list */ 417 block = list_last_entry(&list->head, struct zblock_block, block_node); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1527349 ("Control flow issues") Fixes: 9097e28c25c8 ("mm: add zblock - new allocator for use via zpool API") Thanks for your attention! -- Coverity-bot