From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770F4C4332F for ; Thu, 17 Nov 2022 22:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B356B0071; Thu, 17 Nov 2022 17:20:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBB438E0001; Thu, 17 Nov 2022 17:20:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5C396B0073; Thu, 17 Nov 2022 17:20:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C89CA6B0071 for ; Thu, 17 Nov 2022 17:20:57 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 884B71406EF for ; Thu, 17 Nov 2022 22:20:57 +0000 (UTC) X-FDA: 80144355354.11.FEC549A Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 78B694000C for ; Thu, 17 Nov 2022 22:20:55 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id f3so3380318pgc.2 for ; Thu, 17 Nov 2022 14:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=bjS6jookRrLkIHeYFvmyUyMulRHdRVN48lVIAprlZtM=; b=esyTb2QqEwsZejmwz7RU3JJ/i5bs3jD0w1QGDpAJH1x7k6LWmTRroC60wf3LkiQZLN eNzs/WrAD9z01vxJieYSulq6bEkAItXkpfdFjaCTd8bVSYKNtAfLOfDVKDhmQHtNqztV AXvzI1owCvL7HdSQetShxaVlNBZX95DHdcPe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bjS6jookRrLkIHeYFvmyUyMulRHdRVN48lVIAprlZtM=; b=VwTwB+Y+LxtnYXmaBuYoazj+RONQ6d5kEZ3T5mq1e2DIDl6yMTh2Q4T2ZHUvU0lzcg gvepcuSt1/cl71eik+5fQPfj2u8JqcHgBTqRfINxvSAyc7l3zp4hgUVgpAmdLz8OmDn9 01fHoSRDT0FqwrQS4f68pouPKiSDMSJIddH5+HkILS4/K0FoAYlHqayZW/re+vhUHilh k6/EeyI3CukC+M84QuTIa0Epv6jUcxXmUEBJmoTRu8M2hXMfiBnvW3EZJpWjHosq+gDZ 0vyfCw95hkf7+z7/2fR3EZnLLMGgqLxzoPqq5gxQ45oFlIf4t4+Pl8XnQ5LrTsaNcj/m 1thw== X-Gm-Message-State: ANoB5pnEdzrigd1IICrYAU9myGEit8ZeoNwkZNq+exKmdWJomWP97vVV L8WvfZftwu6GoHRrkyjrSHpZOQ== X-Google-Smtp-Source: AA0mqf4r3HdCLyGjlDNNJSDNoS0327aEbPFi/nn+EtIWawSgs3Mp2p73ChMQv6KDBFKeTRgisUmgEQ== X-Received: by 2002:a63:4b50:0:b0:459:16e5:9dd9 with SMTP id k16-20020a634b50000000b0045916e59dd9mr3927200pgl.362.1668723654307; Thu, 17 Nov 2022 14:20:54 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b11-20020a170902650b00b00178b9c997e5sm1913492plk.138.2022.11.17.14.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 14:20:54 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Thu, 17 Nov 2022 14:20:53 -0800 To: Ananda Cc: Jonathan Corbet , linux-kernel@vger.kernel.org, Minchan Kim , Ananda Badmaev , Andrew Morton , Sergey Senozhatsky , linux-mm@kvack.org, linux-doc@vger.kernel.org, Vitaly Wool , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: zblock_alloc(): Memory - illegal accesses Message-ID: <202211171419.FCDC8EE@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668723655; a=rsa-sha256; cv=none; b=t+OAg4EHvDh2f0j4rBni5tsYoFyYm8oZRQT5SjhX95u7CvF8/L30qQKdCAbrZvBWiA/SaI 7WjY6qm0kwfDoX9bpzO+BsXU7M7Z9CWpFGi0Ez+hgpvaW5zbEKDtyTHlW+HCD71BgpPJJD UGueELule7a/ZhJlfqSnTe3zZXXuGjE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=esyTb2Qq; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668723655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=bjS6jookRrLkIHeYFvmyUyMulRHdRVN48lVIAprlZtM=; b=GGmvQ6k4uHOZHGPPI19m5eXZ09DRjuAqHt8TwwYovYJElaQufmS+B9ASS4mCxlOMoYdkLJ BXuy1iLPYZ+iTHihLCSICltjD1wgy/FDKMDbnZZ6npX+3AA2txxLohK6+B5zNg2oBIfTn/ 3zxcZV2ui2CdLA1/30f//Gc4Z8xbLt8= X-Stat-Signature: j986cxid3ebrgoi1mkp18dman1o7jb8w X-Rspamd-Queue-Id: 78B694000C Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=esyTb2Qq; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1668723655-1440 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000172, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221117 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Wed Nov 16 16:19:12 2022 -0800 9097e28c25c8 ("mm: add zblock - new allocator for use via zpool API") Coverity reported the following: *** CID 1527352: Memory - illegal accesses (OVERRUN) mm/zblock.c:320 in zblock_alloc() 314 } 315 list = &(pool->block_lists[block_type]); 316 317 check: 318 spin_lock(&list->lock); 319 /* check if there are free slots in cache */ vvv CID 1527352: Memory - illegal accesses (OVERRUN) vvv Overrunning array of 10208 bytes at byte offset 10208 by dereferencing pointer "list". 320 block = cache_find_block(list); 321 if (block) 322 goto found; 323 spin_unlock(&list->lock); 324 325 /* not found block with free slots try to allocate new empty block */ If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1527352 ("Memory - illegal accesses") Fixes: 9097e28c25c8 ("mm: add zblock - new allocator for use via zpool API") It looks like block_type is not checked to be < ARRAY_SIZE(block_desc) after exiting the earlier loop, so the access through "list" may be past the end of pool->block_lists. Thanks for your attention! -- Coverity-bot