From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF45C433FE for ; Thu, 17 Nov 2022 07:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DB7F6B0073; Thu, 17 Nov 2022 02:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 364BE6B0074; Thu, 17 Nov 2022 02:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 206216B0075; Thu, 17 Nov 2022 02:47:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0D0496B0073 for ; Thu, 17 Nov 2022 02:47:20 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DDFDE1A06EA for ; Thu, 17 Nov 2022 07:47:19 +0000 (UTC) X-FDA: 80142153798.13.EBBD32D Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf29.hostedemail.com (Postfix) with ESMTP id 8360812000C for ; Thu, 17 Nov 2022 07:47:19 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id k8so2327668wrh.1 for ; Wed, 16 Nov 2022 23:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2tCwhucR2jYzOzAhHaj93G9eQkKme2+l5tf3lCT/bAk=; b=e4lhQwNafr0LYDpkAQZ0GYnRs6FZ05AsH6y63y5FKK3RUN+e9vNrWeH2XLqvMY/qIn HbcfR5T8+Hzj3WcCD5F0dBw02oQ+ucZxi9rsLGmddZsvxTapMDwR/Yr2b0s4y1n84GAo mUBLPrKQqcYypXO8wUfE6FnMSvkMUyCxvnZ1eW3yFfc40+WbyhoZe+0Ey5CabRLg5XCr +sOoRK/FocIsYdOKq1+ZjdIH9vG8KnAp3fIija5VHMhQCQZMtFrC3xaJ7HWKAbpxVqPl k5Qxi/8/mu/7scFrCisFgjubNB+tX+U94yNuCgJMERpPi6lLJRQkz2dchBvtKjs7w6Vs Kx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2tCwhucR2jYzOzAhHaj93G9eQkKme2+l5tf3lCT/bAk=; b=BTOspkMy9LpZw+GLxXi6Vg6Ks+wKJjB++3JzV6RXzCcLQJn5Z9zFqEBmR5mOC9utZS zff7cwFA9cuk83+6qBuS3RqgEtkqe21bpS4NhiIlRPUnYrJ7lvukTvPIRHbqHRXcNYl2 byLBUhhWD7CcrFJkGUvjNVVi1AaL+9bYzROHE9wtb7K32JlMryHl5ZMcTjNt3v1n/0ch k4tMFZWVg6wMs2aPPaAet4vB1p+VPmDu/qaDfb6Hzb+eyZL7mq97UA9tACIj5McyoJmG rl9WjHMMNErC0lHZcdZISk7f46V8BcCok/pWL5B87wV4+pE+N2Hpj6Yrqg8hNYk/MwOy ZPKg== X-Gm-Message-State: ANoB5pnTJOIql2SPh5nyQcQAMkDh4uUQtfYeH74QPblZxdfUG2F12t0Z Ba6ZrJs3JE8yL/079YSm2Ps= X-Google-Smtp-Source: AA0mqf4xoUqKJ85rBZn4pK66bA0JfhfxdVrz3TCqLEzx4BH6Ag+Yx5Qv+O+vXXxE1GcMz0Fk+oj8ig== X-Received: by 2002:a05:6000:124d:b0:236:a68f:23e2 with SMTP id j13-20020a056000124d00b00236a68f23e2mr621731wrx.521.1668671238214; Wed, 16 Nov 2022 23:47:18 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id g17-20020a05600c311100b003cf4ec90938sm361808wmo.21.2022.11.16.23.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 23:47:17 -0800 (PST) Date: Thu, 17 Nov 2022 10:47:14 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Ben Skeggs Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Lyude Paul Subject: [linux-next:master 5613/8327] drivers/gpu/drm/nouveau/nouveau_dp.c:237 nouveau_dp_irq() warn: variable dereferenced before check 'outp' (see line 232) Message-ID: <202211170722.QtP5uInh-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668671239; a=rsa-sha256; cv=none; b=tiMThJloJjNW2D8dwl5zaj3rj97oHHqQRr+f63NsS/F1NzpbawtVrVbYlYLH4SPrXLD70c UxVWlXgO64aErngYlRP/d0g3Ygi2gxG2F4LCIiBg/s7SkxuH5KDWfuAms7UuD3Mat7nT2R rsgd1E2j3HCqVYwrXqK38gP6WEAOXNw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e4lhQwNa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of error27@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=error27@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668671239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2tCwhucR2jYzOzAhHaj93G9eQkKme2+l5tf3lCT/bAk=; b=fvcAiCfyfQVnA0fkqEsrvMP1coUU6fSsPdCa77kX+qgdOrKsd8q6hoVna3o90qIfi+nqKV H0mAVUL22cfn0Cl2yYTBXHRl+mdI3dpRGd6VEGh0zeBe7DzNg9M5Rj31mGzabPndTRpO1F cR3wngSQds20PuVdORJf8xn5eJQDSZ0= X-Stat-Signature: odnqa7bzc8uqjkpt5su9pkixnswgi4k3 X-Rspamd-Queue-Id: 8360812000C X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e4lhQwNa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of error27@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=error27@gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1668671239-940389 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 15f3bff12cf6a888ec2ad39652828c60e6836b3d commit: 773eb04d14a11552b2c3953097ed09cde2ab4831 [5613/8327] drm/nouveau/disp: expose conn event class config: loongarch-randconfig-m041-20221114 compiler: loongarch64-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: drivers/gpu/drm/nouveau/nouveau_dp.c:237 nouveau_dp_irq() warn: variable dereferenced before check 'outp' (see line 232) vim +/outp +237 drivers/gpu/drm/nouveau/nouveau_dp.c 773eb04d14a1155 Ben Skeggs 2022-06-01 225 void 773eb04d14a1155 Ben Skeggs 2022-06-01 226 nouveau_dp_irq(struct work_struct *work) a0922278f83eae0 Lyude Paul 2020-08-26 227 { 773eb04d14a1155 Ben Skeggs 2022-06-01 228 struct nouveau_connector *nv_connector = 773eb04d14a1155 Ben Skeggs 2022-06-01 229 container_of(work, typeof(*nv_connector), irq_work); a0922278f83eae0 Lyude Paul 2020-08-26 230 struct drm_connector *connector = &nv_connector->base; a0922278f83eae0 Lyude Paul 2020-08-26 231 struct nouveau_encoder *outp = find_encoder(connector, DCB_OUTPUT_DP); 773eb04d14a1155 Ben Skeggs 2022-06-01 @232 struct nouveau_drm *drm = nouveau_drm(outp->base.base.dev); ^^^^^^ New dereference. a0922278f83eae0 Lyude Paul 2020-08-26 233 struct nv50_mstm *mstm; 016dacb60e6d4b3 Ben Skeggs 2022-06-01 234 u64 hpd = 0; a4efad354cf1b9d Lyude Paul 2020-08-26 235 int ret; a0922278f83eae0 Lyude Paul 2020-08-26 236 a0922278f83eae0 Lyude Paul 2020-08-26 @237 if (!outp) ^^^^^ Checked too late. a0922278f83eae0 Lyude Paul 2020-08-26 238 return; a0922278f83eae0 Lyude Paul 2020-08-26 239 a0922278f83eae0 Lyude Paul 2020-08-26 240 mstm = outp->dp.mstm; a0922278f83eae0 Lyude Paul 2020-08-26 241 NV_DEBUG(drm, "service %s\n", connector->name); a0922278f83eae0 Lyude Paul 2020-08-26 242 a0922278f83eae0 Lyude Paul 2020-08-26 243 mutex_lock(&outp->dp.hpd_irq_lock); a0922278f83eae0 Lyude Paul 2020-08-26 244 a0922278f83eae0 Lyude Paul 2020-08-26 245 if (mstm && mstm->is_mst) { a0922278f83eae0 Lyude Paul 2020-08-26 246 if (!nv50_mstm_service(drm, nv_connector, mstm)) 773eb04d14a1155 Ben Skeggs 2022-06-01 247 hpd |= NVIF_CONN_EVENT_V0_UNPLUG; a0922278f83eae0 Lyude Paul 2020-08-26 248 } else { a0922278f83eae0 Lyude Paul 2020-08-26 249 drm_dp_cec_irq(&nv_connector->aux); a4efad354cf1b9d Lyude Paul 2020-08-26 250 a4efad354cf1b9d Lyude Paul 2020-08-26 251 if (nouveau_dp_has_sink_count(connector, outp)) { a4efad354cf1b9d Lyude Paul 2020-08-26 252 ret = drm_dp_read_sink_count(&nv_connector->aux); a4efad354cf1b9d Lyude Paul 2020-08-26 253 if (ret != outp->dp.sink_count) 773eb04d14a1155 Ben Skeggs 2022-06-01 254 hpd |= NVIF_CONN_EVENT_V0_PLUG; a4efad354cf1b9d Lyude Paul 2020-08-26 255 if (ret >= 0) a4efad354cf1b9d Lyude Paul 2020-08-26 256 outp->dp.sink_count = ret; a4efad354cf1b9d Lyude Paul 2020-08-26 257 } a0922278f83eae0 Lyude Paul 2020-08-26 258 } a0922278f83eae0 Lyude Paul 2020-08-26 259 a0922278f83eae0 Lyude Paul 2020-08-26 260 mutex_unlock(&outp->dp.hpd_irq_lock); a4efad354cf1b9d Lyude Paul 2020-08-26 261 773eb04d14a1155 Ben Skeggs 2022-06-01 262 nouveau_connector_hpd(nv_connector, NVIF_CONN_EVENT_V0_IRQ | hpd); a0922278f83eae0 Lyude Paul 2020-08-26 263 } -- 0-DAY CI Kernel Test Service https://01.org/lkp