From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BC2C433FE for ; Wed, 16 Nov 2022 21:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98CEB6B0072; Wed, 16 Nov 2022 16:52:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D3D6B0073; Wed, 16 Nov 2022 16:52:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82BF16B0074; Wed, 16 Nov 2022 16:52:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7605B6B0072 for ; Wed, 16 Nov 2022 16:52:47 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 45CAE1A0186 for ; Wed, 16 Nov 2022 21:52:47 +0000 (UTC) X-FDA: 80140655574.11.B78A8AC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id DBF7E180002 for ; Wed, 16 Nov 2022 21:52:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC59F61FDE; Wed, 16 Nov 2022 21:52:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05255C433C1; Wed, 16 Nov 2022 21:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1668635564; bh=8dvJnNwuAa3S+y6lRo95gwcV/t8NwVXZJ7UQcgtWCBM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pwF00oDVGtg0mJkc0c3N5ecIuAu/ewWQXQkSd9R7ACGITdssnHnX/JEKC53N+krYR TqNG74QtW3YEK6Ooe8Sr5y4NxtEtfZpmnq7S3NWuKHGNUKyWiLfTn5Vn7FoKGkJWWD RxQsej8VsIF60xfSidob4kQ/jGk2NW+jG1/Agesk= Date: Wed, 16 Nov 2022 13:52:43 -0800 From: Andrew Morton To: Jiaqi Yan Cc: kirill.shutemov@linux.intel.com, kirill@shutemov.name, tongtiangen@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com, linmiaohe@huawei.com, linux-mm@kvack.org, Oscar Salvador , Yang Shi Subject: Re: [PATCH v6 0/2] Memory poison recovery in khugepaged collapsing Message-Id: <20221116135243.b1db6b864efb89595d174be2@linux-foundation.org> In-Reply-To: References: <20221107025359.2911028-1-jiaqiyan@google.com> <20221107125315.b2916c557ff35d3b74aee503@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668635566; a=rsa-sha256; cv=none; b=xL7gYBIPVOJvDYgLVH/sH7JUzfxFurfBYgRkqffVXoXcAA/9jPeylYnU/VQZguqzz+OuFA u+oPTq45uxadkReaipwvCBQY10Ti6zjVnHrE9ysOmdh3xdfV0XKj1/W98q7PLtQemucLwt h6SGopQJoz2c5c/sC1wm5YjBxaxK6Bs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pwF00oDV; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668635566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FepiI/4iW20Kwje6q9avT5hsQfMrXNGzDZt19cT9RJk=; b=My8j898FTRhXg6Crq7XiqfydFn24MoHvcjH5yKwTvZsFbZ4bsag6IyNbGb21pPbJNIaBxi r337FdUP294sMx2QPD1iZj+7FBkJ8oyZobi5HuIXDxib5quEmLaEaYqtEoh/iRQ4hXfQM/ 5iPgBnwOgOziLecS43bpnu+LSqQn6H0= X-Rspamd-Queue-Id: DBF7E180002 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pwF00oDV; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3oq1njpd3u1em6cq3k9fpcajb4yd1drq X-HE-Tag: 1668635565-643781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Nov 2022 09:58:23 -0800 Jiaqi Yan wrote: > Thanks for ccing Oscar, Andrew. > > After getting this patch into our internal production environment, I > recently found a regression bug introduced by my commit a0157a2c735b > ("mm/khugepaged: recover from poisoned file-backed memory"). > Given it is only in mm-unstable, I wonder should I put out a v7 with > the fix, or should I make it a new and separate commit? Either approach is OK. I usually convert replacement patches into deltas so I and others can see what changed. But people like to see the whole patch for review purposes, so I guess that if you email out a new version of the patch, we get to see both.