From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F78C433FE for ; Wed, 16 Nov 2022 21:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66C7A8E0001; Wed, 16 Nov 2022 16:29:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61CF86B007D; Wed, 16 Nov 2022 16:29:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E4998E0001; Wed, 16 Nov 2022 16:29:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3FAD66B007B for ; Wed, 16 Nov 2022 16:29:26 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB87F140B03 for ; Wed, 16 Nov 2022 21:29:25 +0000 (UTC) X-FDA: 80140596690.08.987853B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id ECC564000C for ; Wed, 16 Nov 2022 21:29:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A8B3B81EC1; Wed, 16 Nov 2022 21:29:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA46EC433D7; Wed, 16 Nov 2022 21:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1668634161; bh=lF2wcsFNS3tp5cDZQlALyGmgyCpt9+zn/5uewQ381rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gvkp6VG+zsE18LF5h2kWGer8lEFezoWDkW9VU4cbY5sjM0O5/RZ8yjgyWwNiULyTK L6JnLcivyjuoIHoh3tVkenGuzrX76mR9ScZc/eWFCSJhlJmURdVIUdanF4qfYbHkAD B0BMUyY8kOZ25QZforCMb84HQIEz9adzNYPvojG0= Date: Wed, 16 Nov 2022 13:29:20 -0800 From: Andrew Morton To: Stefan Roesch Cc: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, clm@meta.com, willy@infradead.org, hch@infradead.org Subject: Re: [RFC PATCH v3 10/14] mm: add bdi_get_min_bytes() function. Message-Id: <20221116132920.312de0f71d6f21d46acc8aea@linux-foundation.org> In-Reply-To: <20221024190603.3987969-11-shr@devkernel.io> References: <20221024190603.3987969-1-shr@devkernel.io> <20221024190603.3987969-11-shr@devkernel.io> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668634164; a=rsa-sha256; cv=none; b=ohH505lfowgVwEiM7njFR4BGzSElHmfkL4GSC8eGjttVxBrvIiMkyriedmvuXOZFKidLpn CxAgZ6vlFtMoX1uSYWfqbghJX/vzba395vrqynojVjuDBUqhoBPa6OIk72L2KEYmhFgUqO oT5eUbdV+6FVwhdR0J9NL65zlbGZkH4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gvkp6VG+; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668634164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lh4NjPr+BW5QFbRLxpBssMcFrDMxuzQiJCiaE9gJ/sU=; b=lrc3zI+Up6AKPnTR4i1gINRzhylCW6TK32gT5F+BDzi5l00uEcMoVVl4NQ6u5/uMT+QaTm gjKWQVjEAIAldS+FqMj3ZrFV/b9NTAKjpGu953WWdaSRJpTkZgGOKcQE6EJ1pablMmeEN/ EfGV0PZhdot+WxSOytq/PpQBSiPWVfM= X-Rspam-User: X-Stat-Signature: xiudpcsze9mbfqdi1qieqnxcgdmybc4q X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: ECC564000C Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gvkp6VG+; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1668634163-40481 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Oct 2022 12:05:59 -0700 Stefan Roesch wrote: > This adds a function to return the specified value for min_bytes. It > converts the stored min_ratio of the bdi to the corresponding bytes > value. This is an approximation as it is based on the value that is > returned by global_dirty_limits(), which can change. The returned > value can be different than the value when the min_bytes value was set. > > ... > > --- a/include/linux/backing-dev.h > +++ b/include/linux/backing-dev.h > @@ -105,6 +105,7 @@ static inline unsigned long wb_stat_error(void) > /* BDI ratio is expressed as part per 1000 for finer granularity. */ > #define BDI_RATIO_SCALE 10 > > +unsigned long long bdi_get_min_bytes(struct backing_dev_info *bdi); u64? > +EXPORT_SYMBOL_GPL(bdi_get_min_bytes); Needed?