From: Andrew Morton <akpm@linux-foundation.org>
To: Stefan Roesch <shr@devkernel.io>
Cc: kernel-team@fb.com, linux-block@vger.kernel.org,
linux-mm@kvack.org, axboe@kernel.dk, clm@meta.com,
willy@infradead.org, hch@infradead.org
Subject: Re: [RFC PATCH v3 05/14] mm: add bdi_get_max_bytes() function
Date: Wed, 16 Nov 2022 13:29:04 -0800 [thread overview]
Message-ID: <20221116132904.516884bc7eec135cfcd326a7@linux-foundation.org> (raw)
In-Reply-To: <20221024190603.3987969-6-shr@devkernel.io>
On Mon, 24 Oct 2022 12:05:54 -0700 Stefan Roesch <shr@devkernel.io> wrote:
> This adds a function to return the specified value for max_bytes. It
> converts the stored max_ratio of the bdi to the corresponding bytes
> value. It introduces the bdi_get_bytes helper function to do the
> conversion. This is an approximation as it is based on the value that is
> returned by global_dirty_limits(), which can change. The helper function
> will also be used by the min_bytes bdi knob.
>
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -105,6 +105,7 @@ static inline unsigned long wb_stat_error(void)
> /* BDI ratio is expressed as part per 1000 for finer granularity. */
> #define BDI_RATIO_SCALE 10
>
> +unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi);
We don't use unsigned long long much. If you want a 64-bit unsigned,
use u64?
> +EXPORT_SYMBOL_GPL(bdi_get_max_bytes);
Is this symbol to be used by modules?
next prev parent reply other threads:[~2022-11-16 21:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 19:05 [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-11-16 21:28 ` Andrew Morton
2022-11-19 0:01 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 02/14] mm: add knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 03/14] mm: document /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 04/14] mm: use part per 1000 for bdi ratios Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:03 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton [this message]
2022-11-19 0:10 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:05 ` [RFC PATCH v3 07/14] mm: add bdi_set_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:14 ` Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:16 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 08/14] mm: add knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 09/14] mm: document /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 10/14] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:06 ` [RFC PATCH v3 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 13/14] mm: add /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 14/14] mm: document " Stefan Roesch
2022-11-11 17:30 ` [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116132904.516884bc7eec135cfcd326a7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=clm@meta.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shr@devkernel.io \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox