* [PATCH -next] migrate: stop using 0 as NULL pointer
@ 2022-11-16 1:23 Yang Li
2022-11-17 11:48 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-11-16 1:23 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Yang Li, Abaci Robot
mm/migrate.c:1198:24: warning: Using plain integer as NULL pointer
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3080
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 15dc56a3da7a..e50b3c42e6ad 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1195,7 +1195,7 @@ static int unmap_and_move(new_page_t get_new_page,
return -ENOMEM;
dst = page_folio(newpage);
- dst->private = 0;
+ dst->private = NULL;
rc = __unmap_and_move(src, dst, force, mode);
if (rc == MIGRATEPAGE_SUCCESS)
set_page_owner_migrate_reason(&dst->page, reason);
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] migrate: stop using 0 as NULL pointer
2022-11-16 1:23 [PATCH -next] migrate: stop using 0 as NULL pointer Yang Li
@ 2022-11-17 11:48 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-11-17 11:48 UTC (permalink / raw)
To: Yang Li, akpm; +Cc: linux-mm, linux-kernel, Abaci Robot
On 16.11.22 02:23, Yang Li wrote:
> mm/migrate.c:1198:24: warning: Using plain integer as NULL pointer
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3080
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> mm/migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 15dc56a3da7a..e50b3c42e6ad 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1195,7 +1195,7 @@ static int unmap_and_move(new_page_t get_new_page,
> return -ENOMEM;
> dst = page_folio(newpage);
>
> - dst->private = 0;
> + dst->private = NULL;
> rc = __unmap_and_move(src, dst, force, mode);
> if (rc == MIGRATEPAGE_SUCCESS)
> set_page_owner_migrate_reason(&dst->page, reason);
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-17 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 1:23 [PATCH -next] migrate: stop using 0 as NULL pointer Yang Li
2022-11-17 11:48 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox