From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E88C433FE for ; Tue, 15 Nov 2022 16:39:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C90B6B0072; Tue, 15 Nov 2022 11:39:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 152676B0073; Tue, 15 Nov 2022 11:39:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35296B0074; Tue, 15 Nov 2022 11:39:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DF7E66B0072 for ; Tue, 15 Nov 2022 11:39:28 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ADB21410C3 for ; Tue, 15 Nov 2022 16:39:28 +0000 (UTC) X-FDA: 80136237216.23.780607B Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf27.hostedemail.com (Postfix) with ESMTP id 24BF84000A for ; Tue, 15 Nov 2022 16:39:27 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id i71-20020a63874a000000b00476a4a5452eso2103407pge.22 for ; Tue, 15 Nov 2022 08:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=E2s20uKDciJYwI9RJnba40317vpgVeTYU3pK7INbcNU=; b=G7I1dCnqeVgYvsL3iWSgQL+FSKqM/Eizoix51yCZX9BrMYDSAfXXkdnOrWYVZCu+Lx cVIHMJi14CDQTCVvIEEDwxQ/7MgRHK/1b7y000fRtCrlZdCSAjBOzE/FGi8LRxdigk95 L86OV6hpZa3Nc+b09HtD+JjjrBU1JteofcRnWkN6hKBqXhZpGmUq0W6z6fY4arZL2OBR 22xYrVAB8tN8kTykent09MsO+K+RFK499fVYBrCfndDbnVrIc/Z6SQfSa2yjY35qQPZA NdqpMDJHYsAgryOwGl1D0qkiZjfE5V7DH3F1OKMETr78mSqYi2SS0nG53I2fyVuwk1BZ LRUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E2s20uKDciJYwI9RJnba40317vpgVeTYU3pK7INbcNU=; b=kLM1I9tp0c+llBdG+HrNCBtVHwBtGDrn+h6CD3LQo/ryCuxnpQIY0zw1Y61BY7oLaR jx8D4nSfXIKEEGu8e/dcmOBA5bfiDgMTqAn4969ExIuiDCf4iG8euF1Fqq/sxMoQQSPc /anLMueAWv5S/pX6G8pf7PRM1s9Cmj5ruqozgIdaLnrMkANJw/cmAFuePtxn9I9kM3o1 TjVRwecPRHREiCqMIHh3q5jt4/2jLnFzwBwMvSGupBegBV5DErK8TSAeuFU3nLRA5QcF bQIk5qYHbxvbu1+WdOzBCSxJBoRGmXJYp98C3CJqJ+F+YSf3hUM6I+MdLfhM0/ISCl/2 eSWQ== X-Gm-Message-State: ANoB5plCiudRwQbZIkrKWCLQLYgkfMVJu2yXZajDRJxP1fAU1N5ZcQWK U/4Pn37n3+ArtJmENjr6bu0Vido+f9NMIg== X-Google-Smtp-Source: AA0mqf4o1wCLL2yUpR2xVN1QdvZJzuuKqidH5E/PJ09J5CFqD9GqX1GO9tUvEOFAKPhUR5ZTzQOMH9AUebiJ+Q== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:aa7:8696:0:b0:571:ea17:e111 with SMTP id d22-20020aa78696000000b00571ea17e111mr13266492pfo.25.1668530366849; Tue, 15 Nov 2022 08:39:26 -0800 (PST) Date: Tue, 15 Nov 2022 16:39:24 +0000 In-Reply-To: <20221115123255.12559-1-jack@suse.cz> Mime-Version: 1.0 References: <20221115123255.12559-1-jack@suse.cz> Message-ID: <20221115163924.hchrkwpcl5gfgzaj@google.com> Subject: Re: [PATCH] mm: Make drop_caches keep reclaiming on all nodes From: Shakeel Butt To: Jan Kara Cc: Andrew Morton , linux-mm@kvack.org, Vladimir Davydov , You Zhou , Pengfei Xu Content-Type: text/plain; charset="us-ascii" ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G7I1dCnq; spf=pass (imf27.hostedemail.com: domain of 3vsBzYwgKCDEfUNXRRYOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3vsBzYwgKCDEfUNXRRYOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668530368; a=rsa-sha256; cv=none; b=1j1CkRNirpal4ULbLTOZtRO8OX+QQydSobjTQHSUgQNAVt/fRFMEBP1YbqMeQi8h6MQw0P 4aaevpAdn42F8RNq7ZIcQ8cbCLamak3NqgQtLg5PL6oHJHK0LLKedyjfkXiCnkdDudi65e CnbY7ci4IbZ9GbTarBOeIXyNa1gWthc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668530368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E2s20uKDciJYwI9RJnba40317vpgVeTYU3pK7INbcNU=; b=XSewKH1RSihMHbQwwHgjztTdvZdsrziD9QQ0G9QKWAw8+aKAQbXO9nA6NSPxGiHA5k74xG uOfGJXE9BuHVWGCvq3vKKmvBnQICTEmkxAbbt9zckr1keNqY5ExSnnh6yJGQ3+dOJfxzdB QZZjts/uTs+N+K36fz7wI8c/bdiAuqw= X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G7I1dCnq; spf=pass (imf27.hostedemail.com: domain of 3vsBzYwgKCDEfUNXRRYOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3vsBzYwgKCDEfUNXRRYOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 9tyctrhte9g7pdz9nke46bgrsyrcofrh X-Rspamd-Queue-Id: 24BF84000A X-Rspamd-Server: rspam09 X-HE-Tag: 1668530367-822238 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 01:32:55PM +0100, Jan Kara wrote: > Currently, drop_caches are reclaiming node-by-node, looping on each node > until reclaim could not make progress. This can however leave quite some > slab entries (such as filesystem inodes) unreclaimed if objects say on > node 1 keep objects on node 0 pinned. So move the "loop until no > progress" loop to the node-by-node iteration to retry reclaim also on > other nodes if reclaim on some nodes made progress. This fixes problem > when drop_caches was not reclaiming lots of otherwise perfectly fine to > reclaim inodes. > > Reported-by: You Zhou > Reported-and-tested-by: Pengfei Xu > Signed-off-by: Jan Kara Reviewed-by: Shakeel Butt