From: Shakeel Butt <shakeelb@google.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Vladimir Davydov <vdavydov.dev@gmail.com>,
You Zhou <you.zhou@intel.com>, Pengfei Xu <pengfei.xu@intel.com>
Subject: Re: [PATCH] mm: Make drop_caches keep reclaiming on all nodes
Date: Tue, 15 Nov 2022 16:39:24 +0000 [thread overview]
Message-ID: <20221115163924.hchrkwpcl5gfgzaj@google.com> (raw)
In-Reply-To: <20221115123255.12559-1-jack@suse.cz>
On Tue, Nov 15, 2022 at 01:32:55PM +0100, Jan Kara wrote:
> Currently, drop_caches are reclaiming node-by-node, looping on each node
> until reclaim could not make progress. This can however leave quite some
> slab entries (such as filesystem inodes) unreclaimed if objects say on
> node 1 keep objects on node 0 pinned. So move the "loop until no
> progress" loop to the node-by-node iteration to retry reclaim also on
> other nodes if reclaim on some nodes made progress. This fixes problem
> when drop_caches was not reclaiming lots of otherwise perfectly fine to
> reclaim inodes.
>
> Reported-by: You Zhou <you.zhou@intel.com>
> Reported-and-tested-by: Pengfei Xu <pengfei.xu@intel.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
prev parent reply other threads:[~2022-11-15 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 12:32 Jan Kara
2022-11-15 16:39 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115163924.hchrkwpcl5gfgzaj@google.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=pengfei.xu@intel.com \
--cc=vdavydov.dev@gmail.com \
--cc=you.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox