From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C17C433FE for ; Tue, 15 Nov 2022 00:41:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 289106B0072; Mon, 14 Nov 2022 19:41:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 239F58E0002; Mon, 14 Nov 2022 19:41:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 101468E0001; Mon, 14 Nov 2022 19:41:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 026B86B0072 for ; Mon, 14 Nov 2022 19:41:35 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B20B9120307 for ; Tue, 15 Nov 2022 00:41:34 +0000 (UTC) X-FDA: 80133823308.21.739D085 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 43AACC0006 for ; Tue, 15 Nov 2022 00:41:33 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E90F614E6; Tue, 15 Nov 2022 00:41:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C97EC433D7; Tue, 15 Nov 2022 00:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1668472891; bh=lAVWfOrc/rwWjzqaYTXRp+1KDrw37nDH3kkVtQ7yHEo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f66AIpfdCswCix6JxHdGCmi4C7k/cPTKbqbjTLjEkN0MGuHhK0ndDkX9w1PI/WlJv a1FbyuVKd7Dq+DdS1gmqtpiPHjPORZM2rp5JywZpD+5J55mg32JQKNCcGc3xgkwXY8 6BOkrX2OJgbgwfxbdo5KcN/of5Sh1uHHl0uXEUa4= Date: Mon, 14 Nov 2022 16:41:30 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Minchan Kim , Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, coverity-bot Subject: Re: [PATCH] zram: explicitly limit prio_max for static analyzers Message-Id: <20221114164130.e45a95db4e8be2c3909bdba1@linux-foundation.org> In-Reply-To: <20221114021420.4060601-1-senozhatsky@chromium.org> References: <20221109115047.2921851-5-senozhatsky@chromium.org> <20221114021420.4060601-1-senozhatsky@chromium.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668472893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cGjzZ1LCQk2xbvHHBMb2wVibWZMHCsWR44RlRIA08bM=; b=ymi1bOPFdoUDOJLo7aisZEVTu3GpmlSbL1k6ZxlmvRt0wEg/O9H41FxIBVpCPg/Dj7aVY6 WsJaoB/sKPJ8MbawidC7a6NBy/OuEGM04OVsDBWH+QkmHcxAfCASbgay02rA0nrAhRDKuK ewOEDgOmw6lcDw09h/E/V39c45/HgkQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=f66AIpfd; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668472893; a=rsa-sha256; cv=none; b=RzaMoJqqfGXTdCJ8F8RHZiJOEpLJABd/Oo9TiwwdaMTiml7+hnIU9bSPylyrkmz0qf7SNM UWaFSi30pHYs9G65Lave7nhEG5RxibeQIDXjD3inoB1zb77MToU0q/+FRNhjwnguQIvVf1 7miHJsC9rOjvEUUVs6d08PPOKjtNzBE= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 43AACC0006 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=f66AIpfd; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: exq1qc4xhiugcd84ox53mn8ogzee8xuj X-HE-Tag: 1668472893-410485 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 14 Nov 2022 11:14:20 +0900 Sergey Senozhatsky wrote: > Reported-by: coverity-bot > Signed-off-by: Sergey Senozhatsky > --- > drivers/block/zram/zram_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 9d33801e8ba8..e67a124f2e88 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1706,6 +1706,7 @@ static int zram_recompress(struct zram *zram, u32 index, struct page *page, > * Iterate the secondary comp algorithms list (in order of priority) > * and try to recompress the page. > */ > + prio_max = min(prio_max, ZRAM_MAX_COMPS); > for (; prio < prio_max; prio++) { > if (!zram->comps[prio]) > continue; I'll queue this as a fix to "zram: introduce recompress sysfs knob". What's it do? A little changelog would be nice, or at least a link to the coverity report?