From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60375C4332F for ; Mon, 14 Nov 2022 15:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F097B6B0072; Mon, 14 Nov 2022 10:52:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB8FE6B0073; Mon, 14 Nov 2022 10:52:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA7D56B0074; Mon, 14 Nov 2022 10:52:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA9E36B0072 for ; Mon, 14 Nov 2022 10:52:48 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6322A14080A for ; Mon, 14 Nov 2022 15:52:48 +0000 (UTC) X-FDA: 80132490816.24.A39A15A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id A2BB8180004 for ; Mon, 14 Nov 2022 15:52:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D544CB8107A; Mon, 14 Nov 2022 15:52:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B262FC433D6; Mon, 14 Nov 2022 15:52:43 +0000 (UTC) Date: Mon, 14 Nov 2022 10:53:25 -0500 From: Steven Rostedt To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH v2 1/7] mm: vmalloc: Add alloc_vmap_area trace event Message-ID: <20221114105325.57d27b6f@gandalf.local.home> In-Reply-To: <20221018181053.434508-2-urezki@gmail.com> References: <20221018181053.434508-1-urezki@gmail.com> <20221018181053.434508-2-urezki@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668441167; a=rsa-sha256; cv=none; b=VUYxKzZYj05se66lJUPUdiZIJ1dWMDW5FiNy1G6SEGqKn/PZF5bFkE4xmiBjmFt8CisM/y PbExFrFl+SQKJE+ffDEsY4CcY2kgBagPBppeUBpxEGFEte8qjOah4u3nXSIN5iRrxDns7/ 4WITCZM/R8CesJhtma+s7lr4GK7RuiY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of "SRS0=LXGb=3O=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=LXGb=3O=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668441167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVOR7qBxhs6sf99vNh3zOh0e89AGFOhT2BX9nBekS9U=; b=XW/BfEXpxvDuhshwK/mw7tLddxUWQdBpKWoIJP5hwFBLzhIUxhKNKo2xNvAzjcRFnbpffY rh1ALIuyWkISR59ETUiOUqe2AtVIlqadtVnRpGVNej45/SbbS8kecnqw0i/cTnFhyPdBjz 9TZIHNN+Fgb/x4Nft3VJk3b9QKlrhjI= X-Stat-Signature: kpgp3pqtdaeyxu1p6ddq5f8my3ixcbcx X-Rspamd-Queue-Id: A2BB8180004 Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of "SRS0=LXGb=3O=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=LXGb=3O=goodmis.org=rostedt@kernel.org"; dmarc=none X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668441167-588607 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Oct 2022 20:10:47 +0200 "Uladzislau Rezki (Sony)" wrote: > It is for a debug purpose and for validation of passed parameters. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > include/trace/events/vmalloc.h | 56 ++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 include/trace/events/vmalloc.h > > diff --git a/include/trace/events/vmalloc.h b/include/trace/events/vmalloc.h > new file mode 100644 > index 000000000000..39fbd77c91e7 > --- /dev/null > +++ b/include/trace/events/vmalloc.h > @@ -0,0 +1,56 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM vmalloc > + > +#if !defined(_TRACE_VMALLOC_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_VMALLOC_H > + > +#include > + > +/** > + * alloc_vmap_area - called when a new vmap allocation occurs > + * @addr: an allocated address > + * @size: a requested size > + * @align: a requested alignment > + * @vstart: a requested start range > + * @vend: a requested end range > + * @failed: an allocation failed or not > + * > + * This event is used for a debug purpose, it can give an extra > + * information for a developer about how often it occurs and which > + * parameters are passed for further validation. > + */ > +TRACE_EVENT(alloc_vmap_area, > + > + TP_PROTO(unsigned long addr, unsigned long size, unsigned long align, > + unsigned long vstart, unsigned long vend, int failed), > + > + TP_ARGS(addr, size, align, vstart, vend, failed), The above is passed in via (from patch 4): @@ -1621,6 +1624,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, size, align, vstart, vend); spin_unlock(&free_vmap_area_lock); + trace_alloc_vmap_area(addr, size, align, vstart, vend, addr == vend); + /* * If an allocation fails, the "vend" address is * returned. Therefore trigger the overflow path. > + > + TP_STRUCT__entry( > + __field(unsigned long, addr) > + __field(unsigned long, size) > + __field(unsigned long, align) > + __field(unsigned long, vstart) > + __field(unsigned long, vend) > + __field(int, failed) I would drop the failed field... > + ), > + > + TP_fast_assign( > + __entry->addr = addr; > + __entry->size = size; > + __entry->align = align; > + __entry->vstart = vstart; > + __entry->vend = vend; And instead have: __entry->failed = addr == vend; Why pass in a parameter that can be calculated in the trace event logic? Other than that, from a tracing perspective: Reviewed-by: Steven Rostedt (Google) for the series. -- Steve > + __entry->failed = failed; > + ), > + > + TP_printk("va_start: %lu size=%lu align=%lu vstart=0x%lx vend=0x%lx failed=%d", > + __entry->addr, __entry->size, __entry->align, > + __entry->vstart, __entry->vend, __entry->failed) > +); > + > +#endif /* _TRACE_VMALLOC_H */ > + > +/* This part must be outside protection */ > +#include