From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9389C433FE for ; Mon, 14 Nov 2022 10:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59C986B0072; Mon, 14 Nov 2022 05:52:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54C336B0073; Mon, 14 Nov 2022 05:52:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EC3E6B0074; Mon, 14 Nov 2022 05:52:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2BCA76B0072 for ; Mon, 14 Nov 2022 05:52:16 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DE374160727 for ; Mon, 14 Nov 2022 10:52:15 +0000 (UTC) X-FDA: 80131733430.23.7A85E23 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf21.hostedemail.com (Postfix) with ESMTP id 4BBBB1C0005 for ; Mon, 14 Nov 2022 10:52:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2EDFD1FE6D; Mon, 14 Nov 2022 10:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668423134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=clcJq84x09/0lcWlLPOIuK2xM1hHOs9iOojMYOjosj8=; b=lQu2Pjy3pcp9uwaKFc3jgFAkHtcCek0sMnlUAE6BmF19YIti5i9HZ/q7Nk10ciS9BlKNeN FEU74NgEx7LkiqMQJKzQMvpI9eKeD8eRtQGzkDBgiysrujSGACB7sdURignxiBCVcTV4aW 9GVrMofKVCVgS53i4KFkqjdnrD/gQ3Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668423134; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=clcJq84x09/0lcWlLPOIuK2xM1hHOs9iOojMYOjosj8=; b=r4V7upTQYSfV/3yRbELgnAsYzoLI4t9YZUR2mEvVSkpz2isJwNzAuGEbJHWIJKKfSWt4OX 9Z6E2DqrJ96wkmBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F7F713A8C; Mon, 14 Nov 2022 10:52:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SPauB94dcmNDaAAAMHmgww (envelope-from ); Mon, 14 Nov 2022 10:52:14 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 76E40A0709; Mon, 14 Nov 2022 11:52:13 +0100 (CET) Date: Mon, 14 Nov 2022 11:52:13 +0100 From: Jan Kara To: Christoph Hellwig Cc: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 9/9] udf: remove ->writepage Message-ID: <20221114105213.v5gby6zngz6y6med@quack3> References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113162902.883850-10-hch@lst.de> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668423135; a=rsa-sha256; cv=none; b=62FktG0VrGnWHeocnHN5yEWah8VSSDtzqAO5uH5GvsBP6XYtH/cyQcvY63GIjdGFRiGvVu AAlCHMm7k9MLmswUE52zFK0mKovisMD4+c1ykW2TyL/mV+SbKsVT4CoG9IDc7EizSCa97w w9YNAvm1r2lnUUH1WjqqW9Dzo5RfN9I= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lQu2Pjy3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r4V7upTQ; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668423135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=clcJq84x09/0lcWlLPOIuK2xM1hHOs9iOojMYOjosj8=; b=ZtC1uigjMGawBKukT1rJvXKmLh0lanKzWZa3YYsY7lqrFUCe850fU1CuAnmAXGKliklakx 7WCcII+n70PIYe3nia+bowiO7a0IMkjoawOhS0BCmc6F/0BfImoob64akw6z5ILq6tQXHh s5bNdaNngOyHWX1v/Ooxfz5EwaS7ZOk= X-Rspam-User: X-Stat-Signature: 3ctacpj59ku5idj7mygdgn845yrucn7n X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4BBBB1C0005 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lQu2Pjy3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r4V7upTQ; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-HE-Tag: 1668423135-779384 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 13-11-22 17:29:02, Christoph Hellwig wrote: > ->writepage is a very inefficient method to write back data, and only > used through write_cache_pages or a a fallback when no ->migrate_folio > method is present. > > Set ->migrate_folio to the generic buffer_head based helper, and remove > the ->writepage implementation in extfat. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Acked-by: Jan Kara Honza > --- > fs/udf/inode.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/udf/inode.c b/fs/udf/inode.c > index dce6ae9ae306c..0246b1b86fb91 100644 > --- a/fs/udf/inode.c > +++ b/fs/udf/inode.c > @@ -182,11 +182,6 @@ static void udf_write_failed(struct address_space *mapping, loff_t to) > } > } > > -static int udf_writepage(struct page *page, struct writeback_control *wbc) > -{ > - return block_write_full_page(page, udf_get_block, wbc); > -} > - > static int udf_writepages(struct address_space *mapping, > struct writeback_control *wbc) > { > @@ -239,12 +234,12 @@ const struct address_space_operations udf_aops = { > .invalidate_folio = block_invalidate_folio, > .read_folio = udf_read_folio, > .readahead = udf_readahead, > - .writepage = udf_writepage, > .writepages = udf_writepages, > .write_begin = udf_write_begin, > .write_end = generic_write_end, > .direct_IO = udf_direct_IO, > .bmap = udf_bmap, > + .migrate_folio = buffer_migrate_folio, > }; > > /* > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR