From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 929A2C43217 for ; Mon, 14 Nov 2022 10:49:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D1386B0072; Mon, 14 Nov 2022 05:49:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 882586B0074; Mon, 14 Nov 2022 05:49:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 779E76B0072; Mon, 14 Nov 2022 05:49:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6ADA66B0072 for ; Mon, 14 Nov 2022 05:49:31 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 33D5EAB24C for ; Mon, 14 Nov 2022 10:49:31 +0000 (UTC) X-FDA: 80131726542.23.4866C47 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf22.hostedemail.com (Postfix) with ESMTP id 81952C000B for ; Mon, 14 Nov 2022 10:49:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E16871FE67; Mon, 14 Nov 2022 10:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668422967; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ubo9RUeILLOZCFhRqSz41sUmP7donszofRssChRT+mk=; b=FCJdYm9kzAhz4vYOrsAtx1I3ezNTwuYj9tisurbURs8GMQMuDY7MNqoKTq9Jo2s46wmDM4 KLXrTSl6G1mjhcXykUIOgXNTJL65jcU/3xY8IYjqW7Cb2ICxqU9GCpKor69sgQtUVpUD1D pbWbo6t4OX6sRFdseSr8R25qMN9mhpg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668422967; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ubo9RUeILLOZCFhRqSz41sUmP7donszofRssChRT+mk=; b=927zvK6sEulfOA+/7LmlwmEuhq43kTGhclLO5y7m/oMptFQXPkIWgf9Yn+PvAO20O14a4E 315hsx4OV89dt4Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D284013A8C; Mon, 14 Nov 2022 10:49:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id o0VfMzcdcmOqZgAAMHmgww (envelope-from ); Mon, 14 Nov 2022 10:49:27 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 65ECAA0709; Mon, 14 Nov 2022 11:49:27 +0100 (CET) Date: Mon, 14 Nov 2022 11:49:27 +0100 From: Jan Kara To: Christoph Hellwig Cc: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 2/9] ext2: remove ->writepage Message-ID: <20221114104927.k5x4i4uanxskfs6m@quack3> References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113162902.883850-3-hch@lst.de> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668422969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ubo9RUeILLOZCFhRqSz41sUmP7donszofRssChRT+mk=; b=Xk33bUXysWc0rpYSeJVzmkx9zamu0GZkzKZL1QTC08TjPFAiu1tit5yt5sKpY4uI+/ALML 9m8IJIeHY1XRJ0felaxgJaSYpS2m+dCX1Y+tv/EM0s87M4JmcLMIwgXS8Yd67ZT6sWlAIk nqHlTctfBsmuoHRUZSS8g/f994wQFy4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FCJdYm9k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=927zvK6s; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668422969; a=rsa-sha256; cv=none; b=tlMF2/j639ymaJQY9PPAIpPY9YIgs2OpnwwRcSGsXgxFvOnDGmvGu+ghZKrUjZBYav4bTN uege9IdYc7GzoSaIRITWkogt8zMLQP6j0M/FzuuHRY7kH50NbJlW2/Z7B4ns3bdfdJQ1Hk WVrZ5zzxsvsFZjBOeY0eMnDukxP4WiA= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 81952C000B X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FCJdYm9k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=927zvK6s; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz X-Stat-Signature: tfg9jc1krsnnckhoa3jwt3ixh3nbhcaw X-HE-Tag: 1668422969-77813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 13-11-22 17:28:55, Christoph Hellwig wrote: > ->writepage is a very inefficient method to write back data, and only > used through write_cache_pages or a a fallback when no ->migrate_folio > method is present. > > Signed-off-by: Christoph Hellwig Looks good! Feel free to add: Acked-by: Jan Kara Honza > --- > fs/ext2/inode.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index 918ab2f9e4c05..3b2e3e1e0fa25 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c > @@ -869,11 +869,6 @@ int ext2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > return ret; > } > > -static int ext2_writepage(struct page *page, struct writeback_control *wbc) > -{ > - return block_write_full_page(page, ext2_get_block, wbc); > -} > - > static int ext2_read_folio(struct file *file, struct folio *folio) > { > return mpage_read_folio(folio, ext2_get_block); > @@ -948,7 +943,6 @@ const struct address_space_operations ext2_aops = { > .invalidate_folio = block_invalidate_folio, > .read_folio = ext2_read_folio, > .readahead = ext2_readahead, > - .writepage = ext2_writepage, > .write_begin = ext2_write_begin, > .write_end = ext2_write_end, > .bmap = ext2_bmap, > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR