From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E8ABC433FE for ; Sun, 13 Nov 2022 19:49:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E7966B0071; Sun, 13 Nov 2022 14:49:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 498008E0001; Sun, 13 Nov 2022 14:49:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35F6C6B0073; Sun, 13 Nov 2022 14:49:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 27EFB6B0071 for ; Sun, 13 Nov 2022 14:49:14 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E384A1604F7 for ; Sun, 13 Nov 2022 19:49:13 +0000 (UTC) X-FDA: 80129457786.15.7B54186 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 6D054C0007 for ; Sun, 13 Nov 2022 19:49:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8975B80C81; Sun, 13 Nov 2022 19:49:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1EB9C433D6; Sun, 13 Nov 2022 19:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668368950; bh=yrDG2V+vcg1HVPtwi+FlRMwsR7nnH8N/b1BGzR2HGdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bD3ZVJ9Sj+CuNd4SnlcFNNuixJYu6WW+7JkqTQFPrUFKEpqxUYVmJvr7ec9zEVuZn QwTz/5HPpVvh79OKiBBxouHYwGI5wp1UPi0RpBCDtArino48OnjQgqutLOEJymzIKQ XV17gaAddwx6fhFlXKnMuLk1UfRJLLSZ60Qk4Iz7sU1ey9DeD7TPRPKc/ZEsYhcv43 gpKCz/Sx6yIgh1nfMFfwLr0Z4SwEtJlw2NC2klgYhsDlK77ILRKQWQ7V7fOyizf7oX 5PTq+vWll8oU1s4dC4iDbwtS6DGxDfG2Ef2mUaskL68eI7NTX7pcoGNSOKPA85tkzR sYeVSKszBlDlQ== From: SeongJae Park To: Rong Tao Cc: sj@kernel.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, rongtao@cestc.cn, shuah@kernel.org, yuanchu@google.com Subject: Re: [PATCH v3] selftests/damon: Fix unnecessary compilation warnings Date: Sun, 13 Nov 2022 19:49:07 +0000 Message-Id: <20221113194908.18554-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668368953; a=rsa-sha256; cv=none; b=7z4yKCUMV/LPhmtgTg0DV0uMJq+Uvl8BgnWTC8zc6ySMzor6yvaJuJUkMbMaioU0H8gn/G 0QS4iKFECJtI5pi8oSL4smuTsZ2vFqvEXVVPX1WjH92KQhRG6/B3l5Szo/SexbEmrkl4OC ISQjx887Zkub++cw+pSCj0079dqWquc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bD3ZVJ9S; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668368953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KGieuhHuDykTu5djDxIhsF/r8Ylssidn9aLWIWiRbXo=; b=ZGyGPyRHGtC7SDVuVPR/HclsJHCGw3LyjY1L8FTFNx6M69w4Tm0aRQbjVBXKxk57zoAs5A Z7ci0gcBjAo1gYvhNrgmf2HnU7Opf2LA6otnAkK2TBAuvrOKzsOMVekZDucT5gVg6BE//u XRTXlUL5wN3kVVm5UdgtorwssVw1bVU= X-Stat-Signature: idb5mhcakgj84ded9wg1uuue6p5tc9aj Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bD3ZVJ9S; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam10 X-Rspam-User: X-Rspamd-Queue-Id: 6D054C0007 X-HE-Tag: 1668368953-680389 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 13 Nov 2022 08:38:45 +0800 Rong Tao wrote: > From: Rong Tao > > When testing overflow and overread, there is no need to keep unnecessary > compilation warnings, we should simply ignore them. > > The motivation for this patch is to eliminate the compilation warning, > maybe one day we will compile the kernel with "-Werror -Wall", at which > point this compilation warning will turn into a compilation error, we > should fix this error in advance. > > How to reproduce the problem (with gcc-11.3.1): > > $ make -C tools/testing/selftests/ > ... > warning: ‘write’ reading 4294967295 bytes from a region of size 1 > [-Wstringop-overread] > warning: ‘read’ writing 4294967295 bytes into a region of size 25 > overflows the destination [-Wstringop-overflow=] > > "-Wno-stringop-overread" is supported at least in gcc-11.1.0. > > Link: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d14c547abd484d3540b692bb8048c4a6efe92c8b > Signed-off-by: Rong Tao Reviewed-by: SeongJae Park Thank you for fixing this old problem! Thanks, SJ > --- > tools/testing/selftests/damon/huge_count_read_write.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/testing/selftests/damon/huge_count_read_write.c b/tools/testing/selftests/damon/huge_count_read_write.c > index ad7a6b4cf338..a6fe0689f88d 100644 > --- a/tools/testing/selftests/damon/huge_count_read_write.c > +++ b/tools/testing/selftests/damon/huge_count_read_write.c > @@ -8,6 +8,13 @@ > #include > #include > > +#pragma GCC diagnostic push > +#if __GNUC__ >= 11 && __GNUC_MINOR__ >= 1 > +/* Ignore read(2) overflow and write(2) overread compile warnings */ > +#pragma GCC diagnostic ignored "-Wstringop-overread" > +#pragma GCC diagnostic ignored "-Wstringop-overflow" > +#endif > + > void write_read_with_huge_count(char *file) > { > int filedesc = open(file, O_RDWR); > @@ -27,6 +34,8 @@ void write_read_with_huge_count(char *file) > close(filedesc); > } > > +#pragma GCC diagnostic pop > + > int main(int argc, char *argv[]) > { > if (argc != 2) { > -- > 2.31.1 > >