From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7631C43217 for ; Sun, 13 Nov 2022 16:29:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F6C28000A; Sun, 13 Nov 2022 11:29:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A69C8E0001; Sun, 13 Nov 2022 11:29:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BCF28000A; Sun, 13 Nov 2022 11:29:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E5388E0001 for ; Sun, 13 Nov 2022 11:29:44 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F0E9F1A0865 for ; Sun, 13 Nov 2022 16:29:43 +0000 (UTC) X-FDA: 80128955046.27.F57277A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id A3E068000A for ; Sun, 13 Nov 2022 16:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=w51Gvl8Pnmlo1SbhqS+2F9D21dBv4WKLApDvNFY66GQ=; b=12jZrKibqe1Nhuji9ZkFAX7X7U zZRaAN35VMESX41fHQaIN3Y8uy3rvUKp558Q1qTZy7IH6vjy/+JY1DG/SyqYz0x7Vb/uNvgwuO58f CvLCcoK8mV/d7Iaqx80ikp/fP+MZy5kDdVxF3CQ3y5IXhBeY05lW4tc3Bg6CaHRfR2F5y5YJBeWwB wuYNoNFXOP2q3Vg6lbNRCrmU+s50dJFkLl6DHMkzRi/4sMhcDsupdlw/VCMKtF6w0vEbDsbfJ+QAc mK0uM1NdinJqK8frxy1ZOfQgGsg5ywHowa4wlWgn7MO53yUPZnSbKo/HQef/TmbMWXA3HCQX3kyrk CV+B6PAQ==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrU-00CJz6-4l; Sun, 13 Nov 2022 16:29:37 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 7/9] jfs: remove ->writepage Date: Sun, 13 Nov 2022 17:29:00 +0100 Message-Id: <20221113162902.883850-8-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w51Gvl8Pnmlo1SbhqS+2F9D21dBv4WKLApDvNFY66GQ=; b=FLR0roVevSkZaGm7Bw0pI9++b/XwE0cQ8pfDeuajeg3YbLz4BMSVQNXVzQijteJ/EiPmSx XhC/QdOXz8l4AWq+flaRcaOYmYL3G3Clu55HBuAxVHB6Lf2Gmj0qQnXrDkxYdI5xyobhAB SQmQzjSz25Xz//lVexC4hC5zAkiYMc8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=12jZrKib; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356983; a=rsa-sha256; cv=none; b=YSeVGFL/SGa9cZloxDM3WMz5AwonlzGL7EPbYP0cOSkQz7dhTT834Ic8ZXR2fH6MMHIb2B hOj4G5gawAnVa8i2col6GibSdsS0J8Ej+5g0zqnZyThD+zip3fY7uHsQf2GKycmYVObIsd YWGXi+18SrAilVs+LKRR/iFPzo/Bl3w= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A3E068000A X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=12jZrKib; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: 1wd8mdee6tx7x787bc5mwkrgufqddi3w X-HE-Tag: 1668356983-490179 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig --- fs/jfs/inode.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index d1ec920aa030a..8ac10e3960508 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c @@ -264,11 +264,6 @@ int jfs_get_block(struct inode *ip, sector_t lblock, return rc; } -static int jfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, jfs_get_block, wbc); -} - static int jfs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -355,12 +350,12 @@ const struct address_space_operations jfs_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = jfs_read_folio, .readahead = jfs_readahead, - .writepage = jfs_writepage, .writepages = jfs_writepages, .write_begin = jfs_write_begin, .write_end = jfs_write_end, .bmap = jfs_bmap, .direct_IO = jfs_direct_IO, + .migrate_folio = buffer_migrate_folio, }; /* -- 2.30.2