linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <linkinjeon@kernel.org>,
	Sungjong Seo <sj1557.seo@samsung.com>, Jan Kara <jack@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
	Dave Kleikamp <shaggy@kernel.org>,
	Bob Copeland <me@bobcopeland.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	jfs-discussion@lists.sourceforge.net,
	linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: [PATCH 6/9] hpfs: remove ->writepage
Date: Sun, 13 Nov 2022 17:28:59 +0100	[thread overview]
Message-ID: <20221113162902.883850-7-hch@lst.de> (raw)
In-Reply-To: <20221113162902.883850-1-hch@lst.de>

->writepage is a very inefficient method to write back data, and only
used through write_cache_pages or a a fallback when no ->migrate_folio
method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove
the ->writepage implementation.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/hpfs/file.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/hpfs/file.c b/fs/hpfs/file.c
index f7547a62c81f6..88952d4a631e6 100644
--- a/fs/hpfs/file.c
+++ b/fs/hpfs/file.c
@@ -163,11 +163,6 @@ static int hpfs_read_folio(struct file *file, struct folio *folio)
 	return mpage_read_folio(folio, hpfs_get_block);
 }
 
-static int hpfs_writepage(struct page *page, struct writeback_control *wbc)
-{
-	return block_write_full_page(page, hpfs_get_block, wbc);
-}
-
 static void hpfs_readahead(struct readahead_control *rac)
 {
 	mpage_readahead(rac, hpfs_get_block);
@@ -248,12 +243,12 @@ const struct address_space_operations hpfs_aops = {
 	.dirty_folio	= block_dirty_folio,
 	.invalidate_folio = block_invalidate_folio,
 	.read_folio = hpfs_read_folio,
-	.writepage = hpfs_writepage,
 	.readahead = hpfs_readahead,
 	.writepages = hpfs_writepages,
 	.write_begin = hpfs_write_begin,
 	.write_end = hpfs_write_end,
-	.bmap = _hpfs_bmap
+	.bmap = _hpfs_bmap,
+	.migrate_folio = buffer_migrate_folio,
 };
 
 const struct file_operations hpfs_file_ops =
-- 
2.30.2



  parent reply	other threads:[~2022-11-13 16:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 16:28 start removing writepage instances Christoph Hellwig
2022-11-13 16:28 ` [PATCH 1/9] extfat: remove ->writepage Christoph Hellwig
2022-11-14 11:07   ` Namjae Jeon
2022-11-13 16:28 ` [PATCH 2/9] ext2: " Christoph Hellwig
2022-11-14 10:49   ` Jan Kara
2022-11-16 16:14     ` Christoph Hellwig
2022-11-16 18:20       ` [PATCH 2/9] ext2: remove ->writepageo Jan Kara
2022-11-17  6:31         ` Christoph Hellwig
2022-11-21 10:07           ` Jan Kara
2022-11-13 16:28 ` [PATCH 3/9] fat: remove ->writepage Christoph Hellwig
2022-11-13 16:28 ` [PATCH 4/9] hfs: " Christoph Hellwig
2023-12-14 19:01   ` Matthew Wilcox
2023-12-15  4:59     ` Christoph Hellwig
2022-11-13 16:28 ` [PATCH 5/9] hfsplus: " Christoph Hellwig
2022-11-13 16:28 ` Christoph Hellwig [this message]
2022-11-13 16:29 ` [PATCH 7/9] jfs: " Christoph Hellwig
2022-11-14 14:29   ` Dave Kleikamp
2022-11-13 16:29 ` [PATCH 8/9] omfs: " Christoph Hellwig
2022-11-15  2:34   ` Bob Copeland
2022-11-13 16:29 ` [PATCH 9/9] udf: " Christoph Hellwig
2022-11-14 10:52   ` Jan Kara
2022-11-14 20:29 ` start removing writepage instances Johannes Weiner
2022-11-16 18:39 ` Ritesh Harjani (IBM)
2022-12-02 10:22   ` Christoph Hellwig
2022-11-17 21:39 ` David Howells
2022-11-17 21:41 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221113162902.883850-7-hch@lst.de \
    --to=hch@lst.de \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linkinjeon@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-karma-devel@lists.sourceforge.net \
    --cc=linux-mm@kvack.org \
    --cc=me@bobcopeland.com \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=shaggy@kernel.org \
    --cc=sj1557.seo@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox