From: Kees Cook <keescook@chromium.org>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dalias@libc.org, ebiederm@xmission.com, sam@gentoo.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v3] fs/binfmt_elf: Fix memsz > filesz handling
Date: Thu, 10 Nov 2022 19:38:44 -0800 [thread overview]
Message-ID: <202211101934.22CACD615@keescook> (raw)
In-Reply-To: <20221108110715.227062-1-pedro.falcato@gmail.com>
On Tue, Nov 08, 2022 at 11:07:15AM +0000, Pedro Falcato wrote:
> [...]
> + * This tail logic is skippable if we're the last phdr, as
> + * nothing can map an address >= our p_vaddr, since ELF phdr
> + * PT_LOAD segments are required to be sorted in an increasing
> + * order.
I'm still looking through the patch, but I do want to call this bit out
as a problem. The kernel cannot, unfortunately, make this assumption. See:
https://lore.kernel.org/linux-fsdevel/YfOooXQ2ScpZLhmD@fractal.localdomain/
"It turns out that almost all native Linux games published by the Virtual
Programming company have this kind of weird PT_LOAD ordering including
the famous Bioshock Infinite ... Someone should probably ask Virtual
Programming, what kind of tooling they use to create such convoluted
ELF binaries."
So, even though it's in violation of the spec, these binaries exist in
the real world, and we cannot break them. :(
--
Kees Cook
next prev parent reply other threads:[~2022-11-11 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:07 Pedro Falcato
2022-11-11 3:38 ` Kees Cook [this message]
2022-11-11 3:59 ` Pedro Falcato
2022-11-11 6:15 ` Kees Cook
2022-11-11 17:14 ` Pedro Falcato
2022-11-11 18:43 ` Kees Cook
2022-11-11 16:32 ` kernel test robot
2022-11-11 18:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211101934.22CACD615@keescook \
--to=keescook@chromium.org \
--cc=dalias@libc.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pedro.falcato@gmail.com \
--cc=sam@gentoo.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox