From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B72AC4332F for ; Thu, 10 Nov 2022 17:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CCF68E0001; Thu, 10 Nov 2022 12:18:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57BEF6B0075; Thu, 10 Nov 2022 12:18:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 443A58E0001; Thu, 10 Nov 2022 12:18:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3092B6B0074 for ; Thu, 10 Nov 2022 12:18:35 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D3A5C1A0C22 for ; Thu, 10 Nov 2022 17:18:34 +0000 (UTC) X-FDA: 80118191748.16.4E1448B Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 52CF314000D for ; Thu, 10 Nov 2022 17:18:34 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id o7so2103996pjj.1 for ; Thu, 10 Nov 2022 09:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6+p59de6PsfQhghSr17SHi1vccXQnsphuAQf+FEG0HQ=; b=Je1AWEgls8fX5fRsqqjYq3EJyLyKV7MZf9N1T/aVClFk3POIrv7COzBf4FD4SvUbaP LgJaDOWNYXSDnktSJmsWkSVj6P7JqWVj7LF2N+1U14bXHgd3p+dvL13CNSdD893hgjKD KQ+2SoOBhw6bBhFDkRa0HfyH5zVpnvKnr4EztAJZlVvTCUM54LG/KK+sZVgaXBj2wDY7 hFU6/DI/xCNfQGkvqJXN6leNlFpiQFhrZCTkMjHP27GLQ/eNIBn/FlcFC0msGuxVAv2r 1+4J+/xM3iuc4acHtoFrpL+P+y3rKIRpP8/05PVHb79EJCpBdlkVnF7qNHg9yso/U3Ll DFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6+p59de6PsfQhghSr17SHi1vccXQnsphuAQf+FEG0HQ=; b=oIBIOS10IBw3xwY8QGh/tafC93McBEjDTInVBGXYIVgZBce6nDQKKmIclDpfS/ehtA eMXQv3eMy/MmOxkJZIy6Y7ndUgEiRguZEY5m22TXcRtIptlzGEChhprWcApkLyNonr4S LXdi0hvjORcaoM/VnUz+132XDSeoKDe27Q6BYPezO2NHQAIlxxRdFc9RZjY8w/EzFYoy eHrTrC9idIaQRHe/pdJ9Ul7zkmCQvuehBRSW32yXogbUm7L8wzF/Qr15rsQ2VlZdeMfw eK2RcNEq+XHlUbObyIVf2NgNQyJfxAYpCPOhNQfre2VWlxEUI8GVa3bBO4bTMuuOH9Al U+jg== X-Gm-Message-State: ACrzQf1JJzPjpC0APaFPdfsEZZnzAv5Ak5D+hAqRMCbQYXRvduX7/MGY oQJdV0v3h1LQhmE8vf7R6XI= X-Google-Smtp-Source: AMsMyM6ymq/lxyuKszNR0m9UH9h7DZ+Sebq+bjrStgM3F+5tXEmSshH7ePAkNpgR5kzXnE0dJWyDVw== X-Received: by 2002:a17:902:e74a:b0:187:2039:5754 with SMTP id p10-20020a170902e74a00b0018720395754mr57814067plf.103.1668100713125; Thu, 10 Nov 2022 09:18:33 -0800 (PST) Received: from localhost (fwdproxy-prn-021.fbsv.net. [2a03:2880:ff:15::face:b00c]) by smtp.gmail.com with ESMTPSA id z22-20020a630a56000000b0043c732e1536sm9427574pgk.45.2022.11.10.09.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 09:18:32 -0800 (PST) From: Nhat Pham To: minchan@kernel.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Date: Thu, 10 Nov 2022 09:18:31 -0800 Message-Id: <20221110171831.19176-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668100714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6+p59de6PsfQhghSr17SHi1vccXQnsphuAQf+FEG0HQ=; b=p5sQb7nEAW+0zVUy/BTe70EekD5wy65Psb7upAPPAx9Ii/XgeGyRVxiBhR2SO2Rr6Cw2E3 PYrRz8c0M7IiCpdxCdoJNUG95IckstITr78zcOHp3fC9BbsQaFAn3SUEfgpIEgxp1Ol2Pw rA5VlZWqgrQkCq+GHjUOkdJLpW8KID0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Je1AWEgl; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668100714; a=rsa-sha256; cv=none; b=XeRkJP3Nm5v955gG6qTx12wfcnWRqg4zpMZkpabZpGTpiXcDDw7mQMBG2iKOg+lOsy5j8w b0twl1yHy9wa4V60c7cneS68larjTYrCpW0cAN+QzEL7KE8D939dzCAilrzUg7huBnNJiC sdgw6TAAcfKXLlCm6Hs+D8HYJJLGjIw= X-Rspamd-Queue-Id: 52CF314000D X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Je1AWEgl; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: dfbtkit43xx4xhtg3aieyutcqwfy5igd X-HE-Tag: 1668100714-282051 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000050, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Please put the LRU logic under config ZSMALLOC_LRU since we don't need the > additional logic to others. I think the existing CONFIG_ZPOOL would be a good option for this purpose. It should disable the LRU behavior for non-zswap use case (zram for e.g). The eviction logic is also currently defined under this. What do you think, Minchan?