From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D9DC4332F for ; Thu, 10 Nov 2022 03:08:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F6E38E0001; Wed, 9 Nov 2022 22:08:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6BE6B0075; Wed, 9 Nov 2022 22:08:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BD5B8E0001; Wed, 9 Nov 2022 22:08:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7DA826B0074 for ; Wed, 9 Nov 2022 22:08:02 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4F093C07F9 for ; Thu, 10 Nov 2022 03:08:02 +0000 (UTC) X-FDA: 80116048404.14.25C3E59 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf19.hostedemail.com (Postfix) with ESMTP id E531C1A0005 for ; Thu, 10 Nov 2022 03:08:01 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so4666700pjh.1 for ; Wed, 09 Nov 2022 19:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y6OU4ENNozkhINhc2+IJdoCoJp+Y8ceNlE8roxKPBjE=; b=oaJmLTjfJVaa50Gd8bDUYhN/nxHUbBZEnP+s0IbUrmsk5dtTaf/iqkrlaswYcgxT/l /Ssntrn5Fqaaj1VCXld7535lk2/u7QmvZPTBGHljv/7Nj96/3Qa8p+T4Ta9cX5gOZX+v 1nj3qCWZE4K+fhQ3z1pAd2QJfJtx3kc54c7wnzQpQOOa1X7QnUnrZUvtIulF9RvGWIDz wy7EVVA0A9GUcWoiwptyhBcT2xQJ6vLWh1GY3MXfhjHKySMpXNvH9W1C0XdNIjFff4fC Es5/daXC9Ysst7KAWH+b0HLY86EBUeUtYQGxLmyUlsQAyyYALoTwSe+zWYCWsYgk6ngq Nspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y6OU4ENNozkhINhc2+IJdoCoJp+Y8ceNlE8roxKPBjE=; b=C/2ldY1bGvXrF3LW7x3k2UTD7S21zJk5I3MySYNXvKYwkEp1UGjCS5s6JZlvhv85wm YKrZljZFjpwxIsJGwjVuf/i2ymIogVHY7zmT7H7F67auIz2zycljE0DLne0G48iKO+J+ utK2wE+FmHK4UJFITQCT5doAz1YocN2UMo8Bacl71oJuMpca0cEY9TPIorhT+dx8ca5A a5vhw75zYRj/RlPraJohNmIcHoBrBtK/syqJxExHoF05i8DAzrgA6ckxqHFRRAc+Pp9f QansxZQ/13talMeoI5A43ysUclTWBeORMqZLA24MSHfa1ge3ZNoVHlQ3CB8xEuQe77JY uymQ== X-Gm-Message-State: ACrzQf2fOBQyOl4npqExiLVeRRSrEyJkOEtVkdxz73oQ9Zzs9GRTr8ZC hOIIaZj0jekrZ94Y8MHsiHI= X-Google-Smtp-Source: AMsMyM6Y9a6DvS8fqDSmM0Y81Av5H17sZdN/qLSkdiZaSUmkyLKxGeU3UvQ1KzlfoOqpZI4qVj/bNQ== X-Received: by 2002:a17:902:c405:b0:187:76e:2891 with SMTP id k5-20020a170902c40500b00187076e2891mr57723416plk.25.1668049680817; Wed, 09 Nov 2022 19:08:00 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id kx4-20020a17090b228400b002008d0e5cb5sm1906221pjb.47.2022.11.09.19.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 19:08:00 -0800 (PST) From: Miaoqian Lin To: Andrew Morton , Wei Xu , "Huang, Ying" , "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] mm/demotion: Fix NULL vs IS_ERR checking in memory_tier_init Date: Thu, 10 Nov 2022 07:07:51 +0400 Message-Id: <20221110030751.1627266-1-linmq006@gmail.com> X-Mailer: git-send-email 2.37.3.671.ge2130fe6da78.dirty MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668049682; a=rsa-sha256; cv=none; b=77mKo+LGiCqTVoOnGoV+YFTHl9Ha+UG2xgq8+qC7g0v+tPs+hJT6j4DF/SX48i2HI4bFzn 6WR1FbeAmFdMf0N2XqBdlspbfe5hbrxZQEUwD4lywd0JLjMAA3DF5jbXmxrPQlGZREGkLk j4peDron8O/rFWp51wz0ZTeXX9wba7w= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oaJmLTjf; spf=pass (imf19.hostedemail.com: domain of linmq006@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=linmq006@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668049682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Y6OU4ENNozkhINhc2+IJdoCoJp+Y8ceNlE8roxKPBjE=; b=AXTkyxIqxOkihOnlHo1VQACDvdsYClRtuCsSWV72GtcZe291Luc6foKrs7tmDU3XAU1SzA hzOFTyzbJBSgs+ZAGTULac+1F5abhJMg757sVPOEOhWRwfniVBsatlFRwndcHPfNFN0s57 yo+iv1nVIetdnyPW679R4jumfgTaXiQ= X-Stat-Signature: dapkzog1q7dzdhddc975mau9dhpta4g6 X-Rspamd-Queue-Id: E531C1A0005 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oaJmLTjf; spf=pass (imf19.hostedemail.com: domain of linmq006@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=linmq006@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1668049681-206161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The alloc_memory_type() function return error pointers on error instead of NULL. Use IS_ERR() to check the return value to fix this. Fixes: 7b88bda3761b ("mm/demotion/dax/kmem: set node's abstract distance to MEMTIER_DEFAULT_DAX_ADISTANCE") Signed-off-by: Miaoqian Lin --- mm/memory-tiers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index fa8c9d07f9ce..ac0dae9e54bf 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -645,7 +645,7 @@ static int __init memory_tier_init(void) * than default DRAM tier. */ default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); - if (!default_dram_type) + if (IS_ERR(default_dram_type)) panic("%s() failed to allocate default DRAM tier\n", __func__); /* -- 2.37.3.671.ge2130fe6da78.dirty