From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 322F6C43219 for ; Thu, 10 Nov 2022 00:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1F5F6B0072; Wed, 9 Nov 2022 19:02:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACEEB6B0073; Wed, 9 Nov 2022 19:02:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 970BB8E0001; Wed, 9 Nov 2022 19:02:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8A9026B0072 for ; Wed, 9 Nov 2022 19:02:11 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5332EC066B for ; Thu, 10 Nov 2022 00:02:11 +0000 (UTC) X-FDA: 80115580062.01.48A29C0 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf01.hostedemail.com (Postfix) with ESMTP id 3685540008 for ; Thu, 10 Nov 2022 00:02:08 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id o7so335107pjj.1 for ; Wed, 09 Nov 2022 16:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p7Daps8F455XQYwxt4zsfNkYk/NEUbSHg8y4fLlQGlw=; b=de0Un6NHJwrYjGdsd6Hymr0RokpmscUp2nh2NVTZj16/sDwr/QqPVU7saLLLzVMrUX YtE4r6ZyFaxxplkamm8PKWRaExJTGGKPuJBAXRgwy0dgvQ057uPnLb+EjXckvxx0bcwH LJ7COv565ogXqugWgr1BeSviJdw6iyuPBpUDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p7Daps8F455XQYwxt4zsfNkYk/NEUbSHg8y4fLlQGlw=; b=USUdCBdBS0tcoGmKYCMURw3Cy32iv6d0+0IeaizaE6nUYOonHZOLOCUdapRHvqBE/W Ljr+kJd2y1YaHA5cg7LnEywJvhXNE6M2qCjBZW25uESqvJn1thKlzK7Ct8VNReFvJ8Af dA7OY9Txd7dNS6VX33BBJvJr6iXC51dMMfqspUMgRDGAfih3pclL3WgVVHGGdnCHZenA uKoZjTQCphEx67n/ouSZ7PAdLoBIfZ8O0qLaXFT5t4uL7gtKtOOZMZtM1/A9/hQBrNhJ etCC5cQ2SOC6QKYfEl9xqWGHX7p5hMuAXZlxyyyy/PLkX+qzkRQaCyzezg3Nv6gUjBkG KGEA== X-Gm-Message-State: ACrzQf3QTnYCgBNrKdKRPw4JU6DO38orOrnFw+UtjJkkuB7WONIOlv7p kLJGCQ+6xq2Uheyz6HUBJZqH4g== X-Google-Smtp-Source: AMsMyM5bthcPbXOxkKa6K+tg7fCCiv2SKynZlpoNO+Ox1nGoYBjoLBD79gHYEBB3qUS2rPF4vEcp8g== X-Received: by 2002:a17:90a:f306:b0:213:b191:f3bf with SMTP id ca6-20020a17090af30600b00213b191f3bfmr62515127pjb.237.1668038526964; Wed, 09 Nov 2022 16:02:06 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i4-20020a056a00004400b005668b26ade0sm8799343pfk.136.2022.11.09.16.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 16:02:06 -0800 (PST) Date: Wed, 9 Nov 2022 16:02:05 -0800 From: Kees Cook To: Bill Wendling Cc: Jann Horn , Petr Mladek , Andrew Morton , tangmeng , "Guilherme G. Piccoli" , Tiezhu Yang , Sebastian Andrzej Siewior , Greg KH , Linus Torvalds , Seth Jenkins , Andy Lutomirski , "Eric W. Biederman" , Arnd Bergmann , Marco Elver , Dmitry Vyukov , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Vincenzo Frascino , Luis Chamberlain , David Gow , "Paul E. McKenney" , Jonathan Corbet , Baolin Wang , "Jason A. Donenfeld" , Eric Biggers , Huang Ying , Anton Vorontsov , Mauro Carvalho Chehab , Laurent Dufour , Rob Herring , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 1/6] panic: Separate sysctl logic from CONFIG_SMP Message-ID: <202211091601.E07A8D57@keescook> References: <20221109194404.gonna.558-kees@kernel.org> <20221109200050.3400857-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668038528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p7Daps8F455XQYwxt4zsfNkYk/NEUbSHg8y4fLlQGlw=; b=3z1WVSGAL6I5UEA8AM0SfKAD4Y0nQXjDMja160AFDQ5B/fvWmNiU7orR61ojCNl7d9rJXE Z82Sp/KxovgqlQUK/rIec3Zj6X4PXGOuSLXeKFhYEa9qehUMDYSv88Cq3u2+7uVrJ0BFXx 7wl/+FMBujlWBk20rXWArT9FaW8J7IY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=de0Un6NH; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.41 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668038528; a=rsa-sha256; cv=none; b=NaEdidPfo+fl3P7B2tsARmkfeY4PgqZyTcJYwRGts5VlGsssY0i4tni252H2gZF8/TS4Ly VA5JBwmD3VQjposDdehlmDYHy3qTpRmNC7EMBseL6oQ2iuV16+BGvuTxHtoJSKTOvtLOvs oHnQKR1aqpa3ctqxQ1TijeyX5ypBN38= X-Rspam-User: X-Stat-Signature: 4trqa3ufsnajrw9fatei1nkyi9dxw5a3 X-Rspamd-Queue-Id: 3685540008 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=de0Un6NH; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.41 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam07 X-HE-Tag: 1668038528-810681 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 09, 2022 at 01:48:45PM -0800, Bill Wendling wrote: > On Wed, Nov 9, 2022 at 12:01 PM Kees Cook wrote: > > > > In preparation for adding more sysctls directly in kernel/panic.c, split > > CONFIG_SMP from the logic that adds sysctls. > > > > Cc: Petr Mladek > > Cc: Andrew Morton > > Cc: tangmeng > > Cc: "Guilherme G. Piccoli" > > Cc: Tiezhu Yang > > Cc: Sebastian Andrzej Siewior > > Signed-off-by: Kees Cook > > --- > > kernel/panic.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/panic.c b/kernel/panic.c > > index da323209f583..129936511380 100644 > > --- a/kernel/panic.c > > +++ b/kernel/panic.c > > @@ -75,8 +75,9 @@ ATOMIC_NOTIFIER_HEAD(panic_notifier_list); > > > > EXPORT_SYMBOL(panic_notifier_list); > > > > -#if defined(CONFIG_SMP) && defined(CONFIG_SYSCTL) > > +#if CONFIG_SYSCTL > > Should this be "#ifdef CONFIG_SYSCTL"? > > > static struct ctl_table kern_panic_table[] = { > > +#if defined(CONFIG_SMP) > > nit: This could be "#ifdef CONFIG_SMP" Whoops, yes. Thanks. I'll fix these for v3. -- Kees Cook