From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB6BC4332F for ; Wed, 9 Nov 2022 11:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B4276B0073; Wed, 9 Nov 2022 06:51:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 464416B0074; Wed, 9 Nov 2022 06:51:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3536A8E0001; Wed, 9 Nov 2022 06:51:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2790D6B0073 for ; Wed, 9 Nov 2022 06:51:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2424A1371 for ; Wed, 9 Nov 2022 11:51:38 +0000 (UTC) X-FDA: 80113739076.03.2DE0353 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf15.hostedemail.com (Postfix) with ESMTP id 93037A0009 for ; Wed, 9 Nov 2022 11:51:32 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so1689383pji.0 for ; Wed, 09 Nov 2022 03:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CxgUv5Jq0W8ZFLhbjb9RaEmetBmdXcouEW/1Ze+ngG4=; b=hv/tWsa79zDploMiCRfP2WLvQCUm6/oR3RjNrpKYsUVMrG2aG4DHN667JQcPpo0Xd5 oW4yapOp9W+yIMxkRkbFUEHfQKYMTDId71N/E0NS1bLMEaWFLJmV1rKZ6K0enEDy3NzR d6ZjFjGXP38VU3BuVVaL+nxLbjBqyBONMDet4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CxgUv5Jq0W8ZFLhbjb9RaEmetBmdXcouEW/1Ze+ngG4=; b=J75D+4V+YOFoZjJcNWqq5yoHCEpZ3BlMhkFtcuwL6jFBft71kAQ2xfP+HN6X6dhJsz u/bx0GaEsgUx1iOBHmgMx5e68gkKaqFZ1x3QqqmNb70eB9lC51gnvs0u9dTQJPwqiI4G Kj37TvmY3EntwCidigJSLHD1SwTwzU7fT2uI3AE9zQtDUnWoSz8OQ5HLrmwdUDq3285m QL+8ReCiihk0Lljs6EVaooApHfqzmyGcCKN7X1PQTLg5A8YnK0kY2AS+MqKdCeXHmyKy XXpBiw0cW3DsxKR4Onk75w8Z2srEtupmhwA6UJnUSw0i6SvHK9LiP/8Gcmr9vuvjoVMt UECw== X-Gm-Message-State: ANoB5pmlhZW9cn0z7SO8CmECdejhaiBez79HadMZ6s6qX57rFUneFjng 3BXxEDpuSL6O9lG+5PjqTeNpwb/M2x24QQ== X-Google-Smtp-Source: AA0mqf4tBVBjmJv7avLtutcZSy3HULQ3lJ8Pc/mYPVodPYE5ju4Xo3CDRE/ta5HYDn3SR+WNZbg5ig== X-Received: by 2002:a17:902:6aca:b0:188:736c:befa with SMTP id i10-20020a1709026aca00b00188736cbefamr764365plt.8.1667994667622; Wed, 09 Nov 2022 03:51:07 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:61f1:44d3:3f47:2cdb]) by smtp.gmail.com with ESMTPSA id f5-20020a655505000000b00434760ee36asm7292311pgr.16.2022.11.09.03.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 03:51:07 -0800 (PST) From: Sergey Senozhatsky To: Minchan Kim , Andrew Morton Cc: Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: [PATCHv5 05/13] zram: Add recompress flag to read_block_state() Date: Wed, 9 Nov 2022 20:50:39 +0900 Message-Id: <20221109115047.2921851-6-senozhatsky@chromium.org> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog In-Reply-To: <20221109115047.2921851-1-senozhatsky@chromium.org> References: <20221109115047.2921851-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667994693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxgUv5Jq0W8ZFLhbjb9RaEmetBmdXcouEW/1Ze+ngG4=; b=m/ekmbrS60Nabp2cYTCU4PzubMsiPiIuAzECiWvjEF6wFmpIuR2+cJtNiCSAoSgVU0HZSd k9FNmzyaMiUrA9pxPocMG+z8W69c0i/ve4EhkCpGc9EQniig7UxL9C3yCzZSYulXHhvMCJ StAxn9wPFqdKvbODSFll0VUBesRA2Oc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="hv/tWsa7"; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667994693; a=rsa-sha256; cv=none; b=8m2UVHeaqjAP6CH8zsyS5p4XpO5WQwEPzVJRb60E856eJQcpdPmJOQWiQl/6vKKmaccmUG neGSoSr8fwNCw+/ppJaODp9cPzfsS78Cb4QfDnkXzr1CMZ3VY46OmM/2sVAr2DorQlSchK c+eio3Mlv+afUAjuHd7DCXsC5KMPawM= X-Rspamd-Queue-Id: 93037A0009 X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="hv/tWsa7"; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: 31xputrypanp6z55n18tuceh9cxne3zb X-HE-Tag: 1667994692-249837 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add a new flag to zram block state that shows if the page was recompressed (using alternative compression algorithm). Signed-off-by: Sergey Senozhatsky --- Documentation/admin-guide/blockdev/zram.rst | 9 ++++++--- drivers/block/zram/zram_drv.c | 5 +++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/Documentation/admin-guide/blockdev/zram.rst b/Documentation/admin-guide/blockdev/zram.rst index c73b16930449..177a142c3146 100644 --- a/Documentation/admin-guide/blockdev/zram.rst +++ b/Documentation/admin-guide/blockdev/zram.rst @@ -411,9 +411,10 @@ pages of the process with*pagemap. If you enable the feature, you could see block state via /sys/kernel/debug/zram/zram0/block_state". The output is as follows:: - 300 75.033841 .wh. - 301 63.806904 s... - 302 63.806919 ..hi + 300 75.033841 .wh.. + 301 63.806904 s.... + 302 63.806919 ..hi. + 303 62.801919 ....r First column zram's block index. @@ -430,6 +431,8 @@ Third column huge page i: idle page + r: + recompressed page (secondary compression algorithm) First line of above example says 300th block is accessed at 75.033841sec and the block's state is huge so it is written back to the backing diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 749e4266dd72..560e2932021e 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -939,13 +939,14 @@ static ssize_t read_block_state(struct file *file, char __user *buf, ts = ktime_to_timespec64(zram->table[index].ac_time); copied = snprintf(kbuf + written, count, - "%12zd %12lld.%06lu %c%c%c%c\n", + "%12zd %12lld.%06lu %c%c%c%c%c\n", index, (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC, zram_test_flag(zram, index, ZRAM_SAME) ? 's' : '.', zram_test_flag(zram, index, ZRAM_WB) ? 'w' : '.', zram_test_flag(zram, index, ZRAM_HUGE) ? 'h' : '.', - zram_test_flag(zram, index, ZRAM_IDLE) ? 'i' : '.'); + zram_test_flag(zram, index, ZRAM_IDLE) ? 'i' : '.', + zram_get_priority(zram, index) ? 'r' : '.'); if (count <= copied) { zram_slot_unlock(zram, index); -- 2.38.1.431.g37b22c650d-goog