From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17EB1C433FE for ; Wed, 9 Nov 2022 11:52:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA7B48E0001; Wed, 9 Nov 2022 06:52:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0A166B0074; Wed, 9 Nov 2022 06:52:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 883718E0001; Wed, 9 Nov 2022 06:52:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 752EA6B0072 for ; Wed, 9 Nov 2022 06:52:26 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 23472141473 for ; Wed, 9 Nov 2022 11:52:21 +0000 (UTC) X-FDA: 80113740882.14.95C1B1E Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf13.hostedemail.com (Postfix) with ESMTP id C33AA20013 for ; Wed, 9 Nov 2022 11:52:15 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id o7so16503771pjj.1 for ; Wed, 09 Nov 2022 03:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ylEXai1pRtcdgY4n/dSSiM2pUBQ7klnnGwSEjhZhHnw=; b=Y8CaZZpNNRXSN720dhEH8GJYbNFPJnj7qu6nXjDoVmEhFp1S6sV0e5ZQD+4UJySJNP 6DPd+IsRr86SFqTWAIdYjHgWtQNzwRPeddZW8CfJIS+alIOMUtWqfLZYH9fKJUQ8sb1r Q+bjOa0eFHIPuVVvPiHll8unqEXUpibFpPrb4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ylEXai1pRtcdgY4n/dSSiM2pUBQ7klnnGwSEjhZhHnw=; b=sEJjuzgcT3vrnduE19dSZSV5Xn3bSaWwNQ4az6F+mJCBUlTpatFOqrgA6KvlacYGBI ijGpP1xDZl2o1HtqZbyX6iDMMICTzoxbpMGub/jDtBNsKvq5w0n7B/U6WSDWkVDpHgaI bXV9mN9561diNxF2ibU75ljIxUU0NqV/0f/jLOckP714wEnvWpjp2IBJW6rXau+DQPeu HlpmayT4vz83zsjgRiPYbd1BYWgrHgz0qVU3GO0+M6+JzHIbhLSXdQfq/9sB2uDzi9o0 PGPy8g0Hm5IczWUhv1GiiSQre2p/U/0SuKmiq7LYJgXEqRuEXtsQ+5Aco8YzhnZQY7Or dfOA== X-Gm-Message-State: ACrzQf1n7+UxCHl8YqkQ60iED5V9YoZJpqRM6oxUIpyo0+LpiiuOPt2i EYgvNA8Vg+m3uopmP1arKZ/uPw== X-Google-Smtp-Source: AMsMyM7uMF0Rz+8FL9QxtxgFBHi/+RsBUmvD/klEYsmwj83jE4uQ0gTGXKrZehLIcGHB3AaAGJSvPw== X-Received: by 2002:a17:902:d708:b0:187:2721:68ca with SMTP id w8-20020a170902d70800b00187272168camr50203566ply.92.1667994685692; Wed, 09 Nov 2022 03:51:25 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:61f1:44d3:3f47:2cdb]) by smtp.gmail.com with ESMTPSA id f5-20020a655505000000b00434760ee36asm7292311pgr.16.2022.11.09.03.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 03:51:25 -0800 (PST) From: Sergey Senozhatsky To: Minchan Kim , Andrew Morton Cc: Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: [PATCHv5 12/13] zram: add incompressible writeback Date: Wed, 9 Nov 2022 20:50:46 +0900 Message-Id: <20221109115047.2921851-13-senozhatsky@chromium.org> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog In-Reply-To: <20221109115047.2921851-1-senozhatsky@chromium.org> References: <20221109115047.2921851-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Y8CaZZpN; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667994735; a=rsa-sha256; cv=none; b=1ZluC1OQCfrTNdEbbEwalV1U6V2IAV+pHnYHeaQFLN1fjxG0g0TFOhrjA8N9hgFeubf34U /cGLb9Styw6tn9+nr3ROIq9ryMGzvhoAN1an0Gt78UOOdlepaql/z9bY97Ginr0/nCO4Gz u5R4AHD4nVZDSdSvkYp1AlgFbvYERAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667994735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ylEXai1pRtcdgY4n/dSSiM2pUBQ7klnnGwSEjhZhHnw=; b=e9mSiSfsmv3yfG3ti0k8zTe2ZO5SpX0+MusLf4ocbMONBdAHaQmVl7slOdbpY55OvSgFR6 FtVHmMN3is4x1IC9WqvU+L++wPxOdA6dHhG8u1hTEAYiWMYyBtKPPu9fXqpp2SOgLhnnxR 9/FvHEFrIc/kz1SFmszRWwnHbo6zjgg= X-Stat-Signature: mmgj8bb11tsthrz3mgkxxznynaekgwjd X-Rspamd-Queue-Id: C33AA20013 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Y8CaZZpN; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1667994735-945051 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add support for incompressible pages writeback: echo incompressible > /sys/block/zramX/writeback Signed-off-by: Sergey Senozhatsky --- Documentation/admin-guide/blockdev/zram.rst | 7 ++++++- drivers/block/zram/zram_drv.c | 18 ++++++++++++------ 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/Documentation/admin-guide/blockdev/zram.rst b/Documentation/admin-guide/blockdev/zram.rst index d898b7ace33d..f14c8c2e42f3 100644 --- a/Documentation/admin-guide/blockdev/zram.rst +++ b/Documentation/admin-guide/blockdev/zram.rst @@ -348,8 +348,13 @@ this can be accomplished with:: echo huge_idle > /sys/block/zramX/writeback +If a user chooses to writeback only incompressible pages (pages that none of +algorithms can compress) this can be accomplished with:: + + echo incompressible > /sys/block/zramX/writeback + If an admin wants to write a specific page in zram device to the backing device, -they could write a page index into the interface. +they could write a page index into the interface:: echo "page_index=1251" > /sys/block/zramX/writeback diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 89d25f60b33e..2e4ef1ba1973 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -648,10 +648,10 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec, #define PAGE_WB_SIG "page_index=" -#define PAGE_WRITEBACK 0 -#define HUGE_WRITEBACK (1<<0) -#define IDLE_WRITEBACK (1<<1) - +#define PAGE_WRITEBACK 0 +#define HUGE_WRITEBACK (1<<0) +#define IDLE_WRITEBACK (1<<1) +#define INCOMPRESSIBLE_WRITEBACK (1<<2) static ssize_t writeback_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) @@ -672,6 +672,8 @@ static ssize_t writeback_store(struct device *dev, mode = HUGE_WRITEBACK; else if (sysfs_streq(buf, "huge_idle")) mode = IDLE_WRITEBACK | HUGE_WRITEBACK; + else if (sysfs_streq(buf, "incompressible")) + mode = INCOMPRESSIBLE_WRITEBACK; else { if (strncmp(buf, PAGE_WB_SIG, sizeof(PAGE_WB_SIG) - 1)) return -EINVAL; @@ -734,11 +736,15 @@ static ssize_t writeback_store(struct device *dev, goto next; if (mode & IDLE_WRITEBACK && - !zram_test_flag(zram, index, ZRAM_IDLE)) + !zram_test_flag(zram, index, ZRAM_IDLE)) goto next; if (mode & HUGE_WRITEBACK && - !zram_test_flag(zram, index, ZRAM_HUGE)) + !zram_test_flag(zram, index, ZRAM_HUGE)) goto next; + if (mode & INCOMPRESSIBLE_WRITEBACK && + !zram_test_flag(zram, index, ZRAM_INCOMPRESSIBLE)) + goto next; + /* * Clearing ZRAM_UNDER_WB is duty of caller. * IOW, zram_free_page never clear it. -- 2.38.1.431.g37b22c650d-goog