From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D58C433FE for ; Wed, 9 Nov 2022 07:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C402F6B0072; Wed, 9 Nov 2022 02:04:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA25B6B0073; Wed, 9 Nov 2022 02:04:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D6B6B0074; Wed, 9 Nov 2022 02:04:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8E5A66B0072 for ; Wed, 9 Nov 2022 02:04:34 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6E7BE1613C2 for ; Wed, 9 Nov 2022 07:04:34 +0000 (UTC) X-FDA: 80113015668.02.D303E2C Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf23.hostedemail.com (Postfix) with ESMTP id 0948D140015 for ; Wed, 9 Nov 2022 07:04:28 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id k5so15880536pjo.5 for ; Tue, 08 Nov 2022 23:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zSRw6nfdCPaMCQzx3jE+HEvjxFnji+/pTOoyXTdquzQ=; b=K1QccXq8zGYDQPCT01fpavRZS+3GR2LdhwmxeSruUTnDnGDZJVASHd65B4QgmtE0aF 4giOK3TrfRJWZTQRYUpBAqE3zxCJj1t45z5MDUvPYFY+GJGY/qOvlnwo4sByTsSaqIMk E+1wQYCdJm1XCWoA7I/VtEs1Nvv7XKuj6lgdxQoLTq7d2COGG9+Z4aIKwpSmb/kbJ8im HfejMODT3G4QL2GWSCFSWYvkPqDetayUE9cca77CR8PMz9JeREcBM/6lvsfNV4LznYsV XnQXD4zPWtYkF37R4NYV0CY6xYh/sZNDMGRQ+7HtLQxqliQIDlpOgzBpXyProExchux+ F48g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zSRw6nfdCPaMCQzx3jE+HEvjxFnji+/pTOoyXTdquzQ=; b=JMKo8E62LHgW27WPShcb5EIMmo06OIxK1SzQM62yfNi0DEXu/pVJo8JQV11r0YTgRb HifotPLdtw6es9G/bz7STRNTltwOgLB8AFStMlTpZk4Fq9yNaOYMTlY0NSDnu8fh2Z/b 9P+Hqdod6PyJ6+ZXAiKvBUlO+nYAUFBngRp4vgfe2oNCJ8IZkVPuBDtwfuB2oTfSceZl GkpmzRwXLs4Dh0+fzmT8U51haay2TY+0andT8UjkqLPQ3wsYFBBO/4lteRNNN/KgPQz3 gzjdp6qwM0KwC5iNHBIOCJQgo0rfZvaTDoOJivDStEj60+cLcyBOZ7GvMP+V3bDyZZOE omxA== X-Gm-Message-State: ACrzQf3MCpaJI/eeQcV2ZmZKWOukwb2WOgyhyFbCOxWtYT+jWb00yknD VWESKJouzdTfh9HJeBWRCmk= X-Google-Smtp-Source: AMsMyM4himXTZ1Oet6yD4mIg1+GbxpQRrGdlz9D2+SGVHbyEDjyVUAA42XAzqGBUnhGiWspjN1323w== X-Received: by 2002:a17:902:db12:b0:187:4736:f780 with SMTP id m18-20020a170902db1200b001874736f780mr37864396plx.145.1667977461892; Tue, 08 Nov 2022 23:04:21 -0800 (PST) Received: from xuchao.. ([129.227.152.6]) by smtp.gmail.com with ESMTPSA id x11-20020aa7940b000000b0056bf29c9ba3sm7788696pfo.146.2022.11.08.23.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 23:04:21 -0800 (PST) From: Chao Xu X-Google-Original-From: Chao Xu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chao Xu Subject: [PATCH] mm/vmscan: simplify the nr assignment logic for pages to scan Date: Wed, 9 Nov 2022 15:04:16 +0800 Message-Id: <20221109070416.620887-1-Chao.Xu9@zeekrlife.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667977469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=zSRw6nfdCPaMCQzx3jE+HEvjxFnji+/pTOoyXTdquzQ=; b=orm8Dsghu3PgnY2oOnTyor5f5sc5lR5X12FclUYDSAq7i2t2WL3iaPEubfV7CvXg0ThoDD fFBQ+98TZaqKWnsrsy0MD4NTw628/WnQjLopwuAG539p/+e4tkkrQ5J4ZU4Ot1yFWX4Pt5 Q9Se1//6a+LRkCobKpFK0H0wyhUAQmY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K1QccXq8; spf=pass (imf23.hostedemail.com: domain of amos.xuchao@gmail.com designates 209.85.216.68 as permitted sender) smtp.mailfrom=amos.xuchao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667977469; a=rsa-sha256; cv=none; b=HzXrl4kZjUIfDifVceAnUvKkPzY3/XDvKt1ZxnBVoZbo+Ht03Y8wc+M7CCQatiLThiDXlM buUVl2Wi1t2fh3yRAxAUg5RlhGmSSjlskIUyGwsFJ/npZTrogGIA8D/8AC4KGLPwfiEelY VSOP1+Fw5XSRgIb/bM0loXEOnfQwz/Y= X-Rspam-User: X-Stat-Signature: 4phg43hw8n849gm4jcjxwzhc9ptfk9w3 X-Rspamd-Queue-Id: 0948D140015 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K1QccXq8; spf=pass (imf23.hostedemail.com: domain of amos.xuchao@gmail.com designates 209.85.216.68 as permitted sender) smtp.mailfrom=amos.xuchao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-HE-Tag: 1667977468-450295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: By default the assignment logic of anonymouns or file inactive pages and active pages to scan using the same duplicated code snippet. To simplify the logic, merge the same part. Signed-off-by: Chao Xu --- mm/vmscan.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 04d8b88e5216..df3c0cbe381f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5932,14 +5932,11 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) * scan target and the percentage scanning already complete */ lru = (lru == LRU_FILE) ? LRU_BASE : LRU_FILE; - nr_scanned = targets[lru] - nr[lru]; - nr[lru] = targets[lru] * (100 - percentage) / 100; - nr[lru] -= min(nr[lru], nr_scanned); - - lru += LRU_ACTIVE; - nr_scanned = targets[lru] - nr[lru]; - nr[lru] = targets[lru] * (100 - percentage) / 100; - nr[lru] -= min(nr[lru], nr_scanned); + for ( ; lru <= lru + LRU_ACTIVE; lru++) { + nr_scanned = targets[lru] - nr[lru]; + nr[lru] = targets[lru] * (100 - percentage) / 100; + nr[lru] -= min(nr[lru], nr_scanned); + } scan_adjusted = true; } -- 2.34.1