From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF885C4332F for ; Wed, 9 Nov 2022 00:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A3456B0071; Tue, 8 Nov 2022 19:32:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52B7A6B0072; Tue, 8 Nov 2022 19:32:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CD278E0001; Tue, 8 Nov 2022 19:32:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2671E6B0071 for ; Tue, 8 Nov 2022 19:32:30 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EE48081121 for ; Wed, 9 Nov 2022 00:32:29 +0000 (UTC) X-FDA: 80112027618.27.37DE837 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 7E4ED140018 for ; Wed, 9 Nov 2022 00:32:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5DDC6B81CAE; Wed, 9 Nov 2022 00:31:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3ABFC433C1; Wed, 9 Nov 2022 00:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667953885; bh=60CWbc6xEw7X0NYzHrj2+bHlAe/BjGKdikDuaZWCdT8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ii1ohMOHnQ8+KT4qO4mP0IdkzvaPjv1FVWeOaqhWtiqul1mOCqa5sVXVUcR20GnNE AxOIPigKUIHP6ez22gsA1jnva00qAOLrlvg8rJ4nNizVN3c4lL/daeimNBTLOZzrFT zl9HMzebVg7z6yvXdiKS4Ndi4uuAIjfp+eohzf14= Date: Tue, 8 Nov 2022 16:31:24 -0800 From: Andrew Morton To: Joel Savitz Cc: linux-kernel@vger.kernel.org, Shuah Khan , David Hildenbrand , Nico Pache , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH linux-next] selftests/vm: calculate variables in correct order Message-Id: <20221108163124.a54f932f8f79f9c1d6e63903@linux-foundation.org> In-Reply-To: <20221028132640.2791026-1-jsavitz@redhat.com> References: <20221028132640.2791026-1-jsavitz@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667953949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xVwF+6kd8PPrsPEhELPk/DL74KjbIKXALykI1a/eN94=; b=4LhPj69ppj55TFQebq5vgozNxFWVjIsOdYjDnFGrAe8L7cdL9m/FZUPcI/liEi5yAU3Sc8 g15zJZmHGsuSdE49f4tQI0DQRKSxboAc9zs4jRW5iQW88ubPuu28h5v9KEtQNSXZmwZ1D4 Hao8RLAa8ekiLt4FGy6jJ4rDfXeoXt4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ii1ohMOH; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667953949; a=rsa-sha256; cv=none; b=cvNdVYlDmfrpqX6H2DX2y7MP7hFoAH4I7Fm1Xc2yJXDMkrck0K5HhyaMLIIbHYAj331l1K YwaYKga8d+ZIT3FX/sNKjFK5kgxXzWq2/08eoY/IczGJjqBzWW5YoHihGT/KdadR5Mv89o 0QJWvwhf6s1qdqkDivW0V6YhsLfvoP4= X-Rspam-User: X-Stat-Signature: mny4r6w839axc6s35qbmos8p7f8od11q X-Rspamd-Queue-Id: 7E4ED140018 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ii1ohMOH; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam02 X-HE-Tag: 1667953949-21018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 28 Oct 2022 09:26:40 -0400 Joel Savitz wrote: > commit b5ba705c2608 ("selftests/vm: enable running select groups of tests") > unintentionally reversed the ordering of some of the lines of > run_vmtests.sh that calculate values based on system configuration. > Importantly, $hpgsize_MB is determined from $hpgsize_KB, but this later > value is not read from /proc/meminfo until later, causing userfaultfd > tests to incorrectly fail since $half_ufd_size_MB will always be 0. > > Switch these statements around into proper order to fix the invocation > of the userfaultfd tests that use $half_ufd_size_MB. Does this fix address the failure in https://lkml.kernel.org/r/202211021026.61b267d1-yujie.liu@intel.com? Thanks.