From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF01BC4332F for ; Tue, 8 Nov 2022 00:11:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DCFB6B0072; Mon, 7 Nov 2022 19:11:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68E046B0073; Mon, 7 Nov 2022 19:11:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57BE38E0001; Mon, 7 Nov 2022 19:11:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 495196B0072 for ; Mon, 7 Nov 2022 19:11:05 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1EAD480961 for ; Tue, 8 Nov 2022 00:11:05 +0000 (UTC) X-FDA: 80108344890.13.7881B83 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 8F59E80006 for ; Tue, 8 Nov 2022 00:11:04 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 80516B816A4; Tue, 8 Nov 2022 00:11:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAAECC433C1; Tue, 8 Nov 2022 00:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667866261; bh=vHxhyutP9cB7DvECPymVNKDyiMvhF4zNuceuNtDxwVU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QZRY4ge/npV98d4/kIKfngLY8FdtlsE7dEX5IqV44G+gV2NeHk8t2bT2HH+ofN6uO 5f+m/AQbIbX6UasdlDuqZkznV4Vn2eay6p+KPxpnSRDdYgJQOqJDLXrN4VnxmgJRae VVFUyjRCM94IgGLj3PXl6k24I+F1vWK9jKp9tLDI= Date: Mon, 7 Nov 2022 16:10:59 -0800 From: Andrew Morton To: HORIGUCHI =?UTF-8?B?TkFPWUE=?=(=?UTF-8?B?5aCA5Y+j44CA55u05Lmf?=) Cc: Ville =?UTF-8?B?U3lyasOkbMOk?= , Naoya Horiguchi , "linux-mm@kvack.org" , David Hildenbrand , Mike Kravetz , Miaohe Lin , Liu Shixin , Yang Shi , Oscar Salvador , Muchun Song , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1] arch/x86/mm/hugetlbpage.c: pud_huge() returns 0 when using 2-level paging Message-Id: <20221107161059.11414d456e24b77553d5a2df@linux-foundation.org> In-Reply-To: <20221108000014.GB471526@hori.linux.bs1.fc.nec.co.jp> References: <20221107021010.2449306-1-naoya.horiguchi@linux.dev> <20221108000014.GB471526@hori.linux.bs1.fc.nec.co.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667866264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B4BtRegN2LnNJEbOSHgCLSU3+wXROc1+T1czmrmpgfA=; b=26176BNre0K+S+jAuEte63+GZA71al0a7pOMLyM3j/VGSe6UJybiS+hRG1k0HaqxtYEF7S fctylTaSwfpD1M0+4nW/qSadNiFxnW0UBDu8bMg11NkLXGCZupth+PrHB8jqB2wWzDg6ci psHbaYVQskvJ7Qbeg0qZbU/vip8YfNU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="QZRY4ge/"; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667866264; a=rsa-sha256; cv=none; b=VRQXdzehn1iHP94OXm7UFLJO0RFxqhB1iasoIgLpxbBrK1AGu35dk7EIXo6KAARvF/q08C s5bC8v9qpjOptAXQQ3f1I9HpoajrnqIw/sBHaOXVI5R6aqBa8DCQw/8czKisbboyuTRn8i 05ux+Ru7K8GJfgVlpcTM6zLh92NNGqM= X-Rspam-User: X-Stat-Signature: om3gbeyirn7zu5ywio8bo1cuwi8brpqr X-Rspamd-Queue-Id: 8F59E80006 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="QZRY4ge/"; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam07 X-HE-Tag: 1667866264-872717 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 8 Nov 2022 00:00:15 +0000 HORIGUCHI NAOYA(堀口　直也) wrote: > > > Recently pud_huge() got aware of non-present entry by commit 3a194f3f8ad0 > > > ("mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present > > > pud entry") to handle some special states of gigantic page. However, it's > > > overlooked that pud_none() always returns false when running with 2-level > > > paging, and as a result pmd_huge() can return true pointlessly. > > Sorry, I found a non-negligible typo here (s/pmd_huge/pud_huge/). > Andrew, could you fix this on mm-hotfixes-unstable? Done, thanks.