From: Andrew Morton <akpm@linux-foundation.org>
To: "HORIGUCHI NAOYA" <naoya.horiguchi@nec.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Naoya Horiguchi" <naoya.horiguchi@linux.dev>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"David Hildenbrand" <david@redhat.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
"Miaohe Lin" <linmiaohe@huawei.com>,
"Liu Shixin" <liushixin2@huawei.com>,
"Yang Shi" <shy828301@gmail.com>,
"Oscar Salvador" <osalvador@suse.de>,
"Muchun Song" <songmuchun@bytedance.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] arch/x86/mm/hugetlbpage.c: pud_huge() returns 0 when using 2-level paging
Date: Mon, 7 Nov 2022 16:10:59 -0800 [thread overview]
Message-ID: <20221107161059.11414d456e24b77553d5a2df@linux-foundation.org> (raw)
In-Reply-To: <20221108000014.GB471526@hori.linux.bs1.fc.nec.co.jp>
On Tue, 8 Nov 2022 00:00:15 +0000 HORIGUCHI NAOYA(堀口 直也) <naoya.horiguchi@nec.com> wrote:
> > > Recently pud_huge() got aware of non-present entry by commit 3a194f3f8ad0
> > > ("mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present
> > > pud entry") to handle some special states of gigantic page. However, it's
> > > overlooked that pud_none() always returns false when running with 2-level
> > > paging, and as a result pmd_huge() can return true pointlessly.
>
> Sorry, I found a non-negligible typo here (s/pmd_huge/pud_huge/).
> Andrew, could you fix this on mm-hotfixes-unstable?
Done, thanks.
next prev parent reply other threads:[~2022-11-08 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 2:10 Naoya Horiguchi
2022-11-07 12:42 ` Ville Syrjälä
2022-11-08 0:00 ` HORIGUCHI NAOYA(堀口 直也)
2022-11-08 0:10 ` Andrew Morton [this message]
2022-11-08 1:36 ` Miaohe Lin
2022-11-09 3:14 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107161059.11414d456e24b77553d5a2df@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox