From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD2BC4332F for ; Mon, 7 Nov 2022 14:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA6726B0071; Mon, 7 Nov 2022 09:43:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C56DB6B0072; Mon, 7 Nov 2022 09:43:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6CED6B0073; Mon, 7 Nov 2022 09:43:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A9B656B0071 for ; Mon, 7 Nov 2022 09:43:18 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DAB1C0D9B for ; Mon, 7 Nov 2022 14:43:18 +0000 (UTC) X-FDA: 80106914076.20.5842D07 Received: from mail3-164.sinamail.sina.com.cn (mail3-164.sinamail.sina.com.cn [202.108.3.164]) by imf07.hostedemail.com (Postfix) with ESMTP id 3C5C240006 for ; Mon, 7 Nov 2022 14:43:15 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.249.57.238]) by sina.com (172.16.97.35) with ESMTP id 636918FA0001477E; Mon, 7 Nov 2022 22:41:00 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 21003215073776 From: Hillf Danton To: Jan Kara Cc: LKML , Thomas Gleixner , Steven Rostedt , Sebastian Andrzej Siewior , linux-mm@kvack.org, Mel Gorman Subject: Re: Crash with PREEMPT_RT on aarch64 machine Date: Mon, 7 Nov 2022 22:43:02 +0800 Message-Id: <20221107144302.892-1-hdanton@sina.com> In-Reply-To: <20221107124149.bbcigolec3z7bfau@quack3> References: <20221103115444.m2rjglbkubydidts@quack3> <20221104080637.626-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.164 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667832198; a=rsa-sha256; cv=none; b=G45fqKWaN2mix7cDfGd7Kco6o1rGi/j/CJ7GqsTSl5aem6Qw32ZUf2e5OgqONgH/1UnILF W8Amt2efUr5HRC1DPxGi7ET8F/dR2cgRsY6CfJARqPkXu+MaC1SvZGEOttkdgmnRKWPOYt rmW+IfNldYgB1rSKwVXoAi0A9Z8KIU4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667832198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qYWJdHdeWDeX3k3qo2unEEk5cJrTvUhh1PHbB+wMUhc=; b=ebkQdbCazf74XuJ+uvb17zyswd2noWws60uK/k+nrx17D/2F7AbON2mHDQLQJGBMtP1r5A PbxXht1Csyaw4XDSuG6L2N8sCs4l8l9BoR7ct29W8MJcyJUjzKM3VaC8AZYdCanqAtTZzB BGGGUKdZykuW3Bmp8BwzBD7z9tPhY54= X-Stat-Signature: iwb3dnw6petr1r4e6syikgzeuqj6ea6g X-Rspamd-Queue-Id: 3C5C240006 Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.164 as permitted sender) smtp.mailfrom=hdanton@sina.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1667832195-772560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7 Nov 2022 13:41:49 +0100 Jan Kara > So in fact I made sure (by debug counters) that sb_mark_inode_writeback() > and sb_clear_inode_writeback() get called the same number of times before > evict() gets called. So your debug patch would change nothing AFAICT... The same number you observed != the difference ihold + iput can make since the added ihold ensures the crash has nothing to do with the two functions mentioned if it reproduces. Right?