From: Andrew Morton <akpm@linux-foundation.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] filemap: skip range writeback if end offset precedes start
Date: Mon, 7 Nov 2022 12:28:02 -0800 [thread overview]
Message-ID: <20221107122802.d214dd0a3c546d3a35c71e9c@linux-foundation.org> (raw)
In-Reply-To: <Y2kzal5gKKANd9sB@bfoster>
On Mon, 7 Nov 2022 11:33:46 -0500 Brian Foster <bfoster@redhat.com> wrote:
> Perhaps a good starting point would be to wrap the check in
> this patch with a WARN_ON_ONCE() and let it soak in -next for a while?
> That would avoid excessive noise from repetitive callers [1] but still
> allow those callsites to be identified/fixed. If there is some really
> weird fdatawrite-only caller that conflicts, the change could always be
> loosened up from there (as unlikely as that seems).. Hm?
Sounds reasonable.
Please let's be clear in the changelog why we're adding this. I mean,
we could add a zillion checks everywhere for misbehaving callers. Why
choose this one place in particular?
next prev parent reply other threads:[~2022-11-07 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 12:54 Brian Foster
2022-10-31 4:51 ` Andrew Morton
2022-11-07 16:33 ` Brian Foster
2022-11-07 20:28 ` Andrew Morton [this message]
2022-11-14 17:35 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107122802.d214dd0a3c546d3a35c71e9c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bfoster@redhat.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox