From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20033C4332F for ; Sat, 5 Nov 2022 19:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 073176B0072; Sat, 5 Nov 2022 15:13:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 023CA8E0001; Sat, 5 Nov 2022 15:13:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E05AA6B0074; Sat, 5 Nov 2022 15:13:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD9566B0072 for ; Sat, 5 Nov 2022 15:13:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9735C40343 for ; Sat, 5 Nov 2022 19:13:27 +0000 (UTC) X-FDA: 80100337254.21.8C51840 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf11.hostedemail.com (Postfix) with ESMTP id E587E40005 for ; Sat, 5 Nov 2022 19:13:26 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 477F35C009E; Sat, 5 Nov 2022 15:13:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 05 Nov 2022 15:13:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1667675606; x=1667762006; bh=nf st00B3ar0fS6yyqnIszehJzeNqL8xbt2qu9HpZL+o=; b=Gz/ts10XdQhE6feVN6 gBKQDWPR7PYYCj9NRPuk4M7uAjNGkdoU0ZBJlsACGNaVIA2XZ5J7NG9AIPmsdLF8 Ye/6emYAD5wieC45FSGYXyOpZhnQYBv6bhHdNv6cKywDaVjgCvQInjTq8sEXfM/p yooXT0aofD70Sk1wjWRbJT6HmG/7Mk8pypzANIhNVLM9itCB40boBuZd9b3F37Cw t4CkcxfaZS00G+AbPwwdFOQXl0hza96BNtcuLuylWhfzh+OBda3lbdeq9/SrR2vT 4vsIEsMa0ZJn31+UOFXabHBQrHEAbNigdBwry2ulreSsQ4drK/EYVnuSENZykDih EfOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667675606; x=1667762006; bh=nfst00B3ar0fS6yyqnIszehJzeNq L8xbt2qu9HpZL+o=; b=af8XiI9YOX23CCnxKxQsXeAvLiJqdz8DminAgnULd5iM W8m/DoLV9K/RSgk4OfuP9ILg4nC7wAy04CKbcQllNdret2uCchpbj10Ss5mZj32f JUAS8CDr0dvjlrfsLyjCw+1nIyCrNCrB2hQyv8VrKYgmcvyb0MWi9ytUKxEOj1v6 Hkosyu35gIrM9Z78tXAcu2Z1/3XMITp6WKBG9EvMC4jbpJ0NY5VJuNK6hrN05Lul iGAvnW/fol0199qcUhuET5vwH6XrL2UuF5NtXiji8wiVD6A4GwOPq9FWlkRtqbvy c2AobcngU128DNoHhz1DID9VkbRsoc3bUZPaCcwQRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdeggddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpedfmfhirhhi lhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllhesshhhuhhtvghmohhvrdhnrg hmvgeqnecuggftrfgrthhtvghrnhepkedvvdejffehteegtddvgfeijeeivdegjeeiteej heeiheevffeukeefheffvdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Nov 2022 15:13:25 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id D8FD9104449; Sat, 5 Nov 2022 22:13:21 +0300 (+03) Date: Sat, 5 Nov 2022 22:13:21 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , David Hildenbrand , Vlastimil Babka , Peter Xu , Yang Shi , John Hubbard , Mike Kravetz , Sidhartha Kumar , Muchun Song , Miaohe Lin , Naoya Horiguchi , Mina Almasry , James Houghton , Zach O'Keefe , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm,hugetlb: use folio fields in second tail page Message-ID: <20221105191321.572bdm67tulpva5k@box> References: <5f52de70-975-e94f-f141-543765736181@google.com> <3818cc9a-9999-d064-d778-9c94c5911e6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3818cc9a-9999-d064-d778-9c94c5911e6@google.com> ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="Gz/ts10X"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=af8XiI9Y; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667675607; a=rsa-sha256; cv=none; b=aTX/+CAoWXx9h4oBJ6hINVlmxP4r6YaaNoDatm0B6l5r6fdLLhoclVATPTPIZ3n/owGXiN 7dies0iBnpInad1DF+aU4BNb2R5fp3tCTsX466qzsTHajQh0+eW5SSDW2FdbM3RaCQ/G05 vF65qMY+1p98Gqy8D5csrFoPzFuwprk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667675607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nfst00B3ar0fS6yyqnIszehJzeNqL8xbt2qu9HpZL+o=; b=HIHbYFskGi0SBrRpUQZIdSDTVETWaixiEIHXz/GytbULYGpDstmnwc7uM1QmcHKLb9XqFD VI/lvbUa96k963F4//nVLF1CiqGM92NB/uRuk3EBDqLYgDaex77Km7K4cqWINNsEtMXfGp ykVfGeoXQOOL9B/P9KTCffWzXqE4ToU= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E587E40005 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="Gz/ts10X"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=af8XiI9Y; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Stat-Signature: iegtoxqhm3cwzo1jdf8oyfzn4d5bcp5o X-Rspam-User: X-HE-Tag: 1667675606-18697 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 02, 2022 at 06:48:45PM -0700, Hugh Dickins wrote: > @@ -260,13 +267,16 @@ struct page { > * to find how many references there are to this folio. > * @memcg_data: Memory Control Group data. > * @_flags_1: For large folios, additional page flags. > - * @__head: Points to the folio. Do not use. > + * @_head_1: Points to the folio. Do not use. > * @_folio_dtor: Which destructor to use for this folio. > * @_folio_order: Do not use directly, call folio_order(). > * @_total_mapcount: Do not use directly, call folio_entire_mapcount(). > * @_pincount: Do not use directly, call folio_maybe_dma_pinned(). > * @_folio_nr_pages: Do not use directly, call folio_nr_pages(). > - * @_private_1: Do not use directly, call folio_get_private_1(). Looks like it misses + * @_flags_2: For large folios, additional page flags. + * @_head_2: Points to the folio. Do not use. to match the first tail page documentation. Otherwise the patch looks good to me: Acked-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov