From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1342AC433FE for ; Fri, 4 Nov 2022 23:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F1006B0071; Fri, 4 Nov 2022 19:36:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1056B0073; Fri, 4 Nov 2022 19:36:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78F926B0074; Fri, 4 Nov 2022 19:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A65E6B0071 for ; Fri, 4 Nov 2022 19:36:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3A585C0ACB for ; Fri, 4 Nov 2022 23:36:43 +0000 (UTC) X-FDA: 80097371886.04.128F3CA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id D2E05180002 for ; Fri, 4 Nov 2022 23:36:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE3BD6238C; Fri, 4 Nov 2022 23:36:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01D93C433C1; Fri, 4 Nov 2022 23:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667605001; bh=22T8ApIzd/4Wr/C49UU1NXC4Fpg7XFQ5s94T+J49igo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MMYgUpIu4xmcDoxdp/r1rTSl+kGHZxIXwg0zB3fjuNupncK8Yeu8R5ShGUdDKO/+L 58AwepgEZtcBjRoXziIzPZkqMDTO8tHYKkPZKCWRKOtxMD/a/YE1/yQzwDaF108kB1 /aPKNYF4JAL2/R6JB+sSz33RtaQvQhwgiUyyyPuY= Date: Fri, 4 Nov 2022 16:36:40 -0700 From: Andrew Morton To: Vasily Gorbik Cc: Muchun Song , Muchun Song , Mike Kravetz , Gerald Schaefer , Linux Memory Management List , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h Message-Id: <20221104163640.2057b74c25d6076f64912891@linux-foundation.org> In-Reply-To: References: <71BFC75C-483D-42C0-8248-59FC8DBE148C@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667605002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QuilHsL7SZaLI6I/9kLeHsdX6pB2YA5K0ba/YI1xqGU=; b=roylBgkvgw1E2TuOiR+pJUvP3wVCfsh1sSfWiyTGmbrcALHWefV+LBPPGXKlhOhsoQBsQu luBYAusTC46kc4MAOq9bPt4ia3Q2hqLdCWKAGzqljGVj+UpOtbDRqF42GjRFyF8IZStmDM TLgjUBhFCDFmN4AedMKv8fbTfivibFA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MMYgUpIu; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667605002; a=rsa-sha256; cv=none; b=MIsguWv/1W3sG65zY5okuUc3cloEA6sOjdWPaTRNxwS/5KrsThucLvnEnQnTEROjdf0mBx Fdpd7c55lMfaRXUNuaCp9DiKkUwMsBDFi8wW2vr07Zx4MnyM7N/+Mzdw057wTe7ZY6gP/S EI7N8YzI7U5tvgyIaEUC6MNxYfvfn5I= X-Stat-Signature: ho3zswdf4icfjkj5hedo1y5qiffx33tn X-Rspamd-Queue-Id: D2E05180002 X-Rspamd-Server: rspam06 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MMYgUpIu; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1667605002-854670 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 3 Nov 2022 17:02:02 +0100 Vasily Gorbik wrote: > 42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP") is > just a one liner activating this feature and only present in linux-next > and s390 features branch targeting v6.2. So, if you don't want to have > > Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()") > > fine with me. But then just dropping Fixes tag is probably a better > option. I hope that won't prevent it from going into some v6.1-rcX. > > @Andrew > should I resend? or would you be so kind to drop Fixes tag and add Reviewed-by > without it? Thank you I retained the Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()") and added Muchun's Reviewed-by:, thanks.