From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F685C4332F for ; Thu, 3 Nov 2022 20:47:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ED9B6B0072; Thu, 3 Nov 2022 16:47:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8768B6B0073; Thu, 3 Nov 2022 16:47:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E3D6B0074; Thu, 3 Nov 2022 16:47:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 607866B0072 for ; Thu, 3 Nov 2022 16:47:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2DDC1141169 for ; Thu, 3 Nov 2022 20:47:25 +0000 (UTC) X-FDA: 80093316450.01.CADD26A Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf29.hostedemail.com (Postfix) with ESMTP id AABC3120002 for ; Thu, 3 Nov 2022 20:47:23 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id h14so2782102pjv.4 for ; Thu, 03 Nov 2022 13:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MxS/4UcS9QV06TA42jz+n7cPJ0B1Da1lpvr3ubjc6GY=; b=cuP5UtrVPLmPkgDyIU7nXUWip6wPNwEQX83eaiYzuSaa/NwaBOHxdiCCYvHyd3mrWb UX4IYw78zXIF0mMu0R7qDreIqrr7PvviOTacDCidW9f3UUssGYk9RosDNLvY+hm88Tz8 hEooCKFouHczA6F3wBjXPLYrpYIszUEwnYnlDxkOvhuNi8oE//fz5w1SOEhhUUoWt77E pAHn5L/ZZzWw3HkpcasZr6hnf6O/XMcGhjxvLwJ33vohngsJ1KBKVvIfn+XAYIa1YRVX Vkpw4CNDgLSlpQfjW7+15/HKqs/xOt8+2WdHOo1jGBPReCKhIlOzYbvvyYROh/eydkAD rc0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MxS/4UcS9QV06TA42jz+n7cPJ0B1Da1lpvr3ubjc6GY=; b=HhFYv7RluZpMH7SLP8AN6Y5T+9FhB/yM2wmhC1zZSQScj7rYSbEu5N3anfK9R92Ge/ f5TE1jsoDMRk+ordVsV8KvXiUYKAES/lLYgN6sYaT6lOQDU8e14839PQE6hS3RfkfGJA iRTjtm6KNl1JJr43tMWl5iamKJjBYKMNhnHOXxTaUa/nzlBQq2UxyynAVVMEnIiG7aL2 go7tAfKUArGl4ldjhtD4Ajgnwl7NfT/Y0lbonk3l6sjlfnsu8vNZjJgQHH2FMD0bjR+v Bw858XmPquSV6QQOV+dnTGIRmG7wGMFK62KCSKS6p+5L/bx6qTVzn1xbHKm37EynZRC7 aHIg== X-Gm-Message-State: ACrzQf1Ho8Uls7eyayaekhxB4w+6ZnEqJBmLBOHDg2dJrEkEzWrlZbAi +MMZIjkBgRMaAZ2/oaDlY4zPdg== X-Google-Smtp-Source: AMsMyM5GUtVQUrVsmSVgFmsiPB/ae+Y5AFUcecj0KBZFMpN2UeC1Le+3w3RaW8dan20LGNVVX2XxhA== X-Received: by 2002:a17:90a:5781:b0:20a:9962:bb4a with SMTP id g1-20020a17090a578100b0020a9962bb4amr49118773pji.185.1667508442530; Thu, 03 Nov 2022 13:47:22 -0700 (PDT) Received: from dread.disaster.area (pa49-181-106-210.pa.nsw.optusnet.com.au. [49.181.106.210]) by smtp.gmail.com with ESMTPSA id y12-20020aa78f2c000000b00561b455267fsm1205656pfr.27.2022.11.03.13.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 13:47:22 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1oqh7P-009uXX-4a; Fri, 04 Nov 2022 07:47:19 +1100 Date: Fri, 4 Nov 2022 07:47:19 +1100 From: Dave Chinner To: Vishal Moola Cc: linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 00/23] Convert to filemap_get_folios_tag() Message-ID: <20221103204719.GY2703033@dread.disaster.area> References: <20221102161031.5820-1-vishal.moola@gmail.com> <20221103070807.GX2703033@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=cuP5UtrV; spf=none (imf29.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.216.42) smtp.mailfrom=david@fromorbit.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667508443; a=rsa-sha256; cv=none; b=LwciIUsDHTxkoX01LDxeY5nW8YuP9PAA69e5J5xXGzkZhnk9/V6bokdEn/I2A74uj0X7fq KURBGGMenfr1M9Iw553RiVKIncCz2dPyAIon8WMamhK0kfD1//JeH+Ki+IQdQsw2e1c9rn aJsaecy0tCNdAAtETyo1KDLkqqKbkWU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667508443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MxS/4UcS9QV06TA42jz+n7cPJ0B1Da1lpvr3ubjc6GY=; b=xdTGPBLEh06BrT5WKYijGMDEbZ/WZbkBfjfcBqXSwTrlf/Z7f5A39etpTI+mwVPRaQzB7S OfVg2QPP4LHrWsou+XH1Xur8i3FqvJQ64c2mM4Gu2Fgnjj4ndJzaVNMVLuNdeSHY60SsRL 0sEIny8N5DILQ1+xYMSGKwCEjBkZJNE= X-Stat-Signature: 1d8cb4k7w5d6srgc5gzgc957c64znyiw X-Rspamd-Queue-Id: AABC3120002 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=cuP5UtrV; spf=none (imf29.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.216.42) smtp.mailfrom=david@fromorbit.com; dmarc=none X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1667508443-465064 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 03, 2022 at 09:38:48AM -0700, Vishal Moola wrote: > On Thu, Nov 3, 2022 at 12:08 AM Dave Chinner wrote: > > > > On Wed, Nov 02, 2022 at 09:10:08AM -0700, Vishal Moola (Oracle) wrote: > > > This patch series replaces find_get_pages_range_tag() with > > > filemap_get_folios_tag(). This also allows the removal of multiple > > > calls to compound_head() throughout. > > > It also makes a good chunk of the straightforward conversions to folios, > > > and takes the opportunity to introduce a function that grabs a folio > > > from the pagecache. > > > > > > F2fs and Ceph have quite a lot of work to be done regarding folios, so > > > for now those patches only have the changes necessary for the removal of > > > find_get_pages_range_tag(), and only support folios of size 1 (which is > > > all they use right now anyways). > > > > > > I've run xfstests on btrfs, ext4, f2fs, and nilfs2, but more testing may be > > > beneficial. The page-writeback and filemap changes implicitly work. Testing > > > and review of the other changes (afs, ceph, cifs, gfs2) would be appreciated. > > > > Same question as last time: have you tested this with multipage > > folios enabled? If you haven't tested XFS, then I'm guessing the > > answer is no, and you haven't fixed the bug I pointed out in > > the write_cache_pages() implementation.... > > > > I haven't tested the series with multipage folios or XFS. > > I don't seem to have gotten your earlier comments, and I > can't seem to find them on the mailing lists. Could you > please send them again so I can take a look? They are in the lore -fsdevel archive - no idea why you couldn't find them.... https://lore.kernel.org/linux-fsdevel/20221018210152.GH2703033@dread.disaster.area/ https://lore.kernel.org/linux-fsdevel/20221018214544.GI2703033@dread.disaster.area/ -Dave. -- Dave Chinner david@fromorbit.com