From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21019C433FE for ; Thu, 3 Nov 2022 12:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EC746B0071; Thu, 3 Nov 2022 08:40:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59CD56B0072; Thu, 3 Nov 2022 08:40:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 463ED6B0073; Thu, 3 Nov 2022 08:40:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3408B6B0071 for ; Thu, 3 Nov 2022 08:40:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ED81741040 for ; Thu, 3 Nov 2022 12:40:36 +0000 (UTC) X-FDA: 80092089672.14.661107C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf29.hostedemail.com (Postfix) with ESMTP id 3715A120002 for ; Thu, 3 Nov 2022 12:40:35 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id F40E868AA6; Thu, 3 Nov 2022 13:40:30 +0100 (CET) Date: Thu, 3 Nov 2022 13:40:30 +0100 From: Christoph Hellwig To: Thorsten Leemhuis Cc: Christoph Hellwig , Jens Axboe , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org, "regressions@lists.linux.dev" Subject: Re: [REGESSION] systemd-oomd overreacting due to PSI changes for Btrfs (was: Re: [PATCH 3/5] btrfs: add manual PSI accounting for compressed reads) Message-ID: <20221103124030.GA29839@lst.de> References: <20220915094200.139713-1-hch@lst.de> <20220915094200.139713-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667479236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=THHupytz4opEsoOfC+6bWO5cwe4ljaI9C/6OP6SN5sM=; b=HmIXS2UGg/TZb6pkSSvWzLzDFiHSbAwomPVzhLZBMR7wYs0Q4q3h2pn6/QdQKQn6x7SUTs c6Xouoy/zcJ5tMvhT1+mzaPPYxONxGATrafKnXIcCcbOpjXzON4UiwTJcZIIS2zA19YHYk MIRlw6Y7KjjC1kk4KFA1jSYJr+Voe94= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667479236; a=rsa-sha256; cv=none; b=wAZ2q+fZDVRBq9myWSd7XW2P/WXLm/0DrE4pW/PSmxWwZBsyhyjvMIMch69NNpD4k21vLW UtgaDkVIm62wTjrxAMbBkq23Fj8ph9tJdcFFYjvlNXN6ZUsZMkDTYb23UqsmcSETmLJ6uX QVXti2c2g/aRow336GbcKKRzht066Ks= Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3715A120002 X-Stat-Signature: d673a3aa16om1jjpqdfdty8xq8dwppxj X-HE-Tag: 1667479235-484156 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 03, 2022 at 11:46:52AM +0100, Thorsten Leemhuis wrote: > It seems this patch makes systemd-oomd overreact on my day-to-day > machine and aggressively kill applications. I'm not the only one that > noticed such a behavior with 6.1 pre-releases: > https://bugzilla.redhat.com/show_bug.cgi?id=2133829 > https://bugzilla.redhat.com/show_bug.cgi?id=2134971 > > I think I have a pretty reliable way to trigger the issue that involves > starting the apps that I normally use and a VM that I occasionally use, > which up to now never resulted in such a behaviour. > > On master as of today (8e5423e991e8) I can trigger the problem within a > minute or two. But I fail to trigger it with v6.0.6 or when I revert > 4088a47e78f9 ("btrfs: add manual PSI accounting for compressed reads"). > And yes, I use btrfs with compression for / and /home/. So, I did in fact not want to include this patch because it is a little iffy and includes PSI accounting for reads where btrfs just does aggresive readaround for compression, but Johannes asked for it to be added. I'd be perfectly fine with just reverting it.