From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48370C4332F for ; Thu, 3 Nov 2022 07:08:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADD338E0002; Thu, 3 Nov 2022 03:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8E958E0001; Thu, 3 Nov 2022 03:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 954BB8E0002; Thu, 3 Nov 2022 03:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 81AD68E0001 for ; Thu, 3 Nov 2022 03:08:14 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 12D681C6B11 for ; Thu, 3 Nov 2022 07:08:14 +0000 (UTC) X-FDA: 80091252108.05.75A8890 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf30.hostedemail.com (Postfix) with ESMTP id 8860C80002 for ; Thu, 3 Nov 2022 07:08:13 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so4395424pji.1 for ; Thu, 03 Nov 2022 00:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UCGx+I//h802HOEchXeQ4l9Uif7TwqahE8c/QVCmorA=; b=Qo0pCYgx3Qq1H7gtsjTo9ahtaWGAPbAqpUUP7w83R+hioFcvnb/Vum4t6njrIqmCbQ 9oglIFHFznb8HWDOhJ8VqGBZno5DvMa/i9rWqzvIS3F1Qe6lSOVMpDruWh58G2ZJDVRR +irGuRxsC3szEMLHnbBdSVWy+8gAtIi3/dsdlKShS4dWGsFcwevGYm9bbQNs76cqEy+l a7aTzEEQgFxLLhP1XqsxI1o93xRoLeyOkLszg3jyihUg4tqsI4qRKCp463KDJruVxcER uahSco4O56I/ia+N+pdnGxKbS5y4Jn6JIOipSvnU+FLMXl5F+IFO/pgiKOzrTt8rdoYE jcgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UCGx+I//h802HOEchXeQ4l9Uif7TwqahE8c/QVCmorA=; b=rStp5SkPp7rmWYM4oqxqxt0fowGY8twEbTjv40J9QYWiMJv+h94lOdEkq/DoTUdj/N D+oL9kf6PAnXHdOgD+WPshhGmhgF9iaPnDHvAF85pyIMxUJqdipuG/RkkGtKk3c18C8b d0UHA91wjwVZfCfo6rUQ3EPMmJCPiQ1W5Qrzl4dT7v1a09YCFawwdv+uXa3lhqaWSU3r YXdjtma0GEXdc4C0BToyyd3JUsxs/+yl0c2cZGtHDsMpIgn4bt2LxGnQJYutOwbXSCgp 5O4S6ZV5RnZAM7IcIO1eiQzcpRJvaKrYZCKXGjGpArSLnLDPF3sUoEywcAaLpvDUdlMD d+IA== X-Gm-Message-State: ACrzQf2dnR3bE/rLFcEOZMnfaUR+rueBrme/I3kA5GTw86kjoduYUPJZ c6rDBv/daE/5Zys+b0Y+4Lrahw== X-Google-Smtp-Source: AMsMyM7EbTGuTativfwuYw+G5QrvaMpsSoYHAtMTN9boWfI/C7HSKjfDJIybcNCOqaRH/jY3hHhBSg== X-Received: by 2002:a17:902:ed8e:b0:187:1c78:80c2 with SMTP id e14-20020a170902ed8e00b001871c7880c2mr21606400plj.38.1667459292279; Thu, 03 Nov 2022 00:08:12 -0700 (PDT) Received: from dread.disaster.area (pa49-181-106-210.pa.nsw.optusnet.com.au. [49.181.106.210]) by smtp.gmail.com with ESMTPSA id s7-20020a170902988700b00179e1f08634sm9438901plp.222.2022.11.03.00.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 00:08:11 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1oqUKd-009gYz-VX; Thu, 03 Nov 2022 18:08:08 +1100 Date: Thu, 3 Nov 2022 18:08:07 +1100 From: Dave Chinner To: "Vishal Moola (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 00/23] Convert to filemap_get_folios_tag() Message-ID: <20221103070807.GX2703033@dread.disaster.area> References: <20221102161031.5820-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221102161031.5820-1-vishal.moola@gmail.com> ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Qo0pCYgx; spf=none (imf30.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.216.54) smtp.mailfrom=david@fromorbit.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667459293; a=rsa-sha256; cv=none; b=XM0Ui2p//yhA8RECP+pD8y+OxfL2SobgAicMIQMmk3vyS95RMrsW4npDbD4r7vGawMTiGu hVYA/ULqKbp5LzzLeLxfz64couZU/S8g3ejqc61AHSHonp55D91n0iNl0+jK9kF9uTTZob nOlf259j7Ai+s0DiCAJhFI5lNIXJqq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667459293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UCGx+I//h802HOEchXeQ4l9Uif7TwqahE8c/QVCmorA=; b=CGkGOpE2UB7l+S175XCAs1Wa8E90099eW2zB8JfnjupiwQ/fAIbM5sXeWrfQfTqQ+XxRfZ BPS1F3aIA2eP7MsxCnk/mjkYQGuNMShPKW3GbBuTodseoef8MHltszNa0bNBBWYF4zOlEo ZGVwzAC8ETojFJrX9jGjWAxQbuWy2A8= X-Stat-Signature: mrjsxxowc6mexmcuxuw7xhaj66u6hda5 X-Rspamd-Queue-Id: 8860C80002 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Qo0pCYgx; spf=none (imf30.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.216.54) smtp.mailfrom=david@fromorbit.com; dmarc=none X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1667459293-994660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 02, 2022 at 09:10:08AM -0700, Vishal Moola (Oracle) wrote: > This patch series replaces find_get_pages_range_tag() with > filemap_get_folios_tag(). This also allows the removal of multiple > calls to compound_head() throughout. > It also makes a good chunk of the straightforward conversions to folios, > and takes the opportunity to introduce a function that grabs a folio > from the pagecache. > > F2fs and Ceph have quite a lot of work to be done regarding folios, so > for now those patches only have the changes necessary for the removal of > find_get_pages_range_tag(), and only support folios of size 1 (which is > all they use right now anyways). > > I've run xfstests on btrfs, ext4, f2fs, and nilfs2, but more testing may be > beneficial. The page-writeback and filemap changes implicitly work. Testing > and review of the other changes (afs, ceph, cifs, gfs2) would be appreciated. Same question as last time: have you tested this with multipage folios enabled? If you haven't tested XFS, then I'm guessing the answer is no, and you haven't fixed the bug I pointed out in the write_cache_pages() implementation.... -Dave. -- Dave Chinner david@fromorbit.com