From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC474C4332F for ; Thu, 3 Nov 2022 04:02:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32D188E0002; Thu, 3 Nov 2022 00:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3418E0001; Thu, 3 Nov 2022 00:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12DCC8E0002; Thu, 3 Nov 2022 00:02:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2C468E0001 for ; Thu, 3 Nov 2022 00:02:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CBD97A01AA for ; Thu, 3 Nov 2022 04:02:49 +0000 (UTC) X-FDA: 80090784858.21.B29C207 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf19.hostedemail.com (Postfix) with ESMTP id 83B121A0002 for ; Thu, 3 Nov 2022 04:02:49 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id hh9so557866qtb.13 for ; Wed, 02 Nov 2022 21:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MvcYwR6HhsBfz3fA/MgVdCJOD7H5kWqLZ0DNtCa1bXs=; b=pJMpfNEJrA2CehpIjUwinR7p2WMsuy+2j6hvBReGR3hhzY7N3p5Vj+V9thtKvgM/PE JwtVGBfxbYR55hhNq49gughCUSLgl7BFwlDuoJhceurGmmwU6vaJu0Wp6WmpiUFjjr6r lDlbRZbs+1b16KlbO1dczoZ+dDdzG2Hep3k1AOgwsBThlhrrmcftKSQ7z/Y341oJZqhM S60UBqksAqmkDbIjbbsY62DLAi7nsUN12R2Ew2wZMhwPGuP9Qquv2m/omaBYrgHW/LBx pGnzMW2l6+64EcqGJzR7O/akTJeWBAiWdmQpCHTz3ZeFAz82s2kJwE+Oy4hjY+zNg66n Vgnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MvcYwR6HhsBfz3fA/MgVdCJOD7H5kWqLZ0DNtCa1bXs=; b=uvZ1uDKDX7FKo4N1R9gbF7mwKvVbdLQ1N0hVeOXbg7uNeRxcKsrSEJASY2Sp3iQLFb NYLzTixSig/jQka/vULge2j4VKMc9GFs3fOR9RmmfELHRDOjQhTcdxOITFWFvT7oAZhp e88PjK6S9qpvTALcmhFoX2QD12jVtOM6d2ElS6M3adrTnv5WfQuTvLjsX+H4uaVkPQgP eUGFemks7soe9lc9szm79nMsqlCgtpb2HbwZ24lX95AGMAe+FFeHHATRFQC47O0d3VBa //E4nQi7dyRREsz4emJjwdp95wX5oBz7ao/SUT1Q7EBrgMC50lc7c4uv0JnurbvKSa3Y BrQA== X-Gm-Message-State: ACrzQf39pfwa5HqCwKGu+XeGT9AwuAxxZXRhLXZIm/GKRqNJ3O3QKqv1 efuOC/R7tEfRcrSz0vJVBto= X-Google-Smtp-Source: AMsMyM7LE3kqx0uYAGU6Wd/tJyG5u8djFzJr0qQYhFh2OZMFogfuPXy7jiE0/KgrPaHdnwqyuXmBzw== X-Received: by 2002:ac8:5c4a:0:b0:39c:f9dd:ee3d with SMTP id j10-20020ac85c4a000000b0039cf9ddee3dmr22712405qtj.443.1667448168740; Wed, 02 Nov 2022 21:02:48 -0700 (PDT) Received: from sophie ([45.134.142.212]) by smtp.gmail.com with ESMTPSA id r5-20020a05620a298500b006eeb25369e9sm5870636qkp.25.2022.11.02.21.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 21:02:48 -0700 (PDT) Date: Wed, 2 Nov 2022 23:02:47 -0500 From: Rebecca Mckeever To: David Hildenbrand Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] memblock tests: introduce range tests for memblock_alloc_exact_nid_raw Message-ID: <20221103040247.GA10663@sophie> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667448169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvcYwR6HhsBfz3fA/MgVdCJOD7H5kWqLZ0DNtCa1bXs=; b=KQRQqRdqLD2/cPk4AwYSoykXshc4RIwC+IybupWr7lYcYRGNE0nQjSXH7zDTF0nUaNl9EY EXIh2dB0POBbRSsnh636YNJr4lIPfrzIxqR6hHEUCVVkvnwaVqmpQrYzA3KjdPll8Xjjd0 zq265lD+4fa7A0hKyeJercs49lFMI6E= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pJMpfNEJ; spf=pass (imf19.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667448169; a=rsa-sha256; cv=none; b=HG0lmaebIMxspiaLdpJDEUHLQhWuvd1wytL/yEb5pQomROwhrqSRB+pS28iJVpNl2gTdKO UVrk27In4VI5YQS5cLqI8Y2b8bbeyesN4ASzgs2e+xRHj2yzzM2SFdagLQ2Ki+IKh+n39z cR0dYNiC+w7LpzeVoaupp5alyElvzng= X-Stat-Signature: qro57oyjy3xnyy5t447boyobpb6gcpr7 X-Rspamd-Queue-Id: 83B121A0002 X-Rspamd-Server: rspam06 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pJMpfNEJ; spf=pass (imf19.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1667448169-239902 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 31, 2022 at 11:28:15AM +0100, David Hildenbrand wrote: > On 19.10.22 20:34, Rebecca Mckeever wrote: > > Add TEST_F_EXACT flag, which specifies that tests should run > > memblock_alloc_exact_nid_raw(). Introduce range tests for > > memblock_alloc_exact_nid_raw() by using the TEST_F_EXACT flag to run the > > range tests in alloc_nid_api.c, since memblock_alloc_exact_nid_raw() and > > memblock_alloc_try_nid_raw() behave the same way when nid = NUMA_NO_NODE. > > > > Rename tests and other functions in alloc_nid_api.c by removing "_try". > > Since the test names will be displayed in verbose output, they need to > > be general enough to refer to any of the memblock functions that the > > tests may run. > > > > Signed-off-by: Rebecca Mckeever > > [...] > > > diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c > > index 2c2d60f4e3e3..df8e7e038cab 100644 > > --- a/tools/testing/memblock/tests/alloc_nid_api.c > > +++ b/tools/testing/memblock/tests/alloc_nid_api.c > > @@ -18,18 +18,27 @@ static const unsigned int node_fractions[] = { > > 625, /* 1/16 */ > > }; > > -static inline const char * const get_memblock_alloc_try_nid_name(int flags) > > +static inline const char * const get_memblock_alloc_nid_name(int flags) > > { > > + if (flags & TEST_F_EXACT) > > + return "memblock_alloc_exact_nid_raw"; > > if (flags & TEST_F_RAW) > > return "memblock_alloc_try_nid_raw"; > > return "memblock_alloc_try_nid"; > > } > > -static inline void *run_memblock_alloc_try_nid(phys_addr_t size, > > - phys_addr_t align, > > - phys_addr_t min_addr, > > - phys_addr_t max_addr, int nid) > > +static inline void *run_memblock_alloc_nid(phys_addr_t size, > > + phys_addr_t align, > > + phys_addr_t min_addr, > > + phys_addr_t max_addr, int nid) > > { > > I think we want to assert here that TEST_F_EXACT without TEST_F_RAW is not > set --- because there is no API to support it. > Good idea. Thanks for pointing this out. I will add an assert. > Apart from that > > Acked-by: David Hildenbrand > > > Thanks! > > -- > Thanks, > > David / dhildenb > Thanks, Rebecca