From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99026C4332F for ; Wed, 2 Nov 2022 20:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7D238E0002; Wed, 2 Nov 2022 16:05:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D188E0001; Wed, 2 Nov 2022 16:05:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF5048E0002; Wed, 2 Nov 2022 16:05:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C03C08E0001 for ; Wed, 2 Nov 2022 16:05:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 86D58161162 for ; Wed, 2 Nov 2022 20:05:42 +0000 (UTC) X-FDA: 80089582524.19.7CCDC28 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 06B6F160006 for ; Wed, 2 Nov 2022 20:05:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1D324B82456; Wed, 2 Nov 2022 20:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AF43C433B5; Wed, 2 Nov 2022 20:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667419537; bh=xEV5xpbDuWSJh2LBaLO8ieVEq+GdSGwnx2U960MGeKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W63auvdtfqK0AB3MzIdoV6cdyUNN8RU+3vabwhIQA7SWaV8tHObr5D6IptqREl7nk VNPaG7iAVDPtoxZSLG3No2/2ArwFcBGsI3fvSIz8o3iDi+yfmpO7Vbcn2+lCwc8F37 yrwP5T5TPGVDmXC5XHx/Ug7kjP97AF8Ll4Lq7Ssg= Date: Wed, 2 Nov 2022 13:05:36 -0700 From: Andrew Morton To: Pankaj Gupta Cc: , , , Subject: Re: [PATCH] mm/memremap.c: map FS_DAX device memory as decrypted Message-Id: <20221102130536.96c487d341544b7482eed038@linux-foundation.org> In-Reply-To: <20221102160728.3184016-1-pankaj.gupta@amd.com> References: <20221102160728.3184016-1-pankaj.gupta@amd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667419541; a=rsa-sha256; cv=none; b=Mrc3931654iw41iSDPvLsxHobmvLeABCKb4OEY4o0qpBtBENP+HbyQYl7KFafXGiRTA4Dt N293nyqHlbBaYLol+cERApSnMCE7Hv4wu+Y0lZILmNSh0DO+85C+vk7KGVIB30j5PtCfFB XgSH1JiA5TBCMOmv88Uz1GXBuq3rnbY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=W63auvdt; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667419541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aJqBamUKNOwr6y5/YefZHgngdeEFwhd1jjW7I0tRTpM=; b=a5C1ldIpXHzm1ffaYabass6pm2H7VBher8gTSzy1yZ4QdsbCZD8KJxf/uY213NMu9R82PQ 69LjNJmZODWwvfLFTGVfnd5VuiYyXZ8kj6BvME9Y6zA4mD5Ao1jGJQAWdptbaX7JKDnjHZ Q1wy1ZWvxWsFD5wArCuJzwHuTFFcS3o= X-Stat-Signature: 1nfrb3px88jszwdm8zb4eq68brde63c5 X-Rspamd-Queue-Id: 06B6F160006 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=W63auvdt; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1667419540-85337 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Nov 2022 11:07:28 -0500 Pankaj Gupta wrote: > virtio_pmem use devm_memremap_pages() to map the device memory. > By default this memory is mapped as encrypted with SEV. Guest > reboot changes the current encryption key and guest no longer > properly decrypts the FSDAX device meta data. > > Mark the corresponding device memory region for FSDAX devices > (mapped with memremap_pages) as decrypted to retain the persistent > memory property. > > ... > > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -335,6 +335,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > + params.pgprot = pgprot_decrypted(params.pgprot); > break; > case MEMORY_DEVICE_GENERIC: > break; Should this be backported into earlier kernels? Is b7b3c01b19159 a suitable Fixes: target?