linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Pankaj Gupta <pankaj.gupta@amd.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<dan.j.williams@intel.com>, <thomas.lendacky@amd.com>
Subject: Re: [PATCH] mm/memremap.c: map FS_DAX device memory as decrypted
Date: Wed, 2 Nov 2022 13:05:36 -0700	[thread overview]
Message-ID: <20221102130536.96c487d341544b7482eed038@linux-foundation.org> (raw)
In-Reply-To: <20221102160728.3184016-1-pankaj.gupta@amd.com>

On Wed, 2 Nov 2022 11:07:28 -0500 Pankaj Gupta <pankaj.gupta@amd.com> wrote:

> virtio_pmem use devm_memremap_pages() to map the device memory.
> By default this memory is mapped as encrypted with SEV. Guest
> reboot changes the current encryption key and guest no longer
> properly decrypts the FSDAX device meta data.
> 
> Mark the corresponding device memory region for FSDAX devices
> (mapped with memremap_pages) as decrypted to retain the persistent
> memory property.
> 
> ...
>
> --- a/mm/memremap.c
> +++ b/mm/memremap.c
> @@ -335,6 +335,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
>  			WARN(1, "File system DAX not supported\n");
>  			return ERR_PTR(-EINVAL);
>  		}
> +		params.pgprot = pgprot_decrypted(params.pgprot);
>  		break;
>  	case MEMORY_DEVICE_GENERIC:
>  		break;

Should this be backported into earlier kernels?

Is b7b3c01b19159 a suitable Fixes: target?


  parent reply	other threads:[~2022-11-02 20:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 16:07 Pankaj Gupta
2022-11-02 19:03 ` Gupta, Pankaj
2022-11-02 20:05 ` Andrew Morton [this message]
2022-11-03  7:55   ` Gupta, Pankaj
2022-11-04 23:32     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102130536.96c487d341544b7482eed038@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pankaj.gupta@amd.com \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox