From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D887DC4321E for ; Tue, 1 Nov 2022 20:18:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6503D6B0071; Tue, 1 Nov 2022 16:18:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D7796B0073; Tue, 1 Nov 2022 16:18:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49F7F6B0074; Tue, 1 Nov 2022 16:18:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3C3FC6B0071 for ; Tue, 1 Nov 2022 16:18:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 127E0A01F3 for ; Tue, 1 Nov 2022 20:18:32 +0000 (UTC) X-FDA: 80085986064.28.AA5ABA1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id A015C1C000A for ; Tue, 1 Nov 2022 20:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=eYNCdZwcLjMI7GB0XNxQj7wwgiWVGtsawTmuXyBbwQo=; b=YjQXs8pdzIbVgYkxU5Agq6SABo iipCwLn1LTtgEz0L2m8wVsDtvCL/Q7wYoW4QOAwrlVwj/SI09BYG8W6M5MoUoouo8JC/m0ZkOW0Wp e3yHvlCxxCRvZQKrChkYAk2xEdljpEp5vfeNuh5gIZTV+9HUwbzBVG6T7LAbY1SGRGQmfCZpOyUPB 3SjK4vzjxbg6RKdK8zyAYDK3W8EfKLMhSJYgBf6W3Yr/dNmB0a3WJYrtOOZbg7rHP66aaXlqRiVOZ 0rG2/To1/jCCGQPyG15Ve0dhuez88XeiacTiLXeUK+mfEfK0NtFG/MxcMp+vrt9yXpiNpDyjMBL5D GkZyrKew==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1opxiP-004uUU-Mv; Tue, 01 Nov 2022 20:18:29 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Uladzislau Rezki , David Howells , Dave Chinner , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Ira Weiny , "Fabio M. De Francesco" , Luis Chamberlain Subject: [PATCH v2 1/2] vmalloc: Factor vmap_alloc() out of vm_map_ram() Date: Tue, 1 Nov 2022 20:18:27 +0000 Message-Id: <20221101201828.1170455-2-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20221101201828.1170455-1-willy@infradead.org> References: <20221101201828.1170455-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667333911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eYNCdZwcLjMI7GB0XNxQj7wwgiWVGtsawTmuXyBbwQo=; b=gGXteCFkKLwWSKT+DKDpSXSrKLOsl8y3GSWFgDhQmrudP1+FokcmX99V+SVGJVBCnDwT6d DRXqRi1CFYdgGMkVTnDQpRXLuuey9YalWUduUwd6Eb2/ObsYwvPCbrd76jLq7u1lFr5uPI TDbXA0/g+DR7sU8ZwVARS63xy3DK6gg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YjQXs8pd; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667333911; a=rsa-sha256; cv=none; b=F0chE3yfdsqdxwmme3OguQoqEnLjudkosGjC3i5hcuGlQByP37UmZiVVj7lDXOMKivCGDf ptjenEHoDbpCc0qUeJr8tCC1itpHsAYN2UK9MC6RMfYjOgns3uY2DxjXZqffd0iRDV/x0l /XZdszQIcwa/40oVSxwo8gGzHJjNv28= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YjQXs8pd; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A015C1C000A X-Stat-Signature: b5erg31ytmyiu7cf3op8drbe14q1ph4j X-HE-Tag: 1667333910-582447 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Introduce vmap_alloc() to simply get the address space. This allows for code sharing in the next patch. Suggested-by: Uladzislau Rezki Signed-off-by: Matthew Wilcox (Oracle) --- mm/vmalloc.c | 41 +++++++++++++++++++++++------------------ 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index ccaa461998f3..dcab1d3cf185 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2230,6 +2230,27 @@ void vm_unmap_ram(const void *mem, unsigned int count) } EXPORT_SYMBOL(vm_unmap_ram); +static void *vmap_alloc(size_t size, int node) +{ + void *mem; + + if (likely(size <= (VMAP_MAX_ALLOC * PAGE_SIZE))) { + mem = vb_alloc(size, GFP_KERNEL); + if (IS_ERR(mem)) + mem = NULL; + } else { + struct vmap_area *va; + va = alloc_vmap_area(size, PAGE_SIZE, + VMALLOC_START, VMALLOC_END, node, GFP_KERNEL); + if (IS_ERR(va)) + mem = NULL; + else + mem = (void *)va->va_start; + } + + return mem; +} + /** * vm_map_ram - map pages linearly into kernel virtual address (vmalloc space) * @pages: an array of pointers to the pages to be mapped @@ -2247,24 +2268,8 @@ EXPORT_SYMBOL(vm_unmap_ram); void *vm_map_ram(struct page **pages, unsigned int count, int node) { unsigned long size = (unsigned long)count << PAGE_SHIFT; - unsigned long addr; - void *mem; - - if (likely(count <= VMAP_MAX_ALLOC)) { - mem = vb_alloc(size, GFP_KERNEL); - if (IS_ERR(mem)) - return NULL; - addr = (unsigned long)mem; - } else { - struct vmap_area *va; - va = alloc_vmap_area(size, PAGE_SIZE, - VMALLOC_START, VMALLOC_END, node, GFP_KERNEL); - if (IS_ERR(va)) - return NULL; - - addr = va->va_start; - mem = (void *)addr; - } + void *mem = vmap_alloc(size, node); + unsigned long addr = (unsigned long)mem; if (vmap_pages_range(addr, addr + size, PAGE_KERNEL, pages, PAGE_SHIFT) < 0) { -- 2.35.1