From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD58C4321E for ; Wed, 2 Nov 2022 02:45:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A03A6B0071; Tue, 1 Nov 2022 22:45:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54FEF6B0072; Tue, 1 Nov 2022 22:45:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F9E96B0073; Tue, 1 Nov 2022 22:45:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 29DAB6B0071 for ; Tue, 1 Nov 2022 22:45:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 067D0C106F for ; Wed, 2 Nov 2022 02:45:46 +0000 (UTC) X-FDA: 80086961892.09.5EB5C83 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf03.hostedemail.com (Postfix) with ESMTP id 8B1C520005 for ; Wed, 2 Nov 2022 02:45:45 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so2420819pjh.1 for ; Tue, 01 Nov 2022 19:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U3z7CAwRrbhiy3Fh87yqUT0bKa1tvVxCGpJDy2Nva08=; b=D9k+K8+zb1Hw1FZdM5Q4KowBW3VDqCAe+J9yQLJGJEIxDte78hlq5eeQNbWl0nT1qs Rg4pv+E29J1DJzwg/nZuydW0KGgko2YCgDP2MvNEYH+d//aYbE7X9FNY9PA50QfYZZzk VS1TtxLpZhLHALz8nbknl1NTioYIqTJ4/Gq6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U3z7CAwRrbhiy3Fh87yqUT0bKa1tvVxCGpJDy2Nva08=; b=JrFx1RtYH+jpBWTyAtJLEcPG6yUzmeKxnBZfRYxYKD1BzK37HOCwE2s7bGiivx82c9 ilIHm6Qs1AYDyXOCbXla9gFeSxZhNT11cB8ep+O96UufBCAa3CdYwnAgF0WF/J9ucklp XzPl9EWbuzSLhDkJd8WL24CwCPjvF3AFEcB/BRBnWo2TgwftgcMOAr/4GAtcWsDLgxC0 zGUJ8B30x9JYm9x19PqTM5AvWrQAZ1A115GieXewy7exHJDtJzxCAi59kSMKz3ZDAnGV GlhXTFa+r5iwbaSTDrkjgvLFPZ7FTJzubkDpGZ/NFgfErBTjqA6YERYCYfYlOyaK4LwE sYjQ== X-Gm-Message-State: ACrzQf1ruf0hrzkdDKFWwHHW8np3ZcWonItUcBQfoYwyL4YBrCg/t4Ls 2CqK5BLGIKOXm4WwZjz26C/Ytw== X-Google-Smtp-Source: AMsMyM4ChAOWz5lSp4choDZEK9kgzF2daJaX4Pp4EqxUxMKFLQ8UVWsyw490lLgFVqRXKtCwd4d8gw== X-Received: by 2002:a17:90b:4c12:b0:213:d3e3:ba4c with SMTP id na18-20020a17090b4c1200b00213d3e3ba4cmr15519784pjb.22.1667357144287; Tue, 01 Nov 2022 19:45:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id np3-20020a17090b4c4300b00208c58d5a0esm226382pjb.40.2022.11.01.19.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 19:45:43 -0700 (PDT) Date: Tue, 1 Nov 2022 19:45:42 -0700 From: Kees Cook To: Jeff Xu Cc: jeffxu@google.com, skhan@linuxfoundation.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mnissler@chromium.org, jannh@google.com, linux-hardening@vger.kernel.org, Aleksa Sarai , dev@opencontainers.org, Christian Brauner Subject: Re: [PATCH v2 0/5] mm/memfd: MFD_NOEXEC for memfd_create Message-ID: <202211011933.DD0979338@keescook> References: <20220805222126.142525-1-jeffxu@google.com> <202208081018.9C782F184C@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667357145; a=rsa-sha256; cv=none; b=l15hAUBwily8D29rpAVtCJp1rmmx6yMrVeID+OLvX91EkuKFM/1pi5KoJ4BeiQXSt3Fypa KwRnLPnZtnFNftVySiU266FX/DJX0Q3cI7Vl3EzPcA7rR0P48i/00BzLtwIbnlFZhyAo/q G0pfjafYHeQ8TWnB2sXDL8YrCqdlWVc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=D9k+K8+z; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.47 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667357145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U3z7CAwRrbhiy3Fh87yqUT0bKa1tvVxCGpJDy2Nva08=; b=COYKMmQ2ET9ZwRLLfRbltu/+mHw1ea+JThhGnX3oWYuNzkDUUwdITK5A8PhW/WxC4IvR4Z KkAPvPKPmsD24JX+OWaScZQb6Q8WyP/hfGpwbE9PiZ0ug9pQJHv0LeOp3shwgn6fU2TOnP vHA5D3gJRU+zntqArTpbKZrGeVf1KxI= X-Stat-Signature: rifgjitp9b3drpoxd9hge9ozx4ddtdam X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: 8B1C520005 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=D9k+K8+z; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.47 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1667357145-164864 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 04:14:39PM -0700, Jeff Xu wrote: > Sorry for the long overdue reply. No worries! I am a fan of thread necromancy. :) > [...] > 1> memfd_create: > Add two flags: > #define MFD_EXEC 0x0008 > #define MFD_NOEXEC_SEAL 0x0010 > This lets application to set executable bit explicitly. > (If application set both, it will be rejected) So no MFD_NOEXEC without seal? (I'm fine with that.) > 2> For old application that doesn't set executable bit: > Add a pid name-spaced sysctl.kernel.pid_mfd_noexec, with: bikeshed: vm.memfd_noexec (doesn't belong in "kernel", and seems better suited to "vm" than "fs") > value = 0: Default_EXEC > Honor MFD_EXEC and MFD_NOEXEC_SEAL > When none is set, will fall back to original behavior (EXEC) Yeah. Rephrasing for myself to understand more clearly: "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL act like MFD_EXEC was set." > value = 1: Default_NOEXEC_SEAL > Honor MFD_EXEC and MFD_NOEXEC_SEAL > When none is set, will default to MFD_NOEXEC_SEAL "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL act like MFD_NOEXEC_SEAL was set." Also, I think there should be a pr_warn_ratelimited() when memfd_create() is used without either bit, so that there is some pressure to please adjust their API calls to explicitly set a bit. > 3> Add a pid name-spaced sysctl kernel.pid_mfd_noexec_enforced: with: > value = 0: default, not enforced. > value = 1: enforce NOEXEC_SEAL (overwrite everything) How about making this just mode "value 2" for the first sysctl? "memfd_create() without MFD_NOEXEC_SEAL will be rejected." -Kees -- Kees Cook