From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A2EC433FE for ; Tue, 1 Nov 2022 22:47:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B10CA6B0071; Tue, 1 Nov 2022 18:47:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABFAE6B0072; Tue, 1 Nov 2022 18:47:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988096B0073; Tue, 1 Nov 2022 18:47:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F0CB6B0071 for ; Tue, 1 Nov 2022 18:47:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5012E1201FA for ; Tue, 1 Nov 2022 22:47:23 +0000 (UTC) X-FDA: 80086361166.23.906A0F2 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf03.hostedemail.com (Postfix) with ESMTP id DCC2620005 for ; Tue, 1 Nov 2022 22:47:22 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id io19so14907393plb.8 for ; Tue, 01 Nov 2022 15:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ksO/1o1BhIzE4SsfOIUs7zxu3Erb/eLFTep4apIgRAw=; b=D20PIvH1BHu5njgDPzCx60DympS69ZgpbmXpXi+nQlXKBq8o17e0F/beS8GRCG5Lao R0kW2cV5tSEJTOMwlSLwrtG7lTWZFPWjR5EzEtNtLfeOny32RBuHDoadgl/C8ZMtK8ml 40VmpnsWC2oUgisaDM/Wv7rrYrP3zekplVk68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ksO/1o1BhIzE4SsfOIUs7zxu3Erb/eLFTep4apIgRAw=; b=vDZm1pTG2u2hoPcMYLDzB5PV+1BGs+Cgy1ejGa+1BBun3Lz5FPzAxxgA2z/jHfL0DU MdrIhcLUV1Gkgjbsfjjs8vQxe9R0fIYb/7+WqSYRwB2TJGQrybAG7ofbBG3BEmaTp0RX ACmrOcqTRzdK1iK0SjMvDevF7QCxO70ExVCeeKsUoBMTmqC56QDCPIkBySoI7bnPTEmq WFh/CXVW99Tsq2VbLPOH8E6BfQaLqhb0ki06yu/aTbWE56VLv7a9atdZNu2BqUQdPAFZ I6qApWBAWCk9Cv9LoIFNF7IIfcoMYnpOIR7mMEsFPOTRrPEPvb5oEg1q9goDk7b8g9w7 N5ng== X-Gm-Message-State: ACrzQf3zFcL4Kd+VQfk/FLVM12xAwuzqYWdJki1hIMgKHiXjWyJ50g9i 2azVVqItBpSH83szlFjfJHnaUEGZYiWang== X-Google-Smtp-Source: AMsMyM5u3nuWvNn0ECPBs1EaQXXyP85rU7+pHq9IxMRQruYWSIVY8JDFNZv4t+RXdDCYleU33I356w== X-Received: by 2002:a17:903:289:b0:186:a8a8:e99a with SMTP id j9-20020a170903028900b00186a8a8e99amr21389283plr.104.1667342841715; Tue, 01 Nov 2022 15:47:21 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m8-20020a1709026bc800b00177f4ef7970sm6859012plt.11.2022.11.01.15.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 15:47:21 -0700 (PDT) Date: Tue, 1 Nov 2022 15:47:20 -0700 From: Kees Cook To: Christophe JAILLET Cc: Pasha Tatashin , Andrew Morton , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 21/30] mm: Use kstrtobool() instead of strtobool() Message-ID: <202211011543.20ACBF9@keescook> References: <03f9401a6c8b87a1c786a2138d16b048f8d0eb53.1667336095.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03f9401a6c8b87a1c786a2138d16b048f8d0eb53.1667336095.git.christophe.jaillet@wanadoo.fr> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667342843; a=rsa-sha256; cv=none; b=pDs2sRyHX1px6KnZ07dL/xhn/i1dCUap6UDn4y9ipBuyyoBAeS6KuKav0rCGmbG/JIcwn6 McXs6AYtADjc2dXgWiqz1DdBsrIhEeZperFdu405cR2NMHPbE1kKsnRquVUkF/TcG6Wxu+ 0pPCxg5mQlIQ7Km4IKQjS22LhH5fs14= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=D20PIvH1; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667342843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ksO/1o1BhIzE4SsfOIUs7zxu3Erb/eLFTep4apIgRAw=; b=2VARJ9tRK36qsgzcHS+nJScDgroJypEmXtEfHEjMzqsXqdcRkg5Dtn3wiurc7k7L/LTKUX FuN8xAy2YlfEVM0RbDZ6KJxm43k/FP7oOs0xzZMrgZGMDPavR9XrxKUi16o5nO4C0Ko4sS FoTSla1o/N3v6/4eDIWEgaphPpxtKmk= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=D20PIvH1; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Stat-Signature: 51xipncxn6egiw1najdccscs1bmn5wii X-Rspamd-Queue-Id: DCC2620005 X-HE-Tag: 1667342842-409673 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000207, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 01, 2022 at 10:14:09PM +0100, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file () > > Signed-off-by: Christophe JAILLET > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ This seems in keeping with the removal of the simple_*str*() helpers: https://docs.kernel.org/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Reviewed-by: Kees Cook -- Kees Cook