From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3514FFA3743 for ; Tue, 1 Nov 2022 11:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 803D96B0072; Tue, 1 Nov 2022 07:26:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B4C06B0073; Tue, 1 Nov 2022 07:26:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CA9C6B0074; Tue, 1 Nov 2022 07:26:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FF6A6B0072 for ; Tue, 1 Nov 2022 07:26:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B2DF14102C for ; Tue, 1 Nov 2022 11:26:48 +0000 (UTC) X-FDA: 80084646096.01.B5E68BD Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id 4E9384001D for ; Tue, 1 Nov 2022 11:26:46 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 0EB276732D; Tue, 1 Nov 2022 12:26:43 +0100 (CET) Date: Tue, 1 Nov 2022 12:26:42 +0100 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, dave.hansen@intel.com, mcgrof@kernel.org Subject: Re: [PATCH bpf-next v1 RESEND 0/5] vmalloc_exec for modules and BPF programs Message-ID: <20221101112642.GB14379@lst.de> References: <20221031222541.1773452-1-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031222541.1773452-1-song@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667302007; a=rsa-sha256; cv=none; b=WoydiCXmQUK5c8kTdzq7h5jkJQxANthgBWJIvFJ0jOaiKYdTfxXWLcJ0xjQA3JNOt+gxE7 ztQU4SI0tlSSRaoVAZVmFTkLNaxVTR8OU7pqJUlsxGuz9hCdnKKLgP1o/ap4PVdav2hM30 3R6231u5vT+tk9xpGViACy26GEe6uqY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667302007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4CHNTe98kp9+dk/G3sU17NPHAfWZ0wwkmGhZM++CQh0=; b=8DjRHdE2VAoy5g7bn7k+8kDTcpqPJdO0wQh+V81hOJaph4ieSCvRAbuc+nfEb4q38LgWjh 3Pdg95e8v++f6esyqqWhwWf9sz7/dpIHNXifDfS251cAj7zs39nJSCK4OgVZVpZfPw71mz 5aswiq9S1EcMy08VmgaqRxM4BceRYaY= X-Stat-Signature: pk9epd9dm959me1c8y79f61o6y8rndpw X-Rspamd-Queue-Id: 4E9384001D X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam09 X-HE-Tag: 1667302006-159279 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 31, 2022 at 03:25:36PM -0700, Song Liu wrote: > This set enables bpf programs and bpf dispatchers to share huge pages with > new API: > vmalloc_exec() > vfree_exec() > vcopy_exec() Maybe it's just me, but I don't like the names very much. They imply a slight extension to the vmalloc API, but while they use the vmalloc mechanisms internally, the API is actually quite different. So why not something like: execmem_alloc execmem_free execmem_fill or execmem_set or copy_to_execmem ?