From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFB8C433FE for ; Tue, 1 Nov 2022 17:15:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85E486B0071; Tue, 1 Nov 2022 13:15:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80E456B0073; Tue, 1 Nov 2022 13:15:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FCB16B0074; Tue, 1 Nov 2022 13:15:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 630896B0071 for ; Tue, 1 Nov 2022 13:15:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 27DCB141071 for ; Tue, 1 Nov 2022 17:15:49 +0000 (UTC) X-FDA: 80085525618.05.B339AF7 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf06.hostedemail.com (Postfix) with ESMTP id 77918180046 for ; Tue, 1 Nov 2022 17:15:47 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id j12so14169381plj.5 for ; Tue, 01 Nov 2022 10:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4RX4xzZ+ZS1XzIPjQGu76TBFL1oLPQqm0GGT/7lwwNk=; b=CfQYbO2XcQYTIBqqHWVcDSlWzGkOF+pA/awkac95JhmVeZnAwuLGDYm4hRMEFgO4Mu P1lcp0nnzddNd/16ztZQ6XGfGXv8SMPdJ2y54UZH4v6Mt4DnRH+wx0jkrpyHs3+N50K1 RwAB4tAmlQN8wAlzoCWEeCMcSy+Q8CMTxsI3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4RX4xzZ+ZS1XzIPjQGu76TBFL1oLPQqm0GGT/7lwwNk=; b=tpoJ47oM4pTZBA4LosGlwI/LLi/VTuoIfAzxsnSAXvpkTKnyet0IQPYH3ZiEGLp2/c HTL7GZxLSNsD2b/7h+6QUFMs5oPb8EfTDXNgO9yJWGRBhuMTotpSk+PllxCk9nkkA7hn QxL9qNheto4Gg6HEmIEckadWU19ldSJXoVZRtCloaOrQupM3yIQ50MKAOr2OlTTFHJPC 08B4LGt+Hhcn3srdbH0teQMugHpvW+9mtAVSpMlOeoJOzc/ju9XGAMOrYmPVnXP3BEks pHoQRQ7gSzqNGYrtlCFOtfS9GrGTVCO3g95QraPApVDLob1PsmelFxDrbrJhbXdchuqH 2z6w== X-Gm-Message-State: ACrzQf32llqTChJfJeK+dCpmtWi4+3zNrWeLtaFgxCRKdsJyRDI1yFDJ TK1NECYBiauUrBUenSaSACyNWA== X-Google-Smtp-Source: AMsMyM58fyxdnpL447tR6e947sOuZc70DvaZmHDir1HHTRUYdrq81zgSXsRo4ceaLysD6zxQYaXXLQ== X-Received: by 2002:a17:902:f809:b0:186:e8c3:bb45 with SMTP id ix9-20020a170902f80900b00186e8c3bb45mr3676558plb.150.1667322946401; Tue, 01 Nov 2022 10:15:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a12-20020aa794ac000000b0056bee23a80bsm6764429pfl.137.2022.11.01.10.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 10:15:45 -0700 (PDT) Date: Tue, 1 Nov 2022 10:15:45 -0700 From: Kees Cook To: Vlastimil Babka Cc: Anders Roxell , kernel test robot , Andrew Morton , David Rientjes , Marco Elver , Vincenzo Frascino , linux-mm@kvack.org, Andrey Konovalov , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v4] mempool: Do not use ksize() for poisoning Message-ID: <202211011014.02F2559@keescook> References: <20221028154823.you.615-kees@kernel.org> <20221031105514.GB69385@mutt> <13c4bd6e-09d3-efce-43a5-5a99be8bc96b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13c4bd6e-09d3-efce-43a5-5a99be8bc96b@suse.cz> ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=CfQYbO2X; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667322947; a=rsa-sha256; cv=none; b=XpaMObmmEOHV6WD/6eFhP1dcQdpkYT3Dp5iimK5py4dUrrE6baO0LTuvOMr3I995oCBgiw Xtzga0zVJLr+UG8WlCBCnBq0+OZeQiXysFjLqN6G2PJKk/gON0m++pXFg/qDUp9OA3+vUv R/65Kaew8fPP8IIrCQYNgiY21yG7tjo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667322947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4RX4xzZ+ZS1XzIPjQGu76TBFL1oLPQqm0GGT/7lwwNk=; b=sUn+M48b/I1023oY4UQm2NvbR32jC3Sor9hsidFBcesySo3pJLClIBSemyITcoub7vEqZj E05nO6Ybo04cbjkoitP8KXhQUvG8gWEw5F2oqMbYfz/uqTGUJdSPsrdNRys0ZiaZOPvR40 T3+6DAvz8qgnob0EEBOhKC1vGkKLaoc= X-Stat-Signature: jy8jbbrho6648ga1zey3grtzkzgscg73 X-Rspamd-Queue-Id: 77918180046 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=CfQYbO2X; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam01 X-HE-Tag: 1667322947-181323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 31, 2022 at 04:00:25PM +0100, Vlastimil Babka wrote: > From a4a5a40852723dfadb2429bee1d5e1f9d3b75f39 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Mon, 31 Oct 2022 15:55:47 +0100 > Subject: [PATCH] mempool: Do not use ksize() for poisoning-fix > > For slab mempools (not kmalloc), pool_data is not object size, but a > kmem_cache pointer; we need to extract the size via kmem_cache_size(). > > Reported-by: Anders Roxell > Link: https://lore.kernel.org/all/20221031105514.GB69385@mutt/ > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-lkp/202210312110.1fe5d224-oliver.sang@intel.com > Signed-off-by: Vlastimil Babka Reviewed-by: Kees Cook Thanks again for fixing this. I don't see it in -next yet? Should I resend this directly, or how would be best to land it? -Kees -- Kees Cook