From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC45FA3740 for ; Mon, 31 Oct 2022 05:00:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 809426B0071; Mon, 31 Oct 2022 01:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B7356B0073; Mon, 31 Oct 2022 01:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67EC48E0001; Mon, 31 Oct 2022 01:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 42C586B0071 for ; Mon, 31 Oct 2022 01:00:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EAEB840B3B for ; Mon, 31 Oct 2022 05:00:10 +0000 (UTC) X-FDA: 80080042980.22.80EE0DA Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf16.hostedemail.com (Postfix) with ESMTP id 7F528180036 for ; Mon, 31 Oct 2022 05:00:10 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id l2so2153991qtq.11 for ; Sun, 30 Oct 2022 22:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D8eqTjguB2oGWax96LvgoPSRaOwaKV0lZXOHpXf5yIg=; b=Z6EhDUqtSdLCakfj7nxJOpCMa+1G5l/MyNyE0qyPeeiowPd9u630XyOtzdq8chD9ET kwmeUmMnSPk3CDcLZQw2FPiRv/kKDGrTHfdcb3VWFCj0ryYhQtQLYGR12sLAbIR2Mz8l VFpbYOQjuDpIvpo26V2On1F9aBsWArWM9FVKlULWhJyJ3NV37u8aB+YN5xYULxLeoob5 iHD/4IUbrAB+6ktwshX00ubfpuXBzNEXM5wEYCttkTnIGE37CO/AdI0eiJex8AzuZzVp c7yNWgMnRSa3qLxJZR2OSXwBWcv7T7TeYrTNbnK/z+iyuzPm8/psIoMJgsVEq3fxMJHw vtbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D8eqTjguB2oGWax96LvgoPSRaOwaKV0lZXOHpXf5yIg=; b=oto+mz0AUPlQng7C/WitBb6LLjX+t6f+/Dnr8THJ7u8oN3sn22BNE8BXF452790+PT 9ytXFoeYR0AT/AchQ7FOgQsmRY7ni4lUZAbQilWReCeCvZDxIQcKa3hMQE0yAsD5crH7 womb9dzrDYgyxohzo43EPsbzqpEIuk3995DMWwUYcbfQZgjb3Gwhq0kDxlUYjPIzZIYM HDmJD4IgIzYWj6p5OUlS3XMCWidlpVIrpoogt90IZJz+S18wrGVrDNU9cAy4EFOCt7Ac 7VAvXLsPeDSYOxa9GMw/gUkAsN0PEM1bkJNsHGTzDnkDsJrZ0i9MgiS5aGLhFA/DuVBl ykbw== X-Gm-Message-State: ACrzQf1uXsgg/v1tCFxZq6PiQFM0ko/3P3i9ysMLrHVTT/Wqpb0AGSOB zp6J/1WUyPymuNwTBiWXOhM= X-Google-Smtp-Source: AMsMyM6Oa/2+1fSB4rp+Qz0DQWpeITC7sckuY6ko39FxNxORU6ssA6V4udQB9PwW1K3vG1W87T/gtg== X-Received: by 2002:ac8:5f54:0:b0:39c:ce86:65dd with SMTP id y20-20020ac85f54000000b0039cce8665ddmr8873496qta.285.1667192409390; Sun, 30 Oct 2022 22:00:09 -0700 (PDT) Received: from sophie ([185.156.46.162]) by smtp.gmail.com with ESMTPSA id e5-20020ac84905000000b003a5092ed8cdsm3196150qtq.9.2022.10.30.22.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 22:00:09 -0700 (PDT) Date: Mon, 31 Oct 2022 00:00:06 -0500 From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand Subject: Re: [PATCH v3 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw Message-ID: <20221031050006.GA15612@sophie> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667192410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D8eqTjguB2oGWax96LvgoPSRaOwaKV0lZXOHpXf5yIg=; b=QavnlBsrAMVd81XRy/YrHALcaM6KalrIi9hQkWmybgJuO1sKZxEQqFV1R4jWDWDyRYvKF/ mnHcwGPe7qJ8EfArfRK0k/cL5ufHDmbkBXKIVL6To2yOvOfb+HgmgtYpZOkUNvlk3EjPG3 xBFhJoAAw0bBtj7G5W0PRPbw/u5Qtcg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Z6EhDUqt; spf=pass (imf16.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.194 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667192410; a=rsa-sha256; cv=none; b=WZ0miApVBkMEPJZXNvIG/2bLLf81jo6KVfp6XpfoROKeTg8761lQoK92kAqDrqqv8ubNUF lfhwuWRDdzJjSw+PpVwzDfogKD4IBLSNtfI7PMONTX1ysIC+3EAsSAeWxRh/cnq0HeT8Rb q2MZ+iE32ckhkFT4K6kFCvHpOcadDX4= X-Stat-Signature: ne4yup7c5gwjrj6ju61tyuz94akj8edf X-Rspamd-Queue-Id: 7F528180036 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Z6EhDUqt; spf=pass (imf16.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.194 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-HE-Tag: 1667192410-956214 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000624, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, I noticed that the memblock tree has been updated since I sent this patch set. Do you want me to send an updated patch set applied on top of the current tree? On Wed, Oct 19, 2022 at 01:34:07PM -0500, Rebecca Mckeever wrote: > These patches add tests for memblock_alloc_exact_nid_raw(). There are two > sets of tests: range tests and NUMA tests. The range tests use a normal > (i.e., UMA) simulated physical memory and set the nid to NUMA_NO_NODE. The > NUMA tests use a simulated physical memory that is set up with multiple > NUMA nodes. Additionally, most of the NUMA tests set nid != NUMA_NO_NODE. > > For the range tests, the TEST_F_EXACT flag is used to run the same set of > range tests used for memblock_alloc_try_nid_raw(). The NUMA tests have the > same setup as the corresponding test for memblock_alloc_try_nid_raw(), but > several of the memblock_alloc_exact_nid_raw() tests fail to allocate > memory in setups where the memblock_alloc_try_nid_raw() test would > allocate memory. Also, some memblock_alloc_exact_nid_raw() tests drop the > lower limit of the requested range in order to allocate within the > requested node, but the same setup in a memblock_alloc_try_nid_raw() test > allocates within the requested range. > > --- > Changelog > > v1 -> v2 > PATCH 0: > - Add missing memblock_alloc_exact_nid_raw to subject line > > v2 -> v3 > Based on feedback from David Hildenbrand: > PATCH 1: > - alloc_nid_api.c, alloc_nid_api.h, common.h: > + Add TEST_F_EXACT flag so that tests in alloc_nid_api.c can be run > with that flag to test memblock_alloc_exact_nid_raw() > - alloc_exact_nid_api.c: > + Update to run range tests in alloc_nid_api.c with TEST_F_EXACT flag > instead of using a separate set of tests > - alloc_nid_api.c: > + Rename tests and other functions by removing "_try" so that the > function names are general enough to refer to any of the > memblock_alloc_*nid*() functions of the memblock API > --- > > Rebecca Mckeever (5): > memblock tests: introduce range tests for memblock_alloc_exact_nid_raw > memblock tests: add top-down NUMA tests for > memblock_alloc_exact_nid_raw > memblock tests: add bottom-up NUMA tests for > memblock_alloc_exact_nid_raw > memblock tests: add generic NUMA tests for > memblock_alloc_exact_nid_raw > memblock tests: remove completed TODO item > > tools/testing/memblock/Makefile | 2 +- > tools/testing/memblock/TODO | 7 +- > tools/testing/memblock/main.c | 2 + > .../memblock/tests/alloc_exact_nid_api.c | 1113 +++++++++++++++++ > .../memblock/tests/alloc_exact_nid_api.h | 25 + > tools/testing/memblock/tests/alloc_nid_api.c | 542 ++++---- > tools/testing/memblock/tests/alloc_nid_api.h | 1 + > tools/testing/memblock/tests/common.h | 2 + > 8 files changed, 1425 insertions(+), 269 deletions(-) > create mode 100644 tools/testing/memblock/tests/alloc_exact_nid_api.c > create mode 100644 tools/testing/memblock/tests/alloc_exact_nid_api.h > > -- > 2.25.1 > Thanks, Rebecca