linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2] maple_tree: Reorganize testing to restore module testing
Date: Fri, 28 Oct 2022 22:55:00 +0000	[thread overview]
Message-ID: <20221028225453.m5vgj7tkpxt6or7c@revolver> (raw)
In-Reply-To: <20221028145841.4b0eaa422cbc775c3c074962@linux-foundation.org>

* Andrew Morton <akpm@linux-foundation.org> [221028 17:58]:
> On Fri, 28 Oct 2022 18:04:30 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
> 
> > Along the development cycle, the testing code support for
> > module/in-kernel compiles was removed.  Restore this functionality by
> > moving any internal API tests to the userspace side, as well as
> > threading tests.  Fix the lockdep issues and add a way to reduce memory
> > usage so the tests can complete with KASAN + memleak detection.  Make
> > the tests work on 32 bit hosts where possible and detect 32 bit hosts in
> > the radix test suite.
> 
> My x86_64 allmodconfig failed with
> 
> ERROR: modpost: "mas_find_rev" [lib/test_maple_tree.ko] undefined!
> 
> so I did this:
> 
> --- a/lib/maple_tree.c~maple_tree-reorganize-testing-to-restore-module-testing-fix
> +++ a/lib/maple_tree.c
> @@ -6059,7 +6059,7 @@ void *mas_find_rev(struct ma_state *mas,
>  	/* Retries on dead nodes handled by mas_next_entry */
>  	return mas_prev_entry(mas, min);
>  }
> -EXPORT_SYMBOL_GPL(mas_find);
> +EXPORT_SYMBOL_GPL(mas_find_rev);
>  
>  /**
>   * mas_erase() - Find the range in which index resides and erase the entire
> _
> 

Thanks.  It looks like I missed this in my squashing of commits.

Sorry about that.
Liam


      reply	other threads:[~2022-10-28 22:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 18:04 Liam Howlett
2022-10-28 21:58 ` Andrew Morton
2022-10-28 22:55   ` Liam Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028225453.m5vgj7tkpxt6or7c@revolver \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox