From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2819ECAAA1 for ; Fri, 28 Oct 2022 21:58:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FFBF6B0072; Fri, 28 Oct 2022 17:58:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B01A6B0073; Fri, 28 Oct 2022 17:58:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 077EB6B0074; Fri, 28 Oct 2022 17:58:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EABF26B0072 for ; Fri, 28 Oct 2022 17:58:47 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B0995160659 for ; Fri, 28 Oct 2022 21:58:47 +0000 (UTC) X-FDA: 80071723494.11.23A5CC8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 4533110003D for ; Fri, 28 Oct 2022 21:58:46 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 92261B82AD4; Fri, 28 Oct 2022 21:58:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D567CC433C1; Fri, 28 Oct 2022 21:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666994323; bh=qoD2Yq4J1KRgQuRQsI1oHZEyZ2p5PGAeR1n7zGQja70=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fl50cHEzQCOTlJOXfJEapMQiXQQnmXF0EP5jPdVsaNeWpxBLRGhPnGgQtRF/XovTW zrB0sW445qu2JQdY0BzQumCu9P0GHGzYoDaISRWMr5hDKYyeJ2EFmgU5hJSLU0Hj6H CJaw8VtdwFqWX89CQ4g9HiUUKUW8mfvCN8azV+dg= Date: Fri, 28 Oct 2022 14:58:41 -0700 From: Andrew Morton To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven Subject: Re: [PATCH v2] maple_tree: Reorganize testing to restore module testing Message-Id: <20221028145841.4b0eaa422cbc775c3c074962@linux-foundation.org> In-Reply-To: <20221028180415.3074673-1-Liam.Howlett@oracle.com> References: <20221028180415.3074673-1-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Fl50cHEz; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666994326; a=rsa-sha256; cv=none; b=ENYFWSVHyoo1giw3dNdOiH6YOchfCwmYWDXvJlnk09tbEMHMKxq+tUB/gV3jFWGJEDfdLB UYlaEMukh8R6tCj/8H++X5Bk5X8Q1sHZ50/QXYLAJlyBeKehzAJmuLyYy0kcmzbSqcYX6o aFx2s5nt24umtz8lJmk6e8uFulTy/WY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666994326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NikqaYZ8+ESK+XcArc81Y50aHXNg+H0GasdVbpL5GxQ=; b=OvB/iZz3xoUD5r1/p4T/QRFjqWnkkK4Twf2KPWzpueRd9oADJeQd9sZkpQ4Jg2sj8n1UFu HBpzPutGKJuHMpExQbxP63S2+7acFNk9I5PaCa9FZXeHEc8N0uO7QDDfoJ5di8JS1X+Yu7 I7uR+u6FezbjlpkrJgrP/YVX2cDYfnY= X-Rspam-User: X-Rspamd-Queue-Id: 4533110003D Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Fl50cHEz; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: cjxnqubijcbnner4rirsfh3uckqcznwy X-Rspamd-Server: rspam10 X-HE-Tag: 1666994326-824318 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 28 Oct 2022 18:04:30 +0000 Liam Howlett wrote: > Along the development cycle, the testing code support for > module/in-kernel compiles was removed. Restore this functionality by > moving any internal API tests to the userspace side, as well as > threading tests. Fix the lockdep issues and add a way to reduce memory > usage so the tests can complete with KASAN + memleak detection. Make > the tests work on 32 bit hosts where possible and detect 32 bit hosts in > the radix test suite. My x86_64 allmodconfig failed with ERROR: modpost: "mas_find_rev" [lib/test_maple_tree.ko] undefined! so I did this: --- a/lib/maple_tree.c~maple_tree-reorganize-testing-to-restore-module-testing-fix +++ a/lib/maple_tree.c @@ -6059,7 +6059,7 @@ void *mas_find_rev(struct ma_state *mas, /* Retries on dead nodes handled by mas_next_entry */ return mas_prev_entry(mas, min); } -EXPORT_SYMBOL_GPL(mas_find); +EXPORT_SYMBOL_GPL(mas_find_rev); /** * mas_erase() - Find the range in which index resides and erase the entire _