From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27DFDC38A02 for ; Fri, 28 Oct 2022 17:45:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5DEF6B0071; Fri, 28 Oct 2022 13:45:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E6576B0073; Fri, 28 Oct 2022 13:45:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 886B06B0074; Fri, 28 Oct 2022 13:45:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7529C6B0071 for ; Fri, 28 Oct 2022 13:45:25 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2D818140EED for ; Fri, 28 Oct 2022 17:45:25 +0000 (UTC) X-FDA: 80071085010.24.1DE7B68 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf22.hostedemail.com (Postfix) with ESMTP id 9E12CC0027 for ; Fri, 28 Oct 2022 17:45:24 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so8230300pjh.1 for ; Fri, 28 Oct 2022 10:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sq+4+K8W7qz9CqdPYKGdGPJUiIj89nYCMsj4hrq+PXE=; b=Qk8LjvSnKQ+nIz7iqqSWHFadvUV7NzJ6KPQ1r3p/lUiuWBKuG4/YdTl8U2LDkwWWQX ZTdEZPBQv33zkr7IS54F9tB+LCHpxqUrERaqe7kqttssTQmiUT8DJ26n3dEcMAIJPPmw 2uAFLRTwFf+091cseHU88g11bR5cZGAOVEfyg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sq+4+K8W7qz9CqdPYKGdGPJUiIj89nYCMsj4hrq+PXE=; b=vnaefwfehHOiSQ7EwNhJSYelgwL8FatAPIVobGeZ5Bxwp1jpUgGzeAPAK66G3uA4aP F1ECMoVtaHmIx+sMv1x58hhE5iwEgWwrEshfAeyrkoqqIcBL0FAKi8M95hKMZozDhoR1 Kd0AM5E1isl/N/MM5K8sMIzYmBdKs+HhqcD6AMBUBxWZK12gmr+U7JmoEFlQO+W1rvmv lpDWUweJ6Ho2e/Ht7YRERe0jVrIgh/m9ZRN7H47kQSDgTqqxJmFTdv6eTfOY1wmcEQ/b xZ3Nnz6u/LKurmRJ7SGC5y0akUWsuqfya3P6EZ72uW71VxXNe8YP4FN/aOPap6xL16B5 Obgg== X-Gm-Message-State: ACrzQf0A+oZQW+aiG8T6r7VvzK5QZetFPBEBHH3UM0AfgaE3UrtvEz43 OUt32lbUbixERP+lZMv9gQCicw== X-Google-Smtp-Source: AMsMyM5xMG3TVG7u/78SN5J7HmVo4/yAWKlp64gxV3zMh7Cx/cWT4TaKn1MTwMTg+/YXh4xKD0Cd8A== X-Received: by 2002:a17:90a:cf82:b0:20b:3525:81ec with SMTP id i2-20020a17090acf8200b0020b352581ecmr452552pju.42.1666979123537; Fri, 28 Oct 2022 10:45:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u8-20020a17090341c800b001866a019010sm3368538ple.97.2022.10.28.10.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 10:45:22 -0700 (PDT) Date: Fri, 28 Oct 2022 10:45:21 -0700 From: Kees Cook To: Joey Gouly Cc: Catalin Marinas , Andrew Morton , Lennart Poettering , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , Alexander Viro , Szabolcs Nagy , Mark Brown , Jeremy Linton , Topi Miettinen , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-abi-devel@lists.sourceforge.net, nd@arm.com, shuah@kernel.org Subject: Re: [PATCH v1 2/2] kselftest: vm: add tests for memory-deny-write-execute Message-ID: <202210281043.DFC05DEF@keescook> References: <20221026150457.36957-1-joey.gouly@arm.com> <20221026150457.36957-3-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026150457.36957-3-joey.gouly@arm.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666979124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sq+4+K8W7qz9CqdPYKGdGPJUiIj89nYCMsj4hrq+PXE=; b=RzpdVB6G1EKJycIJSvdm70Wx6RYQi9A0Kxf4llZHW6rP84dIPhTLUt787XDJrzVsLSlGR2 k+J50wpeMnwkDRrQkyh9dLmtIfIg7dQzb4cJW6Isopxz6C1iMUbYnaElAihRMN4idX4UkQ m5U4Wqe1HkpgQt0g3uvZij7CpKMlw0g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Qk8LjvSn; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666979124; a=rsa-sha256; cv=none; b=uy42BNaMNZr9CIq3pPkjZbIGC4itjidnhhLLwYtdGFQN6JgE6zQWG6JsfaxtjNb62J6Kgo yoYfe/lQKfrnaliocppSakdBPoz1NfJDpd1apq7zbSrcpFMhXggQN41w5xfoNy7e8hr39B 0VSFtUKJdLxoEPgNQr1J2C0m5lAMPhE= X-Stat-Signature: oz4ju4etkaqdt9hmkb5s9x66b89inaze X-Rspamd-Queue-Id: 9E12CC0027 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Qk8LjvSn; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam04 X-HE-Tag: 1666979124-753863 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000106, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 26, 2022 at 04:04:57PM +0100, Joey Gouly wrote: > +#include "../kselftest.h" I recommend using kselftest_harness.h instead; it provides much of the infrastructure that is open-coded here. But yes, testing is good; thank you! :) -- Kees Cook