From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E433C38A02 for ; Fri, 28 Oct 2022 06:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E31D66B0072; Fri, 28 Oct 2022 02:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE2BA6B0073; Fri, 28 Oct 2022 02:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAA066B0074; Fri, 28 Oct 2022 02:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B6A9A6B0072 for ; Fri, 28 Oct 2022 02:17:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7A3D7A015C for ; Fri, 28 Oct 2022 06:17:14 +0000 (UTC) X-FDA: 80069350788.08.A2F0613 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf14.hostedemail.com (Postfix) with ESMTP id 8995C100005 for ; Fri, 28 Oct 2022 06:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666937833; x=1698473833; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=dF/aWwaNQggwj6gD+KJTCT5Ni9qMvVF3l+TfbYoad8o=; b=SNir5NgW96RKchFndo3ftPBYoxuK5WzrOGTkfHBzGrZRpSgIEv4yW9ja /loW/pEVHgjhKdPO7eG9J+3aefso1OtIx1tl9YHfDpdZSh9IuaJAqOyFY lZTfpQzyHqErq3cPd5y1QLV4oybYYQh8GMSSb454nimNpeDkgETV6NtKb AQk2yrjP48LnviCC6oBwkk0BeB6dA+zzspL/HlElEHbnVwZ5PP5vB6M5H ySEdtY9fe8DpfPqd7epoVXGuIQNqje0g6GQa11z8RM9qiYbeZ0pQMyUIK CPPaOHppzLMOUNvCIyGXQacbEBrlUQEelBiJ9JmpnoBWw5W6ffJz/iNMI A==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="306030192" X-IronPort-AV: E=Sophos;i="5.95,220,1661842800"; d="scan'208";a="306030192" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 23:17:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="627427865" X-IronPort-AV: E=Sophos;i="5.95,220,1661842800"; d="scan'208";a="627427865" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga007.jf.intel.com with ESMTP; 27 Oct 2022 23:17:01 -0700 Date: Fri, 28 Oct 2022 14:12:32 +0800 From: Chao Peng To: Isaku Yamahata Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, Muchun Song , wei.w.wang@intel.com Subject: Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory Message-ID: <20221028061232.GA3885130@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221025151344.3784230-1-chao.p.peng@linux.intel.com> <20221025151344.3784230-2-chao.p.peng@linux.intel.com> <20221026173145.GA3819453@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026173145.GA3819453@ls.amr.corp.intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666937834; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nnAFcJO44+dZiAxeUiBgMtIx3YHW5uxdHSYzrsmbVO8=; b=DXJ8eObz/b2/PdsF2zbyYJTF4S9HWhNFaej2MoCn4jHXByY43igB9pcQCzYCfDuwTWcERU WNLMAmEsQHf/c9rSuMGvEHhraXJ5sMffnENVGkNr6Qa8xDm31Wg/E2DssrNp7EgQGAF+AX SZQhuPa3k6At1dmejDFxB91BLlWMdGA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=SNir5NgW; spf=none (imf14.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666937834; a=rsa-sha256; cv=none; b=z8czkafNH0p+Kvf/uUXY6Od9MkfJx6wo7NntbXDS4W/0lZf6c5WOGSLac1ukqSJJAnNrah ZeDAqhko03APPFkKa1FNtx8DEwXcsPN4FEmJu006Z75Dvqm4iEr2C9deabbKYS24tlVGaR sdasL43iZoChTWackez63zgM+uP4nxY= X-Stat-Signature: 11tqe8e1xp37p48t55rto3p1soyw1j8w X-Rspamd-Queue-Id: 8995C100005 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=SNir5NgW; spf=none (imf14.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspamd-Server: rspam04 X-HE-Tag: 1666937833-921680 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 26, 2022 at 10:31:45AM -0700, Isaku Yamahata wrote: > On Tue, Oct 25, 2022 at 11:13:37PM +0800, > Chao Peng wrote: > > > +int restrictedmem_get_page(struct file *file, pgoff_t offset, > > + struct page **pagep, int *order) > > +{ > > + struct restrictedmem_data *data = file->f_mapping->private_data; > > + struct file *memfd = data->memfd; > > + struct page *page; > > + int ret; > > + > > + ret = shmem_getpage(file_inode(memfd), offset, &page, SGP_WRITE); > > shmem_getpage() was removed. > https://lkml.kernel.org/r/20220902194653.1739778-34-willy@infradead.org Thanks for pointing out. My current base(kvm/queue) has not included this change yet so still use shmem_getpage(). Chao > > I needed the following fix to compile. > > thanks, > > diff --git a/mm/restrictedmem.c b/mm/restrictedmem.c > index e5bf8907e0f8..4694dd5609d6 100644 > --- a/mm/restrictedmem.c > +++ b/mm/restrictedmem.c > @@ -231,13 +231,15 @@ int restrictedmem_get_page(struct file *file, pgoff_t offset, > { > struct restrictedmem_data *data = file->f_mapping->private_data; > struct file *memfd = data->memfd; > + struct folio *folio = NULL; > struct page *page; > int ret; > > - ret = shmem_getpage(file_inode(memfd), offset, &page, SGP_WRITE); > + ret = shmem_get_folio(file_inode(memfd), offset, &folio, SGP_WRITE); > if (ret) > return ret; > > + page = folio_file_page(folio, offset); > *pagep = page; > if (order) > *order = thp_order(compound_head(page)); > -- > Isaku Yamahata