From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1633FA3744 for ; Thu, 27 Oct 2022 13:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECCEB8E0002; Thu, 27 Oct 2022 09:51:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7E008E0001; Thu, 27 Oct 2022 09:51:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1DDA8E0002; Thu, 27 Oct 2022 09:51:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C00C48E0001 for ; Thu, 27 Oct 2022 09:51:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B8461610B1 for ; Thu, 27 Oct 2022 13:51:44 +0000 (UTC) X-FDA: 80066867328.23.EA9A36E Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by imf08.hostedemail.com (Postfix) with ESMTP id D68FA160015 for ; Thu, 27 Oct 2022 13:51:43 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 2CED12B06761; Thu, 27 Oct 2022 09:51:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 27 Oct 2022 09:51:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1666878698; x= 1666885898; bh=BSp3Kt1CP/UIPrkqEaKO1IGC4x0aoj/K3CvNuObJG+4=; b=V u4h04XPewPJOObdRSiXlmHjStO2q1ZlSAemu2uiCbBiMPFj+1IJOKTamvgHn97xo Yxt1Htb8K3hW8FSlkWWD/f2l+s7HAsGKklkT6Gd5dfmf0ZLHrd8ua3KhOa4Fibh/ KyKhwea2NRtfRpEuqQJpn6jOSaN4grRV0Cx1PEF3l0Ga08Z/SWRkHuCtVbl8S9CW /v/VMcy1h3Bwe467PG8e7SzgNTvNEqhLut7YzNjiUSkC5ADly0ap02zmtATPezj/ K4qV3Wy6uN3KHKtPPfuOHaSllNYE/dHCEg0Yc6Oba/tFGf1SOxZVycdZ+u25hPrP cXSuZpORjee4ewRmYt8+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666878698; x= 1666885898; bh=BSp3Kt1CP/UIPrkqEaKO1IGC4x0aoj/K3CvNuObJG+4=; b=E f4Wyv318BAPYiYC2TH+RSfT5kKjAWOJCnL0DpP3z7oekGSg9v70Nt6riKLR2Mrf7 3XJJT7mF9gUJJJBrE6WgV+W4iNbi6NnHJwB8neypu7ZC1/fMUTcqf6K3c69lz0x1 Cwy/YA8TP1vkDErjSD7Kl3+cXExfbCs6V/uoRqL4ecJOuUmOt7qRSRQ31hOcj8Lv rRGgg1BXa26G65fvu/wzn7BCHgoWRsk679fPx4oe5jEbVtZdxl9IMXjYEQROE5Es /hHCpkkAdjH9f4Soo4FbACoUJsQB0s8z6bGA1POFSrieLSzqYQadTtrG4lDTTxC6 wQs0LgraFwj/yGfzSKjlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeggdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtugfgjgesthektddttddtjeenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefgjeeikefffeefvedugfdtkedvhfdttdeifeev tdehgefgjeffleelgffggfdvkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Oct 2022 09:51:37 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id AA1A2104B71; Thu, 27 Oct 2022 16:51:34 +0300 (+03) Date: Thu, 27 Oct 2022 16:51:34 +0300 From: "Kirill A. Shutemov" To: "Huang, Kai" Cc: "Li, Xiaoyao" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Hansen, Dave" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Williams, Dan J" Subject: Re: [PATCH v6 01/21] x86/tdx: Use enum to define page level of TDX supported page sizes Message-ID: <20221027135134.ya62y6lg2kh4yujb@box.shutemov.name> References: <8a5b40d43f8b993a48b99d6647b16a82b433627c.1666824663.git.kai.huang@intel.com> <80e8111b-76a2-4999-782b-fdd4b9f425fa@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666878704; a=rsa-sha256; cv=none; b=cLNxUuelFr50RIaVwjOvtXaUF/vqhqWGmUfCMKPPPu9j5No/d7hCe4JZ4V3MNGVE+qMboz fCla4kFGgjjofiije+ZvcYworMsysRy4vbTsrotxteXHpxAwBpveJ6A2OgfRL9w/GZOA+m /iVO9SNMPmZGkgm6Tb99vilVgPgJa50= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="V u4h04X"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="E f4Wyv3"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.17 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666878704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BSp3Kt1CP/UIPrkqEaKO1IGC4x0aoj/K3CvNuObJG+4=; b=S+1OlxufI1G6qH/IDvjbK9nkJMFh91LrrDcfLEB8XnSzN9lya3n1aELakYOC6OzrkJsWks znl1aFXt4TOme//pSyvUSebs4FlGkAVHm6r8snTqvXiJ4edPWuZF+qaCMzeVRqhhnj5wUU l3vVchfVVJWoC1XfF3yQA3lqWMC4mW8= X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="V u4h04X"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="E f4Wyv3"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.17 as permitted sender) smtp.mailfrom=kirill@shutemov.name X-Rspamd-Server: rspam11 X-Stat-Signature: jp49b5q8h63wihdwommbw8htey3frmtx X-Rspamd-Queue-Id: D68FA160015 X-HE-Tag: 1666878703-389082 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 27, 2022 at 08:42:16AM +0000, Huang, Kai wrote: > On Thu, 2022-10-27 at 15:08 +0800, Li, Xiaoyao wrote: > > > @@ -663,27 +662,16 @@ static bool try_accept_one(phys_addr_t *start, > > > unsigned long len, > > >     if (len < accept_size) > > >     return false; > > >    > > > + /* TDX only supports 4K/2M/1G page sizes */ > > > > yes, a page can be mapped as 1G size to TD via secure/shared EPT. But > > for this particular TDX_ACCEPT_PAGE case, it only supports 4K and 2M > > currently, which is defined in TDX module spec. > > I checked the TDX module public spec, and it appears you are right. But I am > not sure whether it will be changed in the future? The spec says: Level of the Secure EPT entry that maps the private page to be accepted: either 0 (4KB) or 1 (2MB) – see 20.5.1 Yes, it is about 4k and 2M, but it also refers 20.5.1, which lists sizes up to 16PB. Ultimately, it does not matter: if TDX module doesn't support the size or cannot accept the memory for other reason guest kernel will fallback to smaller size. -- Kiryl Shutsemau / Kirill A. Shutemov