From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF0A8C38A2D for ; Wed, 26 Oct 2022 17:31:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CBD38E0002; Wed, 26 Oct 2022 13:31:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27BE78E0001; Wed, 26 Oct 2022 13:31:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16A5A8E0002; Wed, 26 Oct 2022 13:31:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 05A6D8E0001 for ; Wed, 26 Oct 2022 13:31:51 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8FC4D80334 for ; Wed, 26 Oct 2022 17:31:50 +0000 (UTC) X-FDA: 80063793180.17.978AD22 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf28.hostedemail.com (Postfix) with ESMTP id 0FCFBC0041 for ; Wed, 26 Oct 2022 17:31:48 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id t10-20020a17090a4e4a00b0020af4bcae10so2774062pjl.3 for ; Wed, 26 Oct 2022 10:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0KEX8H9AH+VpJzTG5dP3lIPlij9N0zbSJwy+i7UPqHg=; b=cGCfgC4hjmQQkF1Pxvr7cLXhW9PwDG011Q1yYpkKlGkU1OdLX/EXJIuLnwqbTCMenA qQcxLWZcGJwon4OZ/EY7D/3JZcT+CmJYRc+SMzVP+aoV5fpH0LlOcHeQ5Rvu5/TVKZfu 7zs0vqSrqvQhdjoUVr9e4w8kyQepA7Bh73nOUhsTf8dbXvD5yNraTKvL9vXLLNDXcIk3 PFw+FqKwfN6Qkd1BQoOhVO/0zCAaQKI7rU5r6TuvH7WyVvQZUdOUIhL0305Fdfo6F+7N bwu2wgky+pRe17X5czHVGnuD+R53XZYyqR79oq0bSJ8jTMTnfmqG7ITY+PjsZzrUcEcH Fu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0KEX8H9AH+VpJzTG5dP3lIPlij9N0zbSJwy+i7UPqHg=; b=MTwqrjrYuoQZuOkS3aho74SiXeUy5md4ga+ncU8pPhqCAISRD+BjRYYG36ye7E3oud BOY8M92ZxKZPSczmhglVF9gUyOynXko2WVMcCWm0IV+ZSqsliFJEgYlIjO4I0cOMzqAu UPS6um1zTXXhIJhOX4MeR7B5ML8KMoRrozjI7/qfEgR4FkKQ6XpbIa2LgsLQIMSEGReO Ugv776r3iQgm0AZeYuTDQCTRdymS1onphYpBZjPT3ExxkHZ1JPs4FIAn3HxT2P/cVJM8 gP8x2qVN2XhqeNyN1OUi1JgYT2uo2SmDTtTZb+qULClMddNQHy3Ej4QYkqkjLR7NR9Ae oBYQ== X-Gm-Message-State: ACrzQf3nbRLr6szmtFIyBtoCxxrAslzKHv/CrtELg2Chn6AxjMuZAnwv Gd0Wcuif6UxQ7xVmQfzqsiM= X-Google-Smtp-Source: AMsMyM5iyIsTFBeWCWiI/ZizQ3W6VbjiybP1poF7CjbEgG2VkVSvkP2kgtm+tVjWT4X2rpwsf2fFIQ== X-Received: by 2002:a17:902:6542:b0:172:95d8:a777 with SMTP id d2-20020a170902654200b0017295d8a777mr45124260pln.61.1666805507753; Wed, 26 Oct 2022 10:31:47 -0700 (PDT) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id y7-20020aa78f27000000b0056c814a501dsm436498pfr.10.2022.10.26.10.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 10:31:47 -0700 (PDT) Date: Wed, 26 Oct 2022 10:31:45 -0700 From: Isaku Yamahata To: Chao Peng Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, Muchun Song , wei.w.wang@intel.com, isaku.yamahata@gmail.com Subject: Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory Message-ID: <20221026173145.GA3819453@ls.amr.corp.intel.com> References: <20221025151344.3784230-1-chao.p.peng@linux.intel.com> <20221025151344.3784230-2-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221025151344.3784230-2-chao.p.peng@linux.intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666805509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0KEX8H9AH+VpJzTG5dP3lIPlij9N0zbSJwy+i7UPqHg=; b=dsgXvSkj2lu94PgMAtzfEEopKuvw1lcNF/4kyUaWR/5YsbWcK+4fABa8Au0/aHjzl+6Dj7 Dg3DLSjDuBLMdD254RNTd41S748Q1f4JFwFmx+pyc8MKMcGbVxFIzxpgUQbo8/5wWz0mku ONxBE325Ydu23lEo7sGUffudyVFRMeI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cGCfgC4h; spf=pass (imf28.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666805509; a=rsa-sha256; cv=none; b=Rg/0vI3vyeiEl6p0cKdvjIx5T2UpnsB0Zxm0IhQZA0jioZSn5V9MOwokCOOBlDVVH+VPR6 egC/vhkPqJPGqY677vgoJgRzh8uBOUq+7uGYNZrzE6XbmSzNLPNd8YbiUWGP6wv2BRNoii MfcorDCrJCPR4eZ0GF8DonkM8PY0dDQ= X-Rspamd-Queue-Id: 0FCFBC0041 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cGCfgC4h; spf=pass (imf28.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: c6q4z7ddpest1mew6b7ihmmf7nzowg8q X-HE-Tag: 1666805508-369085 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 11:13:37PM +0800, Chao Peng wrote: > +int restrictedmem_get_page(struct file *file, pgoff_t offset, > + struct page **pagep, int *order) > +{ > + struct restrictedmem_data *data = file->f_mapping->private_data; > + struct file *memfd = data->memfd; > + struct page *page; > + int ret; > + > + ret = shmem_getpage(file_inode(memfd), offset, &page, SGP_WRITE); shmem_getpage() was removed. https://lkml.kernel.org/r/20220902194653.1739778-34-willy@infradead.org I needed the following fix to compile. thanks, diff --git a/mm/restrictedmem.c b/mm/restrictedmem.c index e5bf8907e0f8..4694dd5609d6 100644 --- a/mm/restrictedmem.c +++ b/mm/restrictedmem.c @@ -231,13 +231,15 @@ int restrictedmem_get_page(struct file *file, pgoff_t offset, { struct restrictedmem_data *data = file->f_mapping->private_data; struct file *memfd = data->memfd; + struct folio *folio = NULL; struct page *page; int ret; - ret = shmem_getpage(file_inode(memfd), offset, &page, SGP_WRITE); + ret = shmem_get_folio(file_inode(memfd), offset, &folio, SGP_WRITE); if (ret) return ret; + page = folio_file_page(folio, offset); *pagep = page; if (order) *order = thp_order(compound_head(page)); -- Isaku Yamahata