From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8CEC38A2D for ; Tue, 25 Oct 2022 23:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0E5B8E0002; Tue, 25 Oct 2022 19:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABE848E0001; Tue, 25 Oct 2022 19:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985FF8E0002; Tue, 25 Oct 2022 19:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85DA28E0001 for ; Tue, 25 Oct 2022 19:17:21 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 531CEC09DC for ; Tue, 25 Oct 2022 23:17:21 +0000 (UTC) X-FDA: 80061035082.27.F9C7ED8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id E9E4F18000A for ; Tue, 25 Oct 2022 23:17:19 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 18C1161AAD; Tue, 25 Oct 2022 23:17:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1CB3C433D6; Tue, 25 Oct 2022 23:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666739838; bh=nV7OVDrwGLapIVrA2MkHe7ePYFXFsBK++LsqBN3LGxk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jgmD4R4nRxyvZqQf+RFkpy8OzZlwZWaN3uMpSb/mKDFK4G0lCt3Ub6SDpdtaf3acw RZVWqtWUdVWFpdnLdaoRDbX+u2XI7TUZeUGvvX6eMRqfThv4W+1QhoXi6FhA0uiu3U PNjHDugBCqcOWYunfi/Rxn2nqZEUG6HpBB5lfDfbMkst0/sSI7ZTmhUxaSyxO3Dp5g X0HKBuHzTUAQJMZ+v2mw/xPvuoxoT7NR1OW7a7axArGENNfisA0CnRHJWsile+/6Db VyiNFed0Lk2ahgi29Z9TjFLF2VANpmwGA00vmUK5eYV1xioMDnC9uB8Re4MJZgl8vv jUNx3NlKFq+vw== Date: Tue, 25 Oct 2022 16:17:16 -0700 From: Jakub Kicinski To: Doug Berger Cc: kernel test robot , Andrew Morton , ntfs3@lists.linux.dev, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , Julia Lawall Subject: Re: [linux-next:master] BUILD REGRESSION 89bf6e28373beef9577fa71f996a5f73a569617c Message-ID: <20221025161716.1b92a033@kernel.org> In-Reply-To: <8fbc9d02-3c73-5990-85af-82eecb6d64e3@gmail.com> References: <63581a3c.U6bx8B6mFoRe2pWN%lkp@intel.com> <20221025154150.729bbbd0@kernel.org> <8fbc9d02-3c73-5990-85af-82eecb6d64e3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666739840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bD5GABpHa9zczDjL/GJ7Nsm2ui5w4kCCUNvaFDGN2co=; b=DULwSM+vleImg7iUCNAb6VOq9bEjd0xgOUUoXpfbemt8TskUVgriBBmNBoKnmfuLlWfO8K iFELjQ6YGZjYpUMNaofSigOdeRVj4aa+ai9d6GfDzyYobvmP4jcHi9y3Ho5K8yikczS9tl jdIpVGsCdaJmjchwy11gKKYTMlBk8LE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jgmD4R4n; spf=pass (imf06.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666739840; a=rsa-sha256; cv=none; b=NQa0imQVnyZADqeWTj1g9bTZ7TkkJjj64TvzZ6A18R4O3kdu6DJgyk1yte1hjcj1xDcFn8 vYnOETJmIvBKr9wM2Ubda90CRLzhewXj0Mhs7KhlbsAPPObTdtEhDpZKTQuk/m+00hAp6q GU4OV1dvsUZ+oDTmq9FDs00sLLZ9fR8= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jgmD4R4n; spf=pass (imf06.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: 3rjtmjm754o3qifcc1wzi65kyfduu931 X-Rspamd-Queue-Id: E9E4F18000A X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1666739839-872321 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Oct 2022 16:04:15 -0700 Doug Berger wrote: > > On Wed, 26 Oct 2022 01:17:48 +0800 kernel test robot wrote: > >> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1497:5-13: ERROR: invalid reference to the index variable of the iterator on line 1475 > > > > CC Doug > Thanks for highlighting this for me, but I happened to catch it from the > linux-mm list and was just looking into it. > > It looks to me like a false positive since I am initializing the > loc_rule variable in all paths outside of the list_for_each_entry() loop > prior to its use on line 1497. Ack, indeed the code looks right. Thanks for investigating. > If desired I can submit a new patch to make coccinelle happy. I wonder if Cocci can detect writes. Let me add Julia for visibility. If not we can use a different variable for the "check if already exists" iteration? It could make the code easier to follow, IMHO. Or leave it be.